Skip to content

Fix fileMatch for Enonic XP Application mapping to avoid generic patterns #9#5711

Open
anatol-sialitski wants to merge 1 commit into
SchemaStore:masterfrom
enonic:issue-9
Open

Fix fileMatch for Enonic XP Application mapping to avoid generic patterns #9#5711
anatol-sialitski wants to merge 1 commit into
SchemaStore:masterfrom
enonic:issue-9

Conversation

@anatol-sialitski
Copy link
Copy Markdown
Contributor

This PR fixes:

  1. Publish Enonic XP descriptors JSON Schema 8.0.0-B5
  2. Fix fileMatch in catalog.json for Enonic XP Application mapping to avoid generic patterns

@anatol-sialitski
Copy link
Copy Markdown
Contributor Author

Hi @madskristensen and @hyperupcall,

Could you please review my PR? This PR fixes the fileMatch mapping in catalog.json to avoid generic patterns.

@westmc
Copy link
Copy Markdown

westmc commented May 29, 2026

@madskristensen @hyperupcall I just wanted to add support for this PR since it seems to be breaking Spring Boot application.yml verification for users of IntelliJ.

https://youtrack.jetbrains.com/issue/IJPL-245723/The-application.yaml-file-exception-triggers-a-schema-validation-error.

@anatol-sialitski anatol-sialitski changed the title Fix fileMatch for Enonic XP Admin Extension mapping #9 Fix fileMatch for Enonic XP Admin Extension mapping to avoid generic patterns #9 May 30, 2026
@anatol-sialitski anatol-sialitski changed the title Fix fileMatch for Enonic XP Admin Extension mapping to avoid generic patterns #9 Fix fileMatch for Enonic XP Application mapping to avoid generic patterns #9 May 30, 2026
@hyperupcall
Copy link
Copy Markdown
Member

hyperupcall commented Jun 1, 2026

Thanks, looks great except for the fileMatch changes. The generic parent paths were removed, but that still could end up causing more false positives, especially the **/tasks/*/*.yaml one. If you could revert all the fileMatch changes then I can merge this.

@anatol-sialitski anatol-sialitski force-pushed the issue-9 branch 2 times, most recently from 9d14272 to c1b3c52 Compare June 1, 2026 11:36
@anatol-sialitski
Copy link
Copy Markdown
Contributor Author

Hi @hyperupcall,

I've just reverted the fileMatch changes. Could you please take a look?

One check that is not related to my PR is failing due to:

Running "pre-checks" on file "./src/schemas/json/pnpm-workspace.json"
---
>> Failed strict jsonlint parse of file "./src/schemas/json/pnpm-workspace.json"
---
SyntaxError: Parse error on line 904, column 20:
...    "trustLockfile": {      "descripti...
----------------------^
Duplicate key: "trustLockfile"
    at createError (/home/runner/work/schemastore/schemastore/node_modules/@prantlf/jsonlint/lib/jsonlint.js:196:19)
    at fail (/home/runner/work/schemastore/schemastore/node_modules/@prantlf/jsonlint/lib/jsonlint.js:214:19)
    at parseObject (/home/runner/work/schemastore/schemastore/node_modules/@prantlf/jsonlint/lib/jsonlint.js:395:9)
    at parseGeneric (/home/runner/work/schemastore/schemastore/node_modules/@prantlf/jsonlint/lib/jsonlint.js:237:16)
    at parseObject (/home/runner/work/schemastore/schemastore/node_modules/@prantlf/jsonlint/lib/jsonlint.js:410:21)
    at parseGeneric (/home/runner/work/schemastore/schemastore/node_modules/@prantlf/jsonlint/lib/jsonlint.js:237:16)
    at parseInternal (/home/runner/work/schemastore/schemastore/node_modules/@prantlf/jsonlint/lib/jsonlint.js:711:21)
    at parseCustom (/home/runner/work/schemastore/schemastore/node_modules/@prantlf/jsonlint/lib/jsonlint.js:739:10)
    at Object.parse (/home/runner/work/schemastore/schemastore/node_modules/@prantlf/jsonlint/lib/jsonlint.js:981:7)
    at assertFilePassesJsonLint (file:///home/runner/work/schemastore/schemastore/cli.js:1711:14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants