Create graalvm25.json #563
Conversation
Added installer of graalvm 25 - jdk25
WalkthroughAdds a new Scoop manifest file for GraalVM Community Edition 25.0.0, including metadata, download URL and hash, extraction target, installer PowerShell script for directory layout, environment variable setup, version check via GitHub releases, and autoupdate configuration. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant S as Scoop
participant GH as GitHub Releases
participant PS as Installer Script
participant ENV as Env Vars
U->>S: scoop install graalvm25
S->>GH: Download graalvm-community-jdk-25.0.0_windows-x64_bin.zip
GH-->>S: ZIP file
S->>S: Extract to extract_to directory
S->>PS: Run installer script
rect rgba(200,230,255,0.25)
note right of PS: Reorganize extracted directories
PS->>ENV: Set JAVA_HOME and GRAALVM_HOME
PS->>ENV: Add bin to PATH
end
U-->>S: scoop update graalvm25
S->>GH: checkver (regex for 25.x)
alt New 25.x available
S->>S: autoupdate URL template and hash
else No update
S->>U: Already up to date
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. graalvm25
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| "url": "https://github.com/graalvm/graalvm-ce-builds/releases/latest", | ||
| "regex": "jdk-(25[\\d.]*)" | ||
| }, |
There was a problem hiding this comment.
Fix the checkver source for GraalVM 25 tags.
releases/latest only exposes the single most recent release (currently 25.0.0, but the next 21.x maintenance drop will replace it), so the current regex stops matching as soon as a 21.x build ships. That breaks Scoop’s automation for this manifest. Point checkver at the full release feed (via the github helper) and filter for 25.x tags instead.
- "checkver": {
- "url": "https://github.com/graalvm/graalvm-ce-builds/releases/latest",
- "regex": "jdk-(25[\\d.]*)"
- },
+ "checkver": {
+ "github": "graalvm/graalvm-ce-builds",
+ "regex": "jdk-(25[\\d.]+)"
+ },📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "url": "https://github.com/graalvm/graalvm-ce-builds/releases/latest", | |
| "regex": "jdk-(25[\\d.]*)" | |
| }, | |
| "checkver": { | |
| "github": "graalvm/graalvm-ce-builds", | |
| "regex": "jdk-(25[\\d.]+)" | |
| }, |
🤖 Prompt for AI Agents
In bucket/graalvm25.json around lines 21 to 23, the checkver currently points at
releases/latest which only returns a single latest tag and will stop matching
25.x once an older maintenance tag becomes latest; change the checkver source to
use the full GitHub release/tag feed (use the github helper or the repo tags
API) and update the regex to explicitly match 25.x tags (e.g. starting with "25"
and allowing dots) so Scoop finds all 25.y.z releases rather than only the
single latest release.
1 participant
Added installer of graalvm 25 - jdk25
Added the installer for graalvm 25 with JDK 25 to the Java bucket
There is yet another PR which aims to add the installer for Temurin 25, I'm just adding the installer for GraalVM 25
Note: I edited the installer of GraalVM 21, where the regex under checkver/version permits only versions with at least a minor spec. In this one I loosen a bit the check to allow versions without minor on the github release page
Relates to #561
Closes #562
Summary by CodeRabbit