Skip to content

Commit 6835ec2

Browse files
style: fix linting (#62)
* style: fix linting * build: travis files * test: fixing tests fixing most of the errors failing tests and builds
1 parent 8664588 commit 6835ec2

File tree

23 files changed

+3973
-4190
lines changed

23 files changed

+3973
-4190
lines changed

.eslintrc.json

Lines changed: 35 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,37 @@
11
{
2-
"globals": {
3-
"__webpack_modules__": true
4-
},
5-
"parser": "babel-eslint",
6-
"env": {
7-
"browser": true,
8-
"es6": true
9-
},
10-
"extends": "airbnb",
11-
"rules": {
12-
}
2+
"globals": {
3+
"window": true,
4+
"__webpack_modules__": true,
5+
"__webpack_require__": true,
6+
"__LOADABLE_LOADED_CHUNKS__": true
7+
},
8+
"parser": "babel-eslint",
9+
"env": {
10+
"browser": true,
11+
"es6": true,
12+
"node": true
13+
},
14+
"plugins": [
15+
"prettier"
16+
],
17+
"extends": [
18+
"airbnb",
19+
"plugin:prettier/recommended"
20+
],
21+
"rules": {
22+
"no-console": "off",
23+
"no-shadow": "warn",
24+
"no-param-reassign": "warn",
25+
"no-plusplus": "off",
26+
"global-require": "off",
27+
"import/no-extraneous-dependencies": "off",
28+
"no-nested-ternary": "off",
29+
"prefer-destructuring": "warn",
30+
"consistent-return": "warn",
31+
"eqeqeq": "warn",
32+
"no-new-func": "warn",
33+
"no-underscore-dangle": "off",
34+
"no-multi-assign": "off",
35+
"react/jsx-filename-extension": "off"
36+
}
1337
}

travis.yml renamed to .travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
- stage: Build
99
name: Travis Status
1010
script: npx travis-github-status
11-
# name: Linting
12-
# script: npm run lint
11+
name: Linting
12+
script: npm run lint
1313
after_success:
1414
- npm run semantic-release

manual/Website1/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"@babel/preset-react": "^7.0.0",
2121
"babel-core": "^7.0.0-bridge.0",
2222
"babel-loader": "^8.0.5",
23-
"eslint-loader": "^2.1.2",
23+
"eslint-loader": "^3.0.3",
2424
"react-hot-loader": "^4.8.3",
2525
"webpack": "^4.29.6",
2626
"webpack-cli": "^3.3.0",
@@ -36,16 +36,16 @@
3636
"@babel/plugin-proposal-class-properties": "^7.4.4",
3737
"clean-webpack-plugin": "^3.0.0",
3838
"crc-32": "^1.2.0",
39-
"cross-env": "^5.2.0",
39+
"cross-env": "^6.0.3",
4040
"html-webpack-plugin": "^4.0.0-beta.8",
41-
"mini-css-extract-plugin": "^0.6.0",
41+
"mini-css-extract-plugin": "^0.9.0",
4242
"moment": "^2.24.0",
4343
"optimize-css-assets-webpack-plugin": "^5.0.1",
4444
"react": "file:../../node_modules/react",
4545
"react-dom": "file:../../node_modules/react-dom",
4646
"regenerator-runtime": "^0.13.2",
4747
"scriptjs": "^2.5.9",
48-
"webpack-external-import": "0.0.1-beta.23",
48+
"webpack-external-import": "0.3.0-beta.0",
4949
"webpack-merge": "^4.2.1"
5050
}
5151
}

manual/Website1/yarn.lock

Lines changed: 952 additions & 1265 deletions
Large diffs are not rendered by default.
Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
1-
import React from 'react';
2-
import 'react-select';
1+
import React from "react";
2+
import "react-select";
33

4-
export const Title = ({ title }) => (
5-
<h1>
6-
TITLE COMPONENT:
7-
{title}
8-
</h1>
9-
);
4+
export const Title = ({ title }) => {
5+
window.wasExternalFunctionCalled = true;
6+
console.log("TitleComponent interleaving successful");
7+
return (
8+
<h1>
9+
TITLE COMPONENT:
10+
{title}
11+
</h1>
12+
);
13+
};
1014

1115
/* externalize:TitleComponent */

0 commit comments

Comments
 (0)