Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross_join constructs invalid SQL #858

Open
remiposo opened this issue Jan 23, 2025 · 1 comment
Open

cross_join constructs invalid SQL #858

remiposo opened this issue Jan 23, 2025 · 1 comment

Comments

@remiposo
Copy link

remiposo commented Jan 23, 2025

Description

In the example, SQL like CROSS JOIN ... ON ... is being constructed, but (at least in PostgreSQL) CROSS JOIN does not accept ON, leading to a syntax error.

Steps to Reproduce

Execute the example.

Expected Behavior

SELECT "character", "font"."name" FROM "character" CROSS JOIN "font"

Actual Behavior

SELECT "character", "font"."name" FROM "character" CROSS JOIN "font" ON "character"."font_id" = "font"."id"

Reproduces How Often

Every time

Versions

0.32.1

Additional Information

@reneklacan
Copy link

This is indeed broken and cross_join should not require condition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants