Skip to content

Commit 7eec9b9

Browse files
Add filtered sep (#952)
1 parent 03df6e7 commit 7eec9b9

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

formats/filtered/src/Filtered.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,12 @@ public function getParamDefinitions( array $definitions ) {
252252
// 'islist' => false,
253253
];
254254

255+
$params['sep'] = [
256+
'type' => 'string',
257+
'message' => 'smw-paramdesc-sep',
258+
'default' => ', ',
259+
];
260+
255261
foreach ( $this->mViewTypes as $viewType ) {
256262
$params = array_merge( $params, call_user_func( [ 'SRF\Filtered\View\\' . $viewType, 'getParameters' ] ) );
257263
}

formats/filtered/src/View/ListView.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,15 @@ class ListView extends View {
3333
private $mNamedArgs;
3434
private $mShowHeaders;
3535

36+
/** @var array */
37+
private $params;
38+
3639
/**
3740
* Transfers the parameters applicable to this view into internal variables.
3841
*/
3942
protected function handleParameters() {
4043
$params = $this->getActualParameters();
44+
$this->params = $params;
4145

4246
$this->mFormat = $params['list view type'];
4347
$this->mTemplate = $params['list view template'];
@@ -72,14 +76,18 @@ public function getResultText() {
7276
$footer = "</" . $this->mFormat . ">\n";
7377
$rowstart = "\t<li class='filtered-list-item ";
7478
$rowend = "</li>\n";
75-
$listsep = ', ';
79+
80+
// ***diversify from the sep below if necessary
81+
$listsep = $this->params['sep'];
7682
} else {
7783
// "list" format
7884
$header = '';
7985
$footer = '';
8086
$rowstart = "\t<div class='filtered-list-item ";
8187
$rowend = "</div>\n";
82-
$listsep = ', ';
88+
89+
// ***diversify from the sep above if necessary
90+
$listsep = $this->params['sep'];
8391
}
8492

8593
// Initialise more values

0 commit comments

Comments
 (0)