-
Notifications
You must be signed in to change notification settings - Fork 29
[feat] Generalize dynamic config classes #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this can work well with Python's implicit namespace packages, https://peps.python.org/pep-0420/ |
Not sure how much this helps though, since we still need to add a way to auto-import. We could import them all, but it would add to the startup time and the config/implementation separation complicates things a bit. I was thinking about somethings that makes the imports explicit, some options:
2 Somewhere near the config root. All in one place but distant from the classes that use them
|
Probably 2. is best. Do we really need this though, especially now? |
I'm not planning to implement plugins now, I think it should come once we have 2-3 places with dynamic classes and/or other teams working on this that would benefit from it. |
Short-term use case: components for testing, ex GPTTestSlowDatasetConfig from #129 |
🧐 Problem Description
#104 introduced a mechanism tor selecting config classes dynamically. This can be made useful elsewhere, especially for user-made plugins.
💡 Proposed Solution
Config
class🔄 Alternatives Considered
Having tons of forks for custom features is not practical in the long term.
📈 Potential Benefits
More flexible configuration, facilitate user contributions outside the main branch
The text was updated successfully, but these errors were encountered: