Skip to content
This repository was archived by the owner on Dec 24, 2022. It is now read-only.

Commit 172d428

Browse files
committed
Fix .NET Core Tests
1 parent e717e90 commit 172d428

File tree

4 files changed

+36
-19
lines changed

4 files changed

+36
-19
lines changed

lib/netstandard2.0/ServiceStack.Client.deps.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -863,6 +863,9 @@
863863
"System.Security.Cryptography.Primitives": "4.3.0",
864864
"System.Text.Encoding": "4.3.0",
865865
"runtime.native.System.Security.Cryptography.OpenSsl": "4.3.0"
866+
},
867+
"runtime": {
868+
"lib/netstandard1.6/System.Security.Cryptography.OpenSsl.dll": {}
866869
}
867870
},
868871
"System.Security.Cryptography.Primitives/4.3.0": {
@@ -1791,7 +1794,7 @@
17911794
"System.Xml.XmlSerializer/4.3.0": {
17921795
"type": "package",
17931796
"serviceable": true,
1794-
"sha512": "sha512-MYoTCP7EZ98RrANESW05J5ZwskKDoN0AuZ06ZflnowE50LTpbR5yRg3tHckTVm5j/m47stuGgCrCHWePyHS70Q==",
1797+
"sha512": "sha512-pXIz8nVP9y1uc3WCyTdl5LDesu2M6BDlMF7+JZS72oqKSZHXd2Q9PwepKFsFryWDMQEAjkjmyDEFu4FISdYfCw==",
17951798
"path": "system.xml.xmlserializer/4.3.0",
17961799
"hashPath": "system.xml.xmlserializer.4.3.0.nupkg.sha512"
17971800
},

src/ServiceStack.OrmLite.Sqlite/Converters/SqliteDateTimeConverter.cs

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,15 @@ public override object ToDbValue(Type fieldType, object value)
9090
if (DateStyle == DateTimeKind.Utc)
9191
{
9292
if (dateTime.Kind == DateTimeKind.Local)
93+
{
9394
dateTime = dateTime.ToUniversalTime();
95+
}
9496
else if (dateTime.Kind == DateTimeKind.Unspecified)
97+
{
98+
#if !NETSTANDARD2_0
9599
dateTime = DateTime.SpecifyKind(dateTime, DateTimeKind.Utc);
100+
#endif
101+
}
96102
}
97103
else if (DateStyle == DateTimeKind.Local && dateTime.Kind != DateTimeKind.Local)
98104
{
@@ -113,7 +119,14 @@ public override object FromDbValue(Type fieldType, object value)
113119
var dateTime = (DateTime)value;
114120

115121
if (DateStyle == DateTimeKind.Utc)
122+
{
123+
#if NETSTANDARD2_0
124+
//.NET Core returns correct UTC time but as Unspecified so just change to Utc
125+
dateTime = DateTime.SpecifyKind(dateTime, DateTimeKind.Utc);
126+
#else
116127
dateTime = dateTime.ToUniversalTime();
128+
#endif
129+
}
117130

118131
if (DateStyle == DateTimeKind.Local && dateTime.Kind != DateTimeKind.Local)
119132
{

tests/ServiceStack.OrmLite.Tests/DateTimeTests.cs

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -106,33 +106,33 @@ public void Does_return_UTC_Dates_with_UTC_DateStyle()
106106

107107
dateTime = new DateTime(2012, 1, 1, 1, 1, 1, DateTimeKind.Local);
108108
x = InsertAndSelectDateTime(db, dateTime);
109-
Assert.AreEqual(DateTimeKind.Utc, x.Test.Kind);
110-
Assert.AreEqual(DateTimeKind.Utc, x.TestNullable.Value.Kind);
111-
Assert.AreEqual(x.Test, x.TestNullable.Value);
112-
Assert.AreEqual(x.Test.ToUniversalTime(), dateTime.ToUniversalTime());
113-
Assert.AreEqual(x.Test.ToLocalTime(), dateTime.ToLocalTime());
109+
Assert.That(x.Test.Kind, Is.EqualTo(DateTimeKind.Utc));
110+
Assert.That(x.TestNullable.Value.Kind, Is.EqualTo(DateTimeKind.Utc));
111+
Assert.That(x.Test, Is.EqualTo(x.TestNullable.Value));
112+
Assert.That(x.Test.ToUniversalTime(), Is.EqualTo(dateTime.ToUniversalTime()));
113+
Assert.That(x.Test.ToLocalTime(), Is.EqualTo(dateTime.ToLocalTime()));
114114
x = db.Select<DateTimeObject>(d => d.Test == dateTime).FirstOrDefault();
115-
Assert.IsNotNull(x);
115+
Assert.That(x, Is.Not.Null);
116116

117117
dateTime = new DateTime(2012, 1, 1, 1, 1, 1, DateTimeKind.Utc);
118118
x = InsertAndSelectDateTime(db, dateTime);
119-
Assert.AreEqual(DateTimeKind.Utc, x.Test.Kind);
120-
Assert.AreEqual(DateTimeKind.Utc, x.TestNullable.Value.Kind);
121-
Assert.AreEqual(x.Test, x.TestNullable.Value);
122-
Assert.AreEqual(x.Test.ToUniversalTime(), dateTime.ToUniversalTime());
123-
Assert.AreEqual(x.Test.ToLocalTime(), dateTime.ToLocalTime());
119+
Assert.That(x.Test.Kind, Is.EqualTo(DateTimeKind.Utc));
120+
Assert.That(x.TestNullable.Value.Kind, Is.EqualTo(DateTimeKind.Utc));
121+
Assert.That(x.Test, Is.EqualTo(x.TestNullable.Value));
122+
Assert.That(x.Test.ToUniversalTime(), Is.EqualTo(dateTime.ToUniversalTime()));
123+
Assert.That(x.Test.ToLocalTime(), Is.EqualTo(dateTime.ToLocalTime()));
124124
x = db.Select<DateTimeObject>(d => d.Test == dateTime).FirstOrDefault();
125-
Assert.IsNotNull(x);
125+
Assert.That(x, Is.Not.Null);
126126

127127
dateTime = new DateTime(2012, 1, 1, 1, 1, 1, DateTimeKind.Unspecified);
128128
x = InsertAndSelectDateTime(db, dateTime);
129-
Assert.AreEqual(DateTimeKind.Utc, x.Test.Kind);
130-
Assert.AreEqual(DateTimeKind.Utc, x.TestNullable.Value.Kind);
131-
Assert.AreEqual(x.Test, x.TestNullable.Value);
132-
Assert.AreEqual(x.Test.ToUniversalTime(), dateTime);
133-
Assert.AreEqual(x.Test.ToLocalTime(), dateTime.ToLocalTime());
129+
Assert.That(x.Test.Kind, Is.EqualTo(DateTimeKind.Utc));
130+
Assert.That(x.TestNullable.Value.Kind, Is.EqualTo(DateTimeKind.Utc));
131+
Assert.That(x.Test, Is.EqualTo(x.TestNullable.Value));
132+
Assert.That(x.Test.ToUniversalTime(), Is.EqualTo(dateTime));
133+
Assert.That(x.Test.ToLocalTime(), Is.EqualTo(dateTime.ToLocalTime()));
134134
x = db.Select<DateTimeObject>(d => d.Test == dateTime).FirstOrDefault();
135-
Assert.IsNotNull(x);
135+
Assert.That(x, Is.Not.Null);
136136

137137
dialectProvider.GetDateTimeConverter().DateStyle = hold;
138138
}

tests/ServiceStack.OrmLite.Tests/Issues/LoadReferencesNullReferenceIssue.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ public void Does_not_load_references_when_RefId_is_null()
3232
using (var db = OpenDbConnection())
3333
{
3434
//db.DropAndCreateTable<UserAuth>(); //This test shouldn't query this table
35+
db.DropAndCreateTable<UserAuth>();
3536
db.DropAndCreateTable<DepartmentEntity>();
3637

3738
db.Insert(new DepartmentEntity { Name = "Dept A", Email = "[email protected]" });

0 commit comments

Comments
 (0)