Skip to content

docs: Remove admin role requirement for SPE container type creation#10877

Open
gnjoseph wants to merge 2 commits into
SharePoint:mainfrom
gnjoseph:agents/create-container-type-docs-update
Open

docs: Remove admin role requirement for SPE container type creation#10877
gnjoseph wants to merge 2 commits into
SharePoint:mainfrom
gnjoseph:agents/create-container-type-docs-update

Conversation

@gnjoseph

@gnjoseph gnjoseph commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Category

  • Content fix

Related issues

  • n/a

What's in this Pull Request?

Updates SharePoint Embedded container type docs to reflect that FileStorageContainerType.Manage.All no longer requires the SharePoint Embedded Administrator or Global Administrator role. Any non-guest user in the owning tenant can now create a container type and is automatically assigned as an owner.

  • docs/embedded/getting-started/containertypes.md rewrote Creating, Viewing, and Deleting sections to reflect the new ownership-based authorization model; fixed owningAppId owningApplicationId typo in the request body example
  • docs/embedded/administration/developer-admin/dev-admin.md added a note distinguishing the PowerShell path (admin required) from the Microsoft Graph path (no admin required)
  • docs/embedded/development/auth.md minor phrasing fix in Container type owner capabilities per reviewer feedback
  • docs/embedded/whats-new.md added June 2026 entry

Related documentation PRs

Updates SharePoint Embedded container type docs to reflect that
FileStorageContainerType.Manage.All no longer requires the SharePoint
Embedded Administrator or Global Administrator role. Any non-guest user
in the owning tenant can now create a container type and is automatically
assigned as an owner.

- containertypes.md: rewrote Creating/Viewing/Deleting sections; fixed
  owningAppId -> owningApplicationId typo in the request body example
- dev-admin.md: noted that the Graph path doesn't require admin
- auth.md: minor phrasing fix in 'Container type owner capabilities'
- whats-new.md: added June 2026 entry

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@learn-build-service-prod

Copy link
Copy Markdown
Contributor

Learn Build status updates of commit 8c0f25c:

✅ Validation status: passed

File Status Preview URL Details
docs/embedded/administration/developer-admin/dev-admin.md ✅Succeeded View
docs/embedded/development/auth.md ✅Succeeded View
docs/embedded/getting-started/containertypes.md ✅Succeeded View
docs/embedded/whats-new.md ✅Succeeded View

For more details, please refer to the build report.

@learn-build-service-prod

Copy link
Copy Markdown
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates SharePoint Embedded documentation to reflect an ownership-based authorization model for creating container types, removing the requirement for SharePoint Embedded Administrator / Global Administrator roles when using Microsoft Graph.

Changes:

  • Updated container type creation, viewing, and deletion guidance to reflect ownership-scoped access and non-admin creation.
  • Added a developer-admin doc note clarifying PowerShell vs Microsoft Graph role requirements.
  • Added a June 2026 “What’s new” entry documenting the authorization model change.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
docs/embedded/whats-new.md Adds June 2026 release note and updates ms.date.
docs/embedded/getting-started/containertypes.md Rewrites container type create/view/delete sections for the new ownership-based authorization model and updates the request example.
docs/embedded/development/auth.md Minor wording adjustment in container type owner capabilities and updates ms.date.
docs/embedded/administration/developer-admin/dev-admin.md Adds a note distinguishing PowerShell admin-role requirements from Microsoft Graph behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/embedded/administration/developer-admin/dev-admin.md Outdated
Comment thread docs/embedded/getting-started/containertypes.md
Comment thread docs/embedded/development/auth.md
Comment thread docs/embedded/development/auth.md Outdated
@andrewconnell

Copy link
Copy Markdown
Collaborator

@gnjoseph As you've requested Copilot to do a review, please address/resolve its findings before requesting my review. My review is the final review before merging => main and ultimately live.

For now, until that's complete, I'll remove my review.

@andrewconnell andrewconnell removed their request for review June 6, 2026 10:22
- dev-admin.md note: narrow the Graph-doesn't-require-admin claim to container type CRUD endpoints, and explicitly call out that other SPE Graph operations (e.g. `FileStorageContainer.Manage.All` for container management) still require an admin role. Addresses comment on docs/embedded/administration/developer-admin/dev-admin.md L23.
- auth.md "What's next": switch `FileStorageContainerType.Manage.All` permission type from `Role` to `Scope` in both the add and remove blocks. Per the live Microsoft Graph permissions reference, this permission is exposed only as a delegated scope (id `8e6ec84c-...`, AdminConsentRequired: No). The previous `type: Role` instruction was a pre-existing bug exposed by this PR; existing app permissions (`FileStorageContainerTypeReg.Selected`, `FileStorageContainer.Selected`) are correctly left as `Role`. Added an inline NOTE explaining the delegated nature and that admin consent isn't required, and softened the "Grant admin consent" step. Addresses comments on containertypes.md L42 and auth.md L152.
- auth.md L150: tighten dangling preposition ("they have a permission on" -> "on which they have a permission"). Keeps the AD-Aggregator spec author's preferred phrasing of "has/have a permission" over "appears in the permissions collection". Addresses comment on auth.md L150.
- Bumped `ms.date` on both modified files to 06/08/2026.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gnjoseph gnjoseph requested a review from andrewconnell June 8, 2026 19:45
@andrewconnell andrewconnell added pr:do-not-merge Pull request not ready to be merged pr:awaiting-peer-reviews Awaiting the requested reviewers to complete their review. labels Jun 8, 2026
@andrewconnell andrewconnell self-assigned this Jun 8, 2026
@andrewconnell

Copy link
Copy Markdown
Collaborator

@gnjoseph I'll review one other human reviews are complete. The presence of open requested reviews indicates to me that this PR still in flight and SME's have been requested to review the content.

I'm the last review before ultimately merging to main. Trying to avoid prematurely reviewing & publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:awaiting-peer-reviews Awaiting the requested reviewers to complete their review. pr:do-not-merge Pull request not ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants