Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count not being used in pluralised translations #3655

Open
david-w-shopify opened this issue Oct 24, 2024 · 0 comments
Open

count not being used in pluralised translations #3655

david-w-shopify opened this issue Oct 24, 2024 · 0 comments

Comments

@david-w-shopify
Copy link

david-w-shopify commented Oct 24, 2024

{
  "sections": {
    "quick_order_list": {
      "items_added": {
        "one": "{{ quantity }} item added",
        "other": "{{ quantity }} items added"
      },
      "items_removed": {
        "one": "{{ quantity }} item removed",
        "other": "{{ quantity }} items removed"
      }
    }
  }

I'm not sure if these translations should actually be deleted because in the copy of Dawn that I have, the translation doesn't appear to actually be used anywhere. I haven't had time to check the latest version yet.

If it has been left in intentionally though, I believe quantity should be replaced with count in order for the translation pluralisation rules to kick in. Otherwise I need to pass both quantity and count values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant