Merge pull request #608 from Shopify/js-discount-split-tests

Split Discount JS template test files

Author: davejcameron

discounts/javascript/discount/default/src/discount.test.liquid renamed to discounts/javascript/discount/default/src/generate_cart_run.test.liquid

@@ -1,15 +1,18 @@
+{%- if flavor contains "vanilla-js" -%}
 import { describe, it, expect } from "vitest";
 
 import { generateCartRun } from "./generate_cart_run";
-import { generateDeliveryRun } from "./generate_delivery_run";
 import {
   OrderDiscountSelectionStrategy,
   ProductDiscountSelectionStrategy,
-  DeliveryDiscountSelectionStrategy,
 } from "../generated/api";
 
-describe("discount", () => {
-  it("cart.lines.discounts.generate.run returns a product and order discount", () => {
+/**
+ * @typedef {import("../generated/api").CartLinesDiscountsGenerateRunResult} CartLinesDiscountsGenerateRunResult
+ */
+
+describe("generateCartRun", () => {
+  it("returns a product and order discount", () => {
     const input = {
       cart: {
         lines: [
@@ -72,42 +75,81 @@ describe("discount", () => {
       },
     });
   });
+});
+{%- elsif flavor contains "typescript" -%}
+import { describe, it, expect } from "vitest";
 
-  it("cart.delivery-options.generate.run returns a delivery discount", () => {
-    const input = {
+import { generateCartRun } from "./generate_cart_run";
+import {
+  OrderDiscountSelectionStrategy,
+  ProductDiscountSelectionStrategy,
+  CartInput,
+  CartLinesDiscountsGenerateRunResult
+} from "../generated/api";
+
+describe("generateCartRun", () => {
+  it("returns a product and order discount", () => {
+    const input: CartInput = {
       cart: {
-        deliveryGroups: [
+        lines: [
           {
-            id: "gid://shopify/DeliveryGroup/0",
+            id: "gid://shopify/CartLine/0",
+            cost: {
+              subtotalAmount: 100,
+            },
           },
         ],
       },
     };
 
-    const result = generateDeliveryRun(input);
+    const result: CartLinesDiscountsGenerateRunResult = generateCartRun(input);
 
-    expect(result.operations.length).toBe(1);
+    expect(result.operations.length).toBe(2);
     expect(result.operations[0]).toMatchObject({
-      deliveryDiscountsAdd: {
+      orderDiscountsAdd: {
         candidates: [
           {
-            message: "FREE DELIVERY",
+            message: "10% OFF ORDER",
             targets: [
               {
-                deliveryGroup: {
-                  id: "gid://shopify/DeliveryGroup/0",
+                orderSubtotal: {
+                  excludedCartLineIds: [],
                 },
               },
             ],
             value: {
               percentage: {
-                value: 100,
+                value: 10,
               },
             },
           },
         ],
-        selectionStrategy: DeliveryDiscountSelectionStrategy.All,
+        selectionStrategy: OrderDiscountSelectionStrategy.First,
+      },
+    });
+
+    expect(result.operations[1]).toMatchObject({
+      productDiscountsAdd: {
+        candidates: [
+          {
+            message: "20% OFF PRODUCT",
+            targets: [
+              {
+                cartLine: {
+                  id: "gid://shopify/CartLine/0",
+                },
+              },
+            ],
+            value: {
+              percentage: {
+                value: 20,
+              },
+            },
+          },
+        ],
+        selectionStrategy: ProductDiscountSelectionStrategy.First,
       },
     });
   });
 });
+{%- endif -%} 

discounts/javascript/discount/default/src/generate_delivery_run.test.liquid

@@ -0,0 +1,102 @@
+{%- if flavor contains "vanilla-js" -%}
+import { describe, it, expect } from "vitest";
+
+import { generateDeliveryRun } from "./generate_delivery_run";
+import {
+  DeliveryDiscountSelectionStrategy,
+} from "../generated/api";
+
+/**
+ * @typedef {import("../generated/api").CartDeliveryOptionsDiscountsGenerateRunResult} CartDeliveryOptionsDiscountsGenerateRunResult
+ * @typedef {import("../generated/api").DeliveryInput} DeliveryInput
+ */
+
+describe("generateDeliveryRun", () => {
+  it("returns a delivery discount", () => {
+    const input = /** @type {DeliveryInput} */ ({
+      cart: {
+        deliveryGroups: [
+          {
+            id: "gid://shopify/DeliveryGroup/0",
+          },
+        ],
+      },
+    });
+
+    const result = generateDeliveryRun(input);
+
+    expect(result.operations.length).toBe(1);
+    expect(result.operations[0]).toMatchObject({
+      deliveryDiscountsAdd: {
+        candidates: [
+          {
+            message: "FREE DELIVERY",
+            targets: [
+              {
+                deliveryGroup: {
+                  id: "gid://shopify/DeliveryGroup/0",
+                },
+              },
+            ],
+            value: {
+              percentage: {
+                value: 100,
+              },
+            },
+          },
+        ],
+        selectionStrategy: DeliveryDiscountSelectionStrategy.All,
+      },
+    });
+  });
+});
+{%- elsif flavor contains "typescript" -%}
+import { describe, it, expect } from "vitest";
+
+import { generateDeliveryRun } from "./generate_delivery_run";
+import {
+  DeliveryDiscountSelectionStrategy,
+  DeliveryInput,
+  CartDeliveryOptionsDiscountsGenerateRunResult
+} from "../generated/api";
+
+describe("generateDeliveryRun", () => {
+  it("returns a delivery discount", () => {
+    const input: DeliveryInput = {
+      cart: {
+        deliveryGroups: [
+          {
+            id: "gid://shopify/DeliveryGroup/0",
+          },
+        ],
+      },
+    };
+
+    const result: CartDeliveryOptionsDiscountsGenerateRunResult = generateDeliveryRun(input);
+
+    expect(result.operations.length).toBe(1);
+    expect(result.operations[0]).toMatchObject({
+      deliveryDiscountsAdd: {
+        candidates: [
+          {
+            message: "FREE DELIVERY",
+            targets: [
+              {
+                deliveryGroup: {
+                  id: "gid://shopify/DeliveryGroup/0",
+                },
+              },
+            ],
+            value: {
+              percentage: {
+                value: 100,
+              },
+            },
+          },
+        ],
+        selectionStrategy: DeliveryDiscountSelectionStrategy.All,
+      },
+    });
+  });
+});
+{%- endif -%}