-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Checkout UI] Add removeAttribute
interface
#650
Labels
enhancement
New feature or request
Comments
+1 for this 👍🏻 |
This is a necessary feature since the alternative is empty attributes in the order, which is not great. +1 |
+1 |
According to the latest AMA, adding this API is not planned https://discord.com/channels/842813079926603828/1159538499070984243 |
+1 |
+1, empty attributes can cause issue for some merchants |
+1 |
4 similar comments
+1 |
+1 |
+1 |
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please list the related package(s)
checkout-ui-extensions
If this related to specific APIs or components, please list them here
Is your feature request related to a problem? Please describe.
Unless I'm overlooking something, we can't remove cart attributes currently. Only
updateAttribute
is exposed which means even using an empty string keeps the attribute and we can't setnull
sincestring
is expected.Describe the changes you are looking for
Add
removeAttribute
interface which has a payload like:Similar to the removeMetafield or removeNote change apis.
Describe alternatives you’ve considered
Tried setting to null or empty string but cart attribute remains.
Additional context
See https://github.com/Shopify/ui-extensions/blob/main/packages/checkout-ui-extensions/src/extension-points/api/standard/index.ts#L167
The text was updated successfully, but these errors were encountered: