Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thai translation for JP 'province.optional' label is incorrect #305

Closed
rochlefebvre opened this issue Nov 11, 2024 · 2 comments
Closed

Thai translation for JP 'province.optional' label is incorrect #305

rochlefebvre opened this issue Nov 11, 2024 · 2 comments
Labels
Translation Issue Questions or suggestions from translators

Comments

@rochlefebvre
Copy link
Contributor

#303 incorrectly updated the thai label for worldwide.JP.addresses.province.label.optional from "จังหวัด (ไม่จำเป็น)" (Google translates as Province (not required)) to "จังหวัด", dropping the important optional part that distinguishes it from worldwide.JP.addresses.province.label.default.

Non-english translations should not be manually corrected. I left the error in PR 303, and I am opening this issue to track the correction in the upstream translation platform.
@rochlefebvre rochlefebvre added the Translation Issue Questions or suggestions from translators label Nov 11, 2024
@rochlefebvre rochlefebvre changed the title Thai translation for JP 'optional province' label is incorrect Thai translation for JP 'province.optional' label is incorrect Nov 11, 2024
@MRodriguezRod
Copy link

@rochlefebvre - Resolved on the Localization side.

@rochlefebvre
Copy link
Contributor Author

Fixed by #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Translation Issue Questions or suggestions from translators
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rochlefebvre @MRodriguezRod