Skip to content

Recent update unmoors the stops from the target lightness #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikestopcontinues opened this issue Mar 31, 2023 · 5 comments
Closed

Comments

@mikestopcontinues
Copy link

A few days ago, I generated a palette that tried to approximate the correct lightness stops. It would "stretch" the palette to match.

Screenshot 2023-03-31 at 2 06 54 PM

But today, I generated another that doesn't try to match the same steps.

Screenshot 2023-03-31 at 2 07 56 PM

I know this was probably an error, but if not—I really liked that functionality. It got me closer to the desired output. It would also be useful if you implement #18. Thoughts?

@SimeonGriggs
Copy link
Owner

Could you share the hex value for the 500?

@mikestopcontinues
Copy link
Author

Here's the orange: #D78528

@SimeonGriggs
Copy link
Owner

Actually, I've spotted it. The new logic only checks the distance of each stop away from each other in the array – not the value of the stop itself.

Thanks for reporting!

@SimeonGriggs
Copy link
Owner

Fixed in #49

@mikestopcontinues
Copy link
Author

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants