[CHORE] [MER-0000] Stabilize Playwright login and menu interactions (#6584)

* Fixed the 4 user_account tests to be much more reliable

* Avoid ambiguous sign-out locator

* Resolve visible admin sign-out control

Author: Dovidc

assets/automation/src/systems/torus/pom/home/LoginPO.ts

@@ -45,21 +45,51 @@ export class LoginPO {
   }
 
   async fillEmail(email: string) {
+    await this.waitForLoginForm();
     await this.emailInput.click();
     await this.emailInput.clear();
     await this.emailInput.fill(email);
+    await Verifier.expectToHaveValue(this.emailInput, email);
   }
 
   async fillPassword(password: string) {
+    await this.waitForLoginForm();
     await this.passwordInput.click();
     await this.passwordInput.clear();
     await this.passwordInput.fill(password);
+    await Verifier.expectToHaveValue(this.passwordInput, password);
+  }
+
+  async signIn(email: string, password: string) {
+    await this.waitForLoginForm();
+    await this.emailInput.fill(email);
+    await this.passwordInput.fill(password);
+    await Verifier.expectToHaveValue(this.emailInput, email);
+    await Verifier.expectToHaveValue(this.passwordInput, password);
+    await this.clickSignInButton();
   }
 
   async clickSignInButton() {
     await this.signInButton.click();
   }
 
+  private async waitForLoginForm() {
+    await Waiter.waitForLoadState(this.page);
+
+    try {
+      await Waiter.waitFor(this.page.locator('div.phx-connected').first(), 'attached');
+      await Waiter.waitFor(this.page.locator('div.phx-loading').first(), 'detached');
+    } catch {
+      // Some login pages may render without a LiveView root; the form checks below are the source of truth.
+    }
+
+    await Waiter.waitFor(this.emailInput, 'visible');
+    await Waiter.waitFor(this.passwordInput, 'visible');
+    await Verifier.expectIsEnabled(this.emailInput);
+    await Verifier.expectIsEnabled(this.passwordInput);
+    await Verifier.expectIsEnabled(this.signInButton);
+  }
+
   async selectRoleAccount(role: TypeUser) {
     const navbarco = new NavbarCO(this.page);
 

assets/automation/src/systems/torus/pom/home/MenuDropdownCO.ts

@@ -6,39 +6,44 @@ export class MenuDropdownCO {
   private readonly menuButtonAdmin: Locator;
   private readonly workspaceMenu: Locator;
   private readonly adminPanelLink: Locator;
-  private readonly signOutLink: Locator;
+  private readonly workspaceSignOutLink: Locator;
+  private readonly page: Page;
 
   constructor(page: Page) {
+    this.page = page;
     this.menuButton = page.locator('#workspace-user-menu');
     this.menuButtonAdmin = page.getByRole('button', { name: 'Playwright Admin profile' });
     this.workspaceMenu = page.locator('#workspace-user-menu-dropdown');
     this.adminPanelLink = this.workspaceMenu.getByRole('link', { name: 'Admin Panel' });
-    this.signOutLink = page.getByRole('link', { name: 'Sign out' });
+    this.workspaceSignOutLink = this.workspaceMenu.getByRole('link', { name: 'Sign out' });
   }
 
   async open(isAdminScreen = false) {
     if (isAdminScreen) {
       await this.menuButtonAdmin.click();
+      await this.waitForAdminSignOutControl();
     } else {
       await this.menuButton.click();
+      await Waiter.waitFor(this.workspaceMenu, 'visible');
     }
   }
 
   async goToAdminPanel() {
-    await this.adminPanelLink.click();
+    await Waiter.waitFor(this.adminPanelLink, 'visible');
+    await this.adminPanelLink.click({ force: true });
   }
 
   async signOut(isAdminScreen = false) {
     const menuButton = isAdminScreen ? this.menuButtonAdmin : this.menuButton;
 
     // Try to open the dropdown (two attempts in case of stale click)
-    for (let i = 0; i < 2; i++) {
+    for (let i = 0; i < 2 && !(await this.isSignOutMenuVisible(isAdminScreen)); i++) {
       await menuButton.click();
-      const visible = await this.workspaceMenu.waitFor({ state: 'visible', timeout: 1000 }).catch(() => false);
+      const visible = await this.waitForSignOutMenu(isAdminScreen);
       if (visible) break;
     }
 
-    const link = this.workspaceMenu.getByRole('link', { name: 'Sign out' });
+    const link = isAdminScreen ? await this.getAdminSignOutControl() : this.workspaceSignOutLink;
 
     // Preferred path: click the visible sign-out link
     const clicked = await link
@@ -49,8 +54,70 @@ export class MenuDropdownCO {
     if (clicked) return;
 
     // Fallback: clear session cookies and reload
-    const page = this.signOutLink.page();
+    const page = this.menuButton.page();
     await page.context().clearCookies();
     await page.goto('/');
   }
+
+  private async isSignOutMenuVisible(isAdminScreen: boolean) {
+    if (isAdminScreen) {
+      return (await this.findVisibleAdminSignOutControl()) !== undefined;
+    }
+
+    return await this.workspaceMenu.isVisible();
+  }
+
+  private async waitForSignOutMenu(isAdminScreen: boolean) {
+    if (isAdminScreen) {
+      return await this.waitForAdminSignOutControl()
+        .then(() => true)
+        .catch(() => false);
+    }
+
+    return await this.workspaceMenu
+      .waitFor({ state: 'visible', timeout: 1000 })
+      .then(() => true)
+      .catch(() => false);
+  }
+
+  private async waitForAdminSignOutControl() {
+    const deadline = Date.now() + 1000;
+
+    while (Date.now() < deadline) {
+      const control = await this.findVisibleAdminSignOutControl();
+
+      if (control) {
+        return control;
+      }
+
+      await this.page.waitForTimeout(100);
+    }
+
+    throw new Error('Admin sign-out control was not visible');
+  }
+
+  private async getAdminSignOutControl() {
+    const visibleControl = await this.findVisibleAdminSignOutControl();
+
+    return visibleControl ?? (await this.waitForAdminSignOutControl());
+  }
+
+  private async findVisibleAdminSignOutControl() {
+    for (const controls of [
+      this.page.getByRole('button', { name: 'Sign out' }),
+      this.page.getByRole('link', { name: 'Sign out' }),
+    ]) {
+      const count = await controls.count();
+
+      for (let i = 0; i < count; i++) {
+        const control = controls.nth(i);
+
+        if (await control.isVisible().catch(() => false)) {
+          return control;
+        }
+      }
+    }
+
+    return undefined;
+  }
 }

assets/automation/src/systems/torus/tasks/HomeTask.ts

@@ -45,9 +45,7 @@ export class HomeTask {
     await this.loginpo.verifyTitle(dataUser.pageTitle);
     await this.loginpo.verifyRole(dataUser.role);
     await this.loginpo.verifyWelcomeText(dataUser.welcomeText);
-    await this.loginpo.fillEmail(dataUser.email);
-    await this.loginpo.fillPassword(dataUser.pass);
-    await this.loginpo.clickSignInButton();
+    await this.loginpo.signIn(dataUser.email, dataUser.pass);
     await this.loginpo.verifyWelcomeTitle(dataUser.welcomeTitle);
 
     if (role === 'administrator') {