Skip to content

Commit 3b240ee

Browse files
authored
Merge pull request #223 from SkynetLabs/ivo/correction
Revert some changes
2 parents 2ea3f61 + 20281c7 commit 3b240ee

8 files changed

+11
-10
lines changed

Makefile

+2-7
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ else
2929
- DEL /F /Q cover output
3030
endif
3131

32-
run = .
32+
run = .
3333

3434
# count says how many times to run the tests.
3535
count = 1
@@ -85,7 +85,7 @@ ifneq ("$(OS)","Windows_NT")
8585
endif
8686

8787
# Define docker container name our test MongoDB instance.
88-
MONGO_TEST_CONTAINER_NAME=blocker-mongo-test-db
88+
MONGO_TEST_CONTAINER_NAME=accounts-mongo-test-db
8989

9090
# start-mongo starts a local mongoDB container with no persistence.
9191
# We first prepare for the start of the container by making sure the test
@@ -136,11 +136,6 @@ test-long-ci:
136136
@mkdir -p cover
137137
GORACE='$(racevars)' go test -race --coverprofile='./cover/cover.out' -v -failfast -tags='testing debug netgo' -timeout=600s $(pkgs) -run=$(run) -count=$(count)
138138

139-
# Cookie vars
140-
# TODO: Are these used?
141-
COOKIE_HASH_KEY="7eb32cfab5014d14394648dae1cf4e606727eee2267f6a50213cd842e61c5bce"
142-
COOKIE_ENC_KEY="65d31d12b80fc57df16d84c02a9bb62e2bc3b633388b05e49ef8abfdf0d35cf3"
143-
144139
# docker-generate is a docker command for env var generation
145140
#
146141
# The sleep is to allow time for the docker container to start up after `docker

api/handlers_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ func TestUserLimitsGetFromTier(t *testing.T) {
132132
}
133133
}()
134134
// The call that we expect to log a critical.
135-
_ = userLimitsGetFromTier("", math.MaxInt64, false, true)
135+
_ = userLimitsGetFromTier("", math.MaxInt, false, true)
136136
return
137137
}()
138138
if err != nil {

build/debug_off.go

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
//go:build !debug
12
// +build !debug
23

34
package build

build/debug_on.go

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
//go:build debug
12
// +build debug
23

34
package build

build/release_dev.go

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
//go:build dev
12
// +build dev
23

34
package build

build/release_standard.go

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
//go:build !testing && !dev
12
// +build !testing,!dev
23

34
package build

build/release_testing.go

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
//go:build testing
12
// +build testing
23

34
package build

types/email_test.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ import (
1212
func TestEmail_String(t *testing.T) {
1313
s := "mIxEdCaSeStRiNg"
1414
e := Email(s)
15-
if !strings.EqualFold(e.String(), s) {
15+
// We want to directly compare the strings in a case-sensitive way.
16+
if e.String() != strings.ToLower(s) {
1617
t.Fatalf("Expected '%s', got '%s'", strings.ToLower(s), e)
1718
}
1819
}
@@ -44,7 +45,7 @@ func TestEmail_UnmarshalJSON(t *testing.T) {
4445
t.Fatal(err)
4546
}
4647
// We expect the unmarshalled email to be lowercase only.
47-
if !strings.EqualFold(string(e), string(b[1:len(b)-1])) {
48+
if string(e) != strings.ToLower(string(b[1:len(b)-1])) {
4849
t.Fatalf("Expected to get a lowercase version of '%s', i.e. '%s' but got '%s'", e, strings.ToLower(string(e)), e)
4950
}
5051
}

0 commit comments

Comments
 (0)