From 6d910038433a8c3d041d86c842918f6a70cf45c7 Mon Sep 17 00:00:00 2001 From: Ethan Chen Date: Wed, 5 Feb 2014 23:02:17 -0800 Subject: [PATCH] Camera: Fix saturation, contrast, sharpness parameters * Old-style QCOM HALs use -max, new style HALs use max- for these parameters. Change-Id: I3b0dbd04f072cb69d09c44b5b3af1097560205b3 --- src/com/android/camera/CameraSettings.java | 6 +++--- src/com/android/camera/PhotoModule.java | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/com/android/camera/CameraSettings.java b/src/com/android/camera/CameraSettings.java index d245ded75..00275566d 100644 --- a/src/com/android/camera/CameraSettings.java +++ b/src/com/android/camera/CameraSettings.java @@ -392,17 +392,17 @@ private void initAdditionalPreferences(PreferenceGroup group){ } if (contrast != null && !CameraUtil.isSupported(mParameters, "contrast") && - !CameraUtil.isSupported(mParameters, "contrast-max")) { + !CameraUtil.isSupported(mParameters, "max-contrast")) { removePreference(group, contrast.getKey()); } if (sharpness != null && !CameraUtil.isSupported(mParameters, "sharpness") && - !CameraUtil.isSupported(mParameters, "sharpness-max")) { + !CameraUtil.isSupported(mParameters, "max-sharpness")) { removePreference(group, sharpness.getKey()); } if (saturation != null && !CameraUtil.isSupported(mParameters, "saturation") && - !CameraUtil.isSupported(mParameters, "saturation-max")) { + !CameraUtil.isSupported(mParameters, "max-saturation")) { removePreference(group, saturation.getKey()); } diff --git a/src/com/android/camera/PhotoModule.java b/src/com/android/camera/PhotoModule.java index 5f7cebf69..4712f29ae 100644 --- a/src/com/android/camera/PhotoModule.java +++ b/src/com/android/camera/PhotoModule.java @@ -2268,7 +2268,7 @@ private void updateAdditionalCameraParametersPreference() { } //Set Saturation if (CameraUtil.isSupported(mParameters, "saturation") && - CameraUtil.isSupported(mParameters, "saturation-max")) { + CameraUtil.isSupported(mParameters, "max-saturation")) { String saturationStr = mPreferences.getString( CameraSettings.KEY_SATURATION, mActivity.getString(R.string.pref_camera_saturation_default)); @@ -2280,7 +2280,7 @@ private void updateAdditionalCameraParametersPreference() { } // Set contrast parameter. if (CameraUtil.isSupported(mParameters, "contrast") && - CameraUtil.isSupported(mParameters, "contrast-max")) { + CameraUtil.isSupported(mParameters, "max-contrast")) { String contrastStr = mPreferences.getString( CameraSettings.KEY_CONTRAST, mActivity.getString(R.string.pref_camera_contrast_default)); @@ -2292,7 +2292,7 @@ private void updateAdditionalCameraParametersPreference() { } // Set sharpness parameter if (CameraUtil.isSupported(mParameters, "sharpness") && - CameraUtil.isSupported(mParameters, "sharpness-max")) { + CameraUtil.isSupported(mParameters, "max-sharpness")) { String sharpnessStr = mPreferences.getString( CameraSettings.KEY_SHARPNESS, mActivity.getString(R.string.pref_camera_sharpness_default));