Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesson10: stopwatch.asm appears to use old VRAM address #4

Open
ShawnLewis62 opened this issue Nov 23, 2022 · 1 comment
Open

Lesson10: stopwatch.asm appears to use old VRAM address #4

ShawnLewis62 opened this issue Nov 23, 2022 · 1 comment

Comments

@ShawnLewis62
Copy link

I believe the stopwatch lesson may need to be updated to work with the latest X16 release. I made these changes locally to get it to work:

% git diff origin
diff --git a/Lesson10/stopwatch.asm b/Lesson10/stopwatch.asm
index 4492aff..9834e0b 100644
--- a/Lesson10/stopwatch.asm
+++ b/Lesson10/stopwatch.asm
@@ -165,9 +165,10 @@ custom_irq_handler:

print_display:
stz VERA_ctrl

  • lda #$20 ; stride = 2
  • lda #$21 ; stride = 2
    sta VERA_addr_bank
    lda #DISPLAY_Y
  • ora #$B0
    sta VERA_addr_high
    lda #(DISPLAY_X * 2)
    sta VERA_addr_low

I tried to create a pull request for this, but I either have something set-up wrong (new system/set-up), or I don't have permissions to write to your repo:

ERROR: Permission to SlithyMatt/x16-assembly-tutorial.git denied to ShawnLewis62.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@Frosty-J
Copy link

To open a pull request, you should first fork this repository. Clicking the "Fork" button at the top-right of the page will create https://github.com/ShawnLewis62/x16-assembly-tutorial which you'll have full write access to. In your own repository's branch dropdown you can type in the field to create a new branch from main. Fetch it locally, push your changes to your own repo, and a big green button will show up on GitHub.com to open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants