Skip to content

Commit 1878d25

Browse files
committed
Modified comments in split_decompose.
1 parent ae77148 commit 1878d25

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

sparse_ir.f90

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -748,15 +748,13 @@ FUNCTION split_decompose(a, has_zero, eps, ill_conditioned) RESULT(dmat)
748748
!! fit(A, x) == v / s @ REAL(CONJG(TRANSPOSE(u)) * x)
749749
!!
750750
!! This again allows for fast and accurate least squares fits.
751-
!! Note that the imaginary part of the resulting IR basis coefficients
752-
!! will return bullshit values if the u or vt obtained by this subroutine
753-
!! are used to fit as follows:
754751
!!
755-
!! fit(A, x) == v / s @ (uH * x)
756-
!!
757-
!! Since this subroutine is only called when positive_only = true,
758-
!! the fitting is performed correctly in fit_matsubara_{f,b}
759-
!! distinguishing it from the case of positive_only = false.
752+
!! This subroutine is called if positive_only = true.
753+
!! If s, u, and vT are obtained in this subroutine, the imaginary
754+
!! part of (CONJG(TRANSPOSE(u)) * x) returns a non-zero
755+
!! value indeed, but that value should be ignored.
756+
!! Only the real part will be used in fit_matsubara_{f,b}
757+
!! if positive_only = true.
760758
!!
761759
!
762760
COMPLEX(KIND = DP), INTENT(IN) :: a(:, :)

0 commit comments

Comments
 (0)