Press backspace button on collapsed code blocks and crashed

[bejolly407]

No stacktrace is generated. See #835.

What happened: inside a C++ struct with several methods, I want to delete all of them but afraid scrolling, so I collapse them all, select what I want to delete and press backspace. I don't know whether it also crashes if I use delete button instead of backspace, btw.

[SpartanJ]

Can you reproduce it? If so can you share the exact code and how it was collapsed?

[bejolly407]

It crashed so suddenly that nothing is logged in ecode.log. I see - INFO: eepp initialized right in the next line without a new line we usually see. OK. The code is here:

test.mm

#import "common.h"
#import <cmath>
#import <gdiplus.h>
#import <iostream>
#import <vector>
#import <windows.h>

@interface test () {
  struct DrawSineWave {
    struct AppState {
      int width = 800;
      int height = 600;
      Gdiplus::GdiplusStartupInput gdiplusStartupInput;
      ULONG_PTR gdiplusToken;
    };
    static void Draw(HDC hdc, int width, int height) {

      if (width <= 0 || height <= 0)
        return;

      using namespace Gdiplus;

      Graphics graphics(hdc);
      graphics.SetSmoothingMode(SmoothingModeAntiAlias);

      // Background
      SolidBrush bgBrush(Color(255, 255, 255, 255));
      graphics.FillRectangle(&bgBrush, 0, 0, width, height);

      // Axis
      Pen axisPen(Color(200, 200, 200), 1.0f);
      graphics.DrawLine(&axisPen, 0, height / 2, width, height / 2);

      // Sine wave parameters
      double amplitude = (height - 20) / 2.0;
      double midY = height / 2.0;
      double period = width;
      double twoPi = 6.283185307179586;

      // Build points
      std::vector<PointF> pts;
      double step = 0.25; // smaller step for smoother curve
      for (double x = 0; x < width; x += step) {
        double t = x / period;
        double y = midY - amplitude * std::sin(twoPi * t);
        pts.push_back(PointF(static_cast<REAL>(x), static_cast<REAL>(y)));
      }

      // Draw sine wave
      Pen sinePen(Color(0, 120, 215), 2.0f);
      if (!pts.empty()) {
        graphics.DrawLines(&sinePen, pts.data(), static_cast<INT>(pts.size()));
      }
    }

    static LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wParam,
                                    LPARAM lParam) {
      using namespace Gdiplus;

      static AppState *state = nullptr;

      switch (msg) {
      case WM_CREATE: {
        state = new AppState();
        RECT rc;
        GetClientRect(hwnd, &rc);
        state->width = rc.right - rc.left;
        state->height = rc.bottom - rc.top;
        GdiplusStartup(&state->gdiplusToken, &state->gdiplusStartupInput,
                       nullptr);
        return 0;
      }
      case WM_SIZE: {
        if (state) {
          state->width = LOWORD(lParam);
          state->height = HIWORD(lParam);
          InvalidateRect(hwnd, nullptr, TRUE);
        }
        return 0;
      }
      case WM_PAINT: {
        PAINTSTRUCT ps;
        HDC hdc = BeginPaint(hwnd, &ps);
        if (state) {
          Draw(hdc, state->width, state->height);
        }
        EndPaint(hwnd, &ps);
        return 0;
      }
      case WM_ERASEBKGND:
        return 1; // prevent flicker
      case WM_DESTROY:
        if (state) {
          GdiplusShutdown(state->gdiplusToken);
          delete state;
          state = nullptr;
        }
        PostQuitMessage(0);
        return 0;
      default:
        return DefWindowProc(hwnd, msg, wParam, lParam);
      }
    }
    static int Setup(HINSTANCE hInstance, int nCmdShow) {
      static const char kClassName[] = "SineWaveWindowClass";
      WNDCLASSEX wc = {};
      wc.cbSize = sizeof(WNDCLASSEX);
      wc.style = CS_HREDRAW | CS_VREDRAW;
      wc.lpfnWndProc = WndProc;
      wc.hInstance = hInstance;
      wc.hIcon = LoadIcon(nullptr, IDI_APPLICATION);
      wc.hCursor = LoadCursor(nullptr, IDC_ARROW);
      wc.hbrBackground = (HBRUSH)(COLOR_WINDOW + 1);
      wc.lpszClassName = kClassName;
      wc.hIconSm = LoadIcon(nullptr, IDI_APPLICATION);

      if (!RegisterClassEx(&wc)) {
        MessageBox(nullptr, "Failed to register window class.", "Error",
                   MB_ICONERROR | MB_OK);
        return 0;
      }

      HWND hwnd = CreateWindowEx(
          0, kClassName, "Sine Wave - GDI+", WS_OVERLAPPEDWINDOW, CW_USEDEFAULT,
          CW_USEDEFAULT, 800, 600, nullptr, nullptr, hInstance, nullptr);

      if (!hwnd) {
        MessageBox(nullptr, "Failed to create window.", "Error",
                   MB_ICONERROR | MB_OK);
        return 0;
      }

      ShowWindow(hwnd, nCmdShow);
      UpdateWindow(hwnd);

      MSG msg = {};
      while (GetMessage(&msg, nullptr, 0, 0)) {
        TranslateMessage(&msg);
        DispatchMessage(&msg);
      }
      return static_cast<int>(msg.wParam);
    }
  };
}
@end

OF_APPLICATION_DELEGATE(test)

@implementation test
- (void)applicationDidFinishLaunching:(OFNotification *)notification {
  HINSTANCE hInstance = GetModuleHandle(nullptr);
  DrawSineWave::Setup(hInstance, SW_SHOW);
  [OFApplication terminate];
}
@end

common.h

#ifndef COMMON_H
#define COMMON_H

#import <ObjFW/ObjFW.h>

OF_ASSUME_NONNULL_BEGIN

@interface test : OFObject <OFApplicationDelegate>
@end

OF_ASSUME_NONNULL_END

#endif

The language is Objective C++

[bejolly407]

how it was collapsed?

I clicked the v button to turn it into >. I use the mouse to select what I want to delete (collapsed code blocks including new lines between them).

p/s: the next time I open that folder in ecode, it reopens the source file that crashes ecode (test.mm), so project state is still saved.

[SpartanJ]

I clicked the v button to turn it into >. I use the mouse to select what I want to delete (collapsed code blocks including new lines between them).

I mean, what did you collapse, so I can copy what you did and try to reproduce it, so far I was not able to reproduce it. Can you?

Edit: I was able to reproduce it by brute-force (created a script that tested each possible combination).

[SpartanJ]

It should be fixed, I was able to find several errors and fix them, all related to what you commented.