Implement completed failed counters.

Author: eerhardt

src/StackExchange.Redis/Message.cs

@@ -374,6 +374,9 @@ public void Complete()
 
             // set the completion/performance data
             performance?.SetCompleted();
+#if NET6_0_OR_GREATER
+            RedisMetrics.Instance.OnMessageComplete(currBox);
+#endif
 
             currBox?.ActivateContinuations();
         }
@@ -441,7 +444,7 @@ internal static Message Create(int db, CommandFlags flags, RedisCommand command,
                 3 => new CommandKeyKeyValueValueValueMessage(db, flags, command, key0, key1, values[0], values[1], values[2]),
                 4 => new CommandKeyKeyValueValueValueValueMessage(db, flags, command, key0, key1, values[0], values[1], values[2], values[3]),
                 5 => new CommandKeyKeyValueValueValueValueValueMessage(db, flags, command, key0, key1, values[0], values[1], values[2], values[3], values[4]),
-                6 => new CommandKeyKeyValueValueValueValueValueValueMessage(db, flags, command, key0, key1, values[0], values[1], values[2], values[3],values[4],values[5]),
+                6 => new CommandKeyKeyValueValueValueValueValueValueMessage(db, flags, command, key0, key1, values[0], values[1], values[2], values[3], values[4], values[5]),
                 7 => new CommandKeyKeyValueValueValueValueValueValueValueMessage(db, flags, command, key0, key1, values[0], values[1], values[2], values[3], values[4], values[5], values[6]),
                 _ => new CommandKeyKeyValuesMessage(db, flags, command, key0, key1, values),
             };

src/StackExchange.Redis/RedisMetrics.cs

@@ -9,32 +9,37 @@ internal sealed class RedisMetrics
 {
     private readonly Meter _meter;
     private readonly Counter<long> _operationCount;
-    //private readonly Counter<long> _completedAsynchronously;
-    //private readonly Counter<long> _completedSynchronously;
-    //private readonly Counter<long> _failedSynchronously;
+    private readonly Counter<long> _completedAsynchronously;
+    private readonly Counter<long> _completedSynchronously;
+    private readonly Counter<long> _failedAsynchronously;
+    private readonly Counter<long> _failedSynchronously;
     private readonly Counter<long> _nonPreferredEndpointCount;
 
     public static readonly RedisMetrics Instance = new RedisMetrics();
 
-    public RedisMetrics()
+    private RedisMetrics()
     {
         _meter = new Meter("StackExchange.Redis");
 
         _operationCount = _meter.CreateCounter<long>(
             "redis-operation-count",
             description: "The number of operations performed.");
 
-        //_completedAsynchronously = _meter.CreateCounter<long>(
-        //    "redis-completed-asynchronously",
-        //    description: "The number of operations that have been completed asynchronously.");
+        _completedAsynchronously = _meter.CreateCounter<long>(
+            "redis-completed-asynchronously",
+            description: "The number of operations that have been completed asynchronously.");
 
-        //_completedSynchronously = _meter.CreateCounter<long>(
-        //    "redis-completed-synchronously",
-        //    description: "The number of operations that have been completed synchronously.");
+        _completedSynchronously = _meter.CreateCounter<long>(
+            "redis-completed-synchronously",
+            description: "The number of operations that have been completed synchronously.");
 
-        //_failedSynchronously = _meter.CreateCounter<long>(
-        //    "redis-failed-synchronously",
-        //    description: "The number of operations that failed to complete asynchronously.");
+        _failedAsynchronously = _meter.CreateCounter<long>(
+            "redis-failed-asynchronously",
+            description: "The number of operations that failed to complete asynchronously.");
+
+        _failedSynchronously = _meter.CreateCounter<long>(
+            "redis-failed-synchronously",
+            description: "The number of operations that failed to complete synchronously.");
 
         _nonPreferredEndpointCount = _meter.CreateCounter<long>(
             "redis-non-preferred-endpoint-count",
@@ -50,6 +55,27 @@ public void IncrementOperationCount(string endpoint)
         }
     }
 
+    public void OnMessageComplete(IResultBox? result)
+    {
+        if (result is not null &&
+            (_completedAsynchronously.Enabled ||
+            _completedSynchronously.Enabled ||
+            _failedAsynchronously.Enabled ||
+            _failedSynchronously.Enabled))
+        {
+            Counter<long> counter = (result.IsFaulted, result.IsAsync) switch
+            {
+                (false, true) => _completedAsynchronously,
+                (false, false) => _completedSynchronously,
+                (true, true) => _failedAsynchronously,
+                (true, false) => _failedSynchronously,
+            };
+
+            // TODO: can we pass endpoint here?
+            counter.Add(1);
+        }
+    }
+
     public void IncrementNonPreferredEndpointCount(string endpoint)
     {
         if (_nonPreferredEndpointCount.Enabled)