Fix settings: dark borders, update dropdown z-index, dead accessibility link (#6528)

Author: Frooodle

frontend/editor/src/core/components/shared/Footer.tsx

@@ -44,13 +44,10 @@ export default function Footer({
   // Default URLs
   const defaultTermsUrl = "https://www.stirling.com/terms";
   const defaultPrivacyUrl = "https://www.stirling.com/privacy";
-  const defaultAccessibilityUrl = "https://www.stirling.com/accessibility";
 
   // Use provided URLs or fall back to defaults
   const finalTermsUrl = finalTermsAndConditions || defaultTermsUrl;
   const finalPrivacyUrl = finalPrivacyPolicy || defaultPrivacyUrl;
-  const finalAccessibilityUrl =
-    finalAccessibilityStatement || defaultAccessibilityUrl;
 
   // Helper to check if a value is valid (not null/undefined/empty string)
   const isValidLink = (link?: string) => link && link.trim().length > 0;
@@ -121,14 +118,16 @@ export default function Footer({
         >
           {t("footer.issues", "GitHub")}
         </a>
-        <a
-          className="footer-link px-3"
-          target="_blank"
-          rel="noopener noreferrer"
-          href={finalAccessibilityUrl}
-        >
-          {t("legal.accessibility", "Accessibility")}
-        </a>
+        {isValidLink(finalAccessibilityStatement) && (
+          <a
+            className="footer-link px-3"
+            target="_blank"
+            rel="noopener noreferrer"
+            href={finalAccessibilityStatement}
+          >
+            {t("legal.accessibility", "Accessibility")}
+          </a>
+        )}
         {isValidLink(finalCookiePolicy) && (
           <a
             className="footer-link px-3"

frontend/editor/src/core/components/shared/config/configSections/GeneralSection.tsx

@@ -451,6 +451,10 @@ const GeneralSection: React.FC<GeneralSectionProps> = ({
                     },
                   ]}
                   maw={360}
+                  comboboxProps={{
+                    withinPortal: true,
+                    zIndex: Z_INDEX_OVER_CONFIG_MODAL,
+                  }}
                 />
               </Stack>
             )}

frontend/editor/src/core/styles/theme.css

@@ -515,7 +515,7 @@
   /* Always-dark text (for use on light backgrounds like alerts) - does not change in dark mode */
   --text-always-dark: #1f2937;
   --text-always-dark-muted: #6b7280;
-  --border-subtle: #2a2f36;
+  --border-subtle: rgba(255, 255, 255, 0.08);
   --border-default: #3a4047;
   --border-strong: #4b5563;
   --hover-bg: #374151;

frontend/editor/src/core/tests/stubbed/main-dashboard.spec.ts

@@ -104,9 +104,6 @@ test.describe("2. Main Dashboard / Home Page", () => {
       await expect(page.getByText("GitHub").first()).toBeVisible({
         timeout: 10000,
       });
-      await expect(page.getByText("Accessibility").first()).toBeVisible({
-        timeout: 10000,
-      });
 
       const githubLink = page
         .locator('a[href*="github.com/Stirling-Tools/Stirling-PDF"]')