From 7ccd11dd21fcd40d232956972542e77e69d0ec0d Mon Sep 17 00:00:00 2001 From: Anthony Stirling Date: Thu, 4 Jun 2026 00:04:52 +0100 Subject: [PATCH 1/2] Fix settings: dark borders, update dropdown z-index, dead accessibility link --- .../src/core/components/shared/Footer.tsx | 21 +++++++++---------- .../config/configSections/GeneralSection.tsx | 4 ++++ frontend/editor/src/core/styles/theme.css | 2 +- 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/frontend/editor/src/core/components/shared/Footer.tsx b/frontend/editor/src/core/components/shared/Footer.tsx index 650917ed1a..e7037f6e41 100644 --- a/frontend/editor/src/core/components/shared/Footer.tsx +++ b/frontend/editor/src/core/components/shared/Footer.tsx @@ -44,13 +44,10 @@ export default function Footer({ // Default URLs const defaultTermsUrl = "https://www.stirling.com/terms"; const defaultPrivacyUrl = "https://www.stirling.com/privacy"; - const defaultAccessibilityUrl = "https://www.stirling.com/accessibility"; // Use provided URLs or fall back to defaults const finalTermsUrl = finalTermsAndConditions || defaultTermsUrl; const finalPrivacyUrl = finalPrivacyPolicy || defaultPrivacyUrl; - const finalAccessibilityUrl = - finalAccessibilityStatement || defaultAccessibilityUrl; // Helper to check if a value is valid (not null/undefined/empty string) const isValidLink = (link?: string) => link && link.trim().length > 0; @@ -121,14 +118,16 @@ export default function Footer({ > {t("footer.issues", "GitHub")} - - {t("legal.accessibility", "Accessibility")} - + {isValidLink(finalAccessibilityStatement) && ( + + {t("legal.accessibility", "Accessibility")} + + )} {isValidLink(finalCookiePolicy) && ( = ({ }, ]} maw={360} + comboboxProps={{ + withinPortal: true, + zIndex: Z_INDEX_OVER_CONFIG_MODAL, + }} /> )} diff --git a/frontend/editor/src/core/styles/theme.css b/frontend/editor/src/core/styles/theme.css index 9980e5ea97..83e8f00434 100644 --- a/frontend/editor/src/core/styles/theme.css +++ b/frontend/editor/src/core/styles/theme.css @@ -515,7 +515,7 @@ /* Always-dark text (for use on light backgrounds like alerts) - does not change in dark mode */ --text-always-dark: #1f2937; --text-always-dark-muted: #6b7280; - --border-subtle: #2a2f36; + --border-subtle: rgba(255, 255, 255, 0.08); --border-default: #3a4047; --border-strong: #4b5563; --hover-bg: #374151; From f099160ed8630e2e9c3af36563bcc7a2e4370ff8 Mon Sep 17 00:00:00 2001 From: Anthony Stirling Date: Thu, 4 Jun 2026 09:57:09 +0100 Subject: [PATCH 2/2] Remove Accessibility footer link test assertion --- frontend/editor/src/core/tests/stubbed/main-dashboard.spec.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/frontend/editor/src/core/tests/stubbed/main-dashboard.spec.ts b/frontend/editor/src/core/tests/stubbed/main-dashboard.spec.ts index 346f9ccae1..11318c1692 100644 --- a/frontend/editor/src/core/tests/stubbed/main-dashboard.spec.ts +++ b/frontend/editor/src/core/tests/stubbed/main-dashboard.spec.ts @@ -104,9 +104,6 @@ test.describe("2. Main Dashboard / Home Page", () => { await expect(page.getByText("GitHub").first()).toBeVisible({ timeout: 10000, }); - await expect(page.getByText("Accessibility").first()).toBeVisible({ - timeout: 10000, - }); const githubLink = page .locator('a[href*="github.com/Stirling-Tools/Stirling-PDF"]')