Skip to content
This repository was archived by the owner on Sep 6, 2018. It is now read-only.

Commit fcdd1bc

Browse files
authored
Remove deprecated variables
2 parents a2fe0c0 + 6757b39 commit fcdd1bc

7 files changed

+18
-94
lines changed

CHANGELOG.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ _None_
1010

1111
### Breaking Changes
1212

13-
_None_
13+
* Removed deprecated variables. See [SwiftGenKit#5](https://github.com/SwiftGen/SwiftGenKit/issues/5) for more information.
14+
[David Jennes](https://github.com/djbe)
15+
[#35](https://github.com/SwiftGen/templates/issues/35)
1416

1517
### New Features
1618

Sources/Stencil/AssetsCatalogContext.swift

+3-24
Original file line numberDiff line numberDiff line change
@@ -19,39 +19,18 @@ import Foundation
1919
*/
2020
extension AssetsCatalogParser {
2121
public func stencilContext(enumName: String = "Asset") -> [String: Any] {
22-
let images = catalogs.flatMap { justValues(entries: $1) }.sorted(by: <)
23-
let structured = catalogs.keys.sorted(by: <).map { name -> [String: Any] in
22+
let catalogs = self.catalogs.keys.sorted(by: <).map { name -> [String: Any] in
2423
return [
2524
"name": name,
26-
"assets": structure(entries: catalogs[name] ?? [])
25+
"assets": structure(entries: self.catalogs[name] ?? [])
2726
]
2827
}
2928

3029
return [
31-
"catalogs": structured,
32-
33-
// NOTE: This is a deprecated variable
34-
"enumName": enumName,
35-
"images": images,
36-
"param": ["enumName": enumName]
30+
"catalogs": catalogs
3731
]
3832
}
3933

40-
private func justValues(entries: [Entry]) -> [String] {
41-
var result = [String]()
42-
43-
for entry in entries {
44-
switch entry {
45-
case let .group(name: _, items: items):
46-
result += justValues(entries: items)
47-
case let .image(name: _, value: value):
48-
result += [value]
49-
}
50-
}
51-
52-
return result
53-
}
54-
5534
private func structure(entries: [Entry]) -> [[String: Any]] {
5635
return entries.map { entry in
5736
switch entry {

Sources/Stencil/ColorsContext.swift

+2-10
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,12 @@ extension ColorsFileParser {
2727
"red": comps[0],
2828
"green": comps[1],
2929
"blue": comps[2],
30-
"alpha": comps[3],
31-
32-
// NOTE: This is a deprecated variable
33-
"rgba": String(hexChars[0..<8]),
34-
"rgb": String(hexChars[0..<6])
30+
"alpha": comps[3]
3531
]
3632
}).sorted { $0["name"] ?? "" < $1["name"] ?? "" }
3733

3834
return [
39-
"colors": colorMap,
40-
41-
// NOTE: This is a deprecated variable
42-
"enumName": enumName,
43-
"param": ["enumName": enumName]
35+
"colors": colorMap
4436
]
4537
}
4638
}

Sources/Stencil/FontsContext.swift

+3-10
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,9 @@ extension FontsFileParser {
2424
return [
2525
"name": font.postScriptName,
2626
"path": font.filePath,
27-
"style": font.style,
28-
29-
// NOTE: This is a deprecated variable
30-
"fontName": font.postScriptName
27+
"style": font.style
3128
]
32-
}.sorted { $0["fontName"] ?? "" < $1["fontName"] ?? "" }
29+
}.sorted { $0["name"] ?? "" < $1["name"] ?? "" }
3330
// Family
3431
return [
3532
"name": name,
@@ -38,11 +35,7 @@ extension FontsFileParser {
3835
}.sorted { $0["name"] as? String ?? "" < $1["name"] as? String ?? "" }
3936

4037
return [
41-
"families": families,
42-
43-
// NOTE: This is a deprecated variable
44-
"enumName": enumName,
45-
"param": ["enumName": enumName]
38+
"families": families
4639
]
4740
}
4841
}

Sources/Stencil/StoryboardsContext.swift

+3-18
Original file line numberDiff line numberDiff line change
@@ -59,16 +59,7 @@ extension StoryboardParser {
5959
}
6060
return [
6161
"modules": modules.sorted(),
62-
"storyboards": storyboardsMap,
63-
64-
// NOTE: This is a deprecated variable
65-
"extraImports": modules.sorted(),
66-
"param": [
67-
"sceneEnumName": sceneEnumName,
68-
"segueEnumName": segueEnumName
69-
],
70-
"sceneEnumName": sceneEnumName,
71-
"segueEnumName": segueEnumName
62+
"storyboards": storyboardsMap
7263
]
7364
}
7465

@@ -80,10 +71,7 @@ extension StoryboardParser {
8071
]
8172
} else {
8273
return [
83-
"baseType": uppercaseFirst(scene.tag),
84-
85-
// NOTE: This is a deprecated variable
86-
"isBaseViewController": scene.tag == "viewController"
74+
"baseType": uppercaseFirst(scene.tag)
8775
]
8876
}
8977
}
@@ -98,10 +86,7 @@ extension StoryboardParser {
9886
} else if scene.tag == "viewController" {
9987
return [
10088
"identifier": scene.storyboardID,
101-
"baseType": uppercaseFirst(scene.tag),
102-
103-
// NOTE: This is a deprecated variable
104-
"isBaseViewController": scene.tag == "viewController"
89+
"baseType": uppercaseFirst(scene.tag)
10590
]
10691
} else {
10792
return [

Sources/Stencil/StringsContext.swift

+3-30
Original file line numberDiff line numberDiff line change
@@ -32,38 +32,21 @@ extension StringsFileParser {
3232
public func stencilContext(enumName: String = "L10n", tableName: String = "Localizable") -> [String: Any] {
3333

3434
let entryToStringMapper = { (entry: Entry, keyPath: [String]) -> [String: Any] in
35-
var keyStructure = entry.keyStructure
36-
Array(0..<keyPath.count).forEach { _ in keyStructure.removeFirst() }
37-
let levelName = keyStructure.joined(separator: ".")
35+
let levelName = entry.keyStructure.last ?? ""
3836

3937
var result: [String: Any] = [
4038
"name": levelName,
4139
"key": entry.key.newlineEscaped,
42-
"translation": entry.translation.newlineEscaped,
43-
44-
// NOTE: keytail is deprecated
45-
"keytail": levelName
40+
"translation": entry.translation.newlineEscaped
4641
]
4742

4843
if entry.types.count > 0 {
4944
result["types"] = entry.types.map { $0.rawValue }
50-
51-
// NOTE: params is deprecated
52-
result["params"] = [
53-
"types": entry.types.map { $0.rawValue },
54-
"count": entry.types.count,
55-
"declarations": entry.types.indices.map { "let p\($0)" },
56-
"names": entry.types.indices.map { "p\($0)" },
57-
"typednames": entry.types.enumerated().map { "p\($0): \($1.rawValue)" }
58-
]
5945
}
6046

6147
return result
6248
}
6349

64-
let strings = entries
65-
.sorted { $0.key.caseInsensitiveCompare($1.key) == .orderedAscending }
66-
.map { entryToStringMapper($0, []) }
6750
let structuredStrings = structure(
6851
entries: entries,
6952
usingMapper: entryToStringMapper
@@ -74,14 +57,7 @@ extension StringsFileParser {
7457
]]
7558

7659
return [
77-
"tables": tables,
78-
79-
// NOTE: These are deprecated variables
80-
"enumName": enumName,
81-
"param": ["enumName": enumName],
82-
"strings": strings,
83-
"structuredStrings": structuredStrings,
84-
"tableName": tableName
60+
"tables": tables
8561
]
8662
}
8763

@@ -139,9 +115,6 @@ extension StringsFileParser {
139115

140116
if !children.isEmpty {
141117
structuredStrings["children"] = children
142-
143-
// NOTE: These are deprecated variables
144-
structuredStrings["subenums"] = children
145118
}
146119

147120
return structuredStrings

Tests/Resources

Submodule Resources updated 133 files

0 commit comments

Comments
 (0)