Skip to content

Commit cb7babe

Browse files
oxyzenQSyllo
authored andcommitted
Fix typos across documentation and source
- Correct dependency spelling in README for multiple distro instructions @README.markdown#193-276 - Clean up misspellings in CMake helpers and GPU info sources (temperature, PCIe, queries, etc.) @cmake/modules/FindCurses.cmake#50-58 @cmake/modules/sanitize-helpers.cmake#103-118 @src/extract_gpuinfo_amdgpu.c#444-637 @src/extract_gpuinfo_intel.c#225-234 @src/extract_gpuinfo_metax.c#100-512 @src/nvtop.c#70-77 - Fix header comments and struct field names for allocations, callbacks, and utilize fields @src/extract_processinfo_fdinfo.c#97-104 @include/nvtop/common.h#44-52 @include/nvtop/extract_processinfo_fdinfo.h#59-63 @include/ascend/dcmi_interface_api.h#75-455 @include/nvtop/interface_options.h#43-54 @src/interface.c#792-800 Author: rezky_nightky <with.rezky@gmail.com> Timestamp: 2025-12-01T18:21:25Z Repository: nvtop Branch: master Signing: GPG (989AF9F0) Performance: 13 files, +31/-31 lines
1 parent c48d058 commit cb7babe

13 files changed

Lines changed: 31 additions & 31 deletions

README.markdown

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -196,11 +196,11 @@ sudo apt install nvtop
196196
sudo apt install libudev-dev
197197
```
198198

199-
- NVIDIA Depenency
199+
- NVIDIA Dependency
200200
- NVIDIA drivers (see [Ubuntu Wiki](https://help.ubuntu.com/community/BinaryDriverHowto/Nvidia) or [Ubuntu PPA](https://launchpad.net/~graphics-drivers/+archive/ubuntu/ppa) or [Debian Wiki](https://wiki.debian.org/NvidiaGraphicsDrivers#NVIDIA_Proprietary_Driver))
201201

202202
- NVTOP Dependencies
203-
- CMake, ncurses and Git
203+
- CMake, ncurses and Git
204204
```bash
205205
sudo apt install cmake libncurses5-dev libncursesw5-dev git
206206
```
@@ -240,11 +240,11 @@ A standalone application is available as [AppImage](#appimage).
240240
sudo dnf install libdrm-devel systemd-devel
241241
```
242242

243-
- NVIDIA Depenency
243+
- NVIDIA Dependency
244244
- NVIDIA drivers, **CUDA required for nvml libraries** (see [RPM Fusion](https://rpmfusion.org/Howto/NVIDIA))
245245

246246
- NVTOP Dependencies
247-
- CMake, ncurses, C++ and Git
247+
- CMake, ncurses, C++ and Git
248248
```bash
249249
sudo dnf install cmake ncurses-devel git gcc-c++
250250
```
@@ -258,12 +258,12 @@ A standalone application is available as an [AppImage](#appimage).
258258

259259
Build process for OpenSUSE:
260260

261-
- AMD Dependecy
261+
- AMD Dependency
262262
```bash
263263
sudo zypper install libdrm-devel
264264
```
265265

266-
- NVIDIA Depenency
266+
- NVIDIA Dependency
267267
- NVIDIA drivers (see [SUSE Support Database](https://en.opensuse.org/SDB:NVIDIA_drivers))
268268

269269
- NVTOP Dependencies

cmake/modules/FindCurses.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ if(NOT CURSES_NEED_WIDE)
5353
set(NCURSES_LIBRARY_NAME "ncurses")
5454
else()
5555
set(NCURSES_LIBRARY_NAME "ncursesw")
56-
# Also, if we are searchig fo wide curses - we are actually searching
56+
# Also, if we are searching for wide curses - we are actually searching
5757
# for ncurses, we don't know about any other unicode version.
5858
set(CURSES_NEED_NCURSES TRUE)
5959
endif()

cmake/modules/sanitize-helpers.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ function (sanitizer_check_compiler_flags FLAG_CANDIDATES NAME PREFIX)
106106

107107
get_property(ENABLED_LANGUAGES GLOBAL PROPERTY ENABLED_LANGUAGES)
108108
foreach (LANG ${ENABLED_LANGUAGES})
109-
# Sanitizer flags are not dependend on language, but the used compiler.
109+
# Sanitizer flags are not dependent on language, but the used compiler.
110110
# So instead of searching flags foreach language, search flags foreach
111111
# compiler used.
112112
set(COMPILER ${CMAKE_${LANG}_COMPILER_ID})

include/ascend/dcmi_interface_api.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ extern "C" {
8282
unsigned long hugepagesize; /* unit:KB */
8383
unsigned long hugepages_total;
8484
unsigned long hugepages_free;
85-
unsigned int utiliza; /* ddr memory info usages */
85+
unsigned int utilize; /* ddr memory info usages */
8686
unsigned char reserve[60]; /* the size of dcmi_memory_info is 96 */
8787
};
8888

@@ -447,7 +447,7 @@ extern "C" {
447447
struct dcmi_memory_info_stru {
448448
unsigned long long memory_size;
449449
unsigned int freq;
450-
unsigned int utiliza;
450+
unsigned int utilize;
451451
};
452452

453453
DCMIDLLEXPORT int dcmi_get_memory_info(int card_id, int device_id, struct dcmi_memory_info_stru *device_memory_info);
@@ -464,4 +464,4 @@ extern "C" {
464464
#endif
465465
#endif /* __cplusplus */
466466

467-
#endif /* __DCMI_INTERFACE_API_H__ */
467+
#endif /* __DCMI_INTERFACE_API_H__ */

include/nvtop/common.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ static void *nvtop_reallocarray__(void *ptr, size_t nmemb, size_t size) {
4242
#endif // !defined(HAS_REALLOCARRAY)
4343

4444
// Increment for the number of tracked processes
45-
// 16 has been experimentally selected for being small while avoiding multipe allocations in most common cases
45+
// 16 has been experimentally selected for being small while avoiding multiple allocations in most common cases
4646
#define COMMON_PROCESS_LINEAR_REALLOC_INC 16
4747

4848
#define MAX_LINES_PER_PLOT 4

include/nvtop/extract_processinfo_fdinfo.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ void processinfo_drop_callback(const struct gpu_info *info);
5757
void processinfo_enable_disable_callback_for(const struct gpu_info *info, bool enable);
5858

5959
/**
60-
* @brief Scann all the processes in /proc. Call the registered callbacks on
61-
* each file descriptor to the DRM driver that can successfully be oppened. If a
60+
* @brief Scan all the processes in /proc. Call the registered callbacks on
61+
* each file descriptor to the DRM driver that can successfully be opened. If a
6262
* callback succeeds, the gpu_info structure processes array will be updated
6363
* with the retrieved data.
6464
*/

include/nvtop/interface_options.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ typedef struct nvtop_interface_option_struct {
5050
bool show_startup_messages; // True to show the startup messages
5151
bool filter_nvtop_pid; // Do not show nvtop pid in the processes list
5252
bool has_monitored_set_changed; // True if the set of monitored gpu was modified through the interface
53-
bool has_gpu_info_bar; // Show info bar with additional GPU parametres
53+
bool has_gpu_info_bar; // Show info bar with additional GPU parameters
5454
bool hide_processes_list; // Hide processes list
5555
} nvtop_interface_option;
5656

src/extract_gpuinfo_amdgpu.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ static bool gpuinfo_amdgpu_get_device_handles(struct list_head *devices, unsigne
451451
last_libdrm_return_status =
452452
_amdgpu_device_initialize(fd, &drm_major, &drm_minor, &gpu_infos[amdgpu_count].amdgpu_device);
453453
} else {
454-
// TODO: radeon suppport here
454+
// TODO: radeon support here
455455
assert(false);
456456
}
457457

@@ -612,20 +612,20 @@ static void gpuinfo_amdgpu_populate_static_info(struct gpu_info *_gpu_info) {
612612
// If multiple fans are present, use the first one. Some hardware do not wire
613613
// the sensor for the second fan, or use the same value as the first fan.
614614

615-
// Critical temparature
615+
// Critical temperature
616616
// temp1_* files should always be the GPU die in millidegrees Celsius
617617
if (gpu_info->hwmonDevice) {
618618
unsigned criticalTemp;
619-
int NreadPatterns = readAttributeFromDevice(gpu_info->hwmonDevice, "temp1_crit", "%u", &criticalTemp);
620-
if (NreadPatterns == 1) {
619+
int nReadPatterns = readAttributeFromDevice(gpu_info->hwmonDevice, "temp1_crit", "%u", &criticalTemp);
620+
if (nReadPatterns == 1) {
621621
SET_GPUINFO_STATIC(static_info, temperature_slowdown_threshold, criticalTemp);
622622
}
623623

624-
// Emergency/shutdown temparature
625-
unsigned emergemcyTemp;
626-
NreadPatterns = readAttributeFromDevice(gpu_info->hwmonDevice, "temp1_emergency", "%u", &emergemcyTemp);
627-
if (NreadPatterns == 1) {
628-
SET_GPUINFO_STATIC(static_info, temperature_shutdown_threshold, emergemcyTemp);
624+
// Emergency/shutdown temperature
625+
unsigned emergencyTemp;
626+
nReadPatterns = readAttributeFromDevice(gpu_info->hwmonDevice, "temp1_emergency", "%u", &emergencyTemp);
627+
if (nReadPatterns == 1) {
628+
SET_GPUINFO_STATIC(static_info, temperature_shutdown_threshold, emergencyTemp);
629629
}
630630
}
631631

src/extract_gpuinfo_intel.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ void gpuinfo_intel_refresh_dynamic_info(struct gpu_info *_gpu_info) {
224224

225225
RESET_ALL(dynamic_info->valid);
226226

227-
// We are creating new devices because the device_get_sysattr_value caches its querries
227+
// We are creating new devices because the device_get_sysattr_value caches its queries
228228
const char *syspath;
229229
nvtop_device *card_dev_noncached = NULL;
230230
if (nvtop_device_get_syspath(gpu_info->card_device, &syspath) >= 0)

src/extract_gpuinfo_metax.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ typedef enum {
9797
static mxSmlReturn_t (*mxSmlGetTemperatureInfo)(unsigned int deviceId, mxSmlTemperatureSensors_t sensorType,
9898
int *temp);
9999

100-
// Dynamic infomation extraction
100+
// Dynamic information extraction
101101
typedef enum {
102102
MXSML_Clock_Dla = 1, //!< Valid for N-class device
103103
MXSML_Clock_Mc = 2, //!< Valid for N-class device
@@ -493,7 +493,7 @@ static void gpuinfo_metax_refresh_dynamic_info(struct gpu_info *_gpu_info) {
493493
SET_GPUINFO_DYNAMIC(dynamic_info, mem_util_rate, memory_info.visVramUse * 100 / memory_info.visVramTotal);
494494
}
495495

496-
// Pcie generation and width used by the device
496+
// PCIe generation and width used by the device
497497
mxSmlPcieInfo_t pcieInfo;
498498
last_mxsml_return_status = mxSmlGetPcieInfo(deviceId, &pcieInfo);
499499
if (last_mxsml_return_status == MXSML_SUCCESS) {
@@ -509,7 +509,7 @@ static void gpuinfo_metax_refresh_dynamic_info(struct gpu_info *_gpu_info) {
509509
}
510510
}
511511

512-
// Pcie eception and transmission throughput
512+
// PCIe reception and transmission throughput
513513
mxSmlPcieThroughput_t pcieThroughput;
514514
last_mxsml_return_status = mxSmlGetPcieThroughput(deviceId, &pcieThroughput);
515515
if (last_mxsml_return_status == MXSML_SUCCESS) {

0 commit comments

Comments
 (0)