Skip to content

fix: precompilation warning #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

fix: precompilation warning #136

merged 1 commit into from
Jun 27, 2025

Conversation

MilesCranmer
Copy link
Member

No description provided.

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (3dcbbe0) to head (eab884e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files          30       30           
  Lines        2593     2593           
=======================================
  Hits         2506     2506           
  Misses         87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master eab884e... master / eab884e...
eval/ComplexF32/evaluation 7.24 ± 0.55 ms 7.24 ± 0.54 ms 1 ± 0.11
eval/ComplexF64/evaluation 10.8 ± 0.77 ms 10.9 ± 0.89 ms 0.991 ± 0.11
eval/Float32/derivative 11.2 ± 0.49 ms 11.4 ± 0.55 ms 0.987 ± 0.064
eval/Float32/derivative_turbo 11.3 ± 0.58 ms 11.4 ± 0.53 ms 0.991 ± 0.068
eval/Float32/evaluation 2.74 ± 0.28 ms 2.73 ± 0.26 ms 1 ± 0.14
eval/Float32/evaluation_bumper 0.61 ± 0.016 ms 0.607 ± 0.016 ms 1.01 ± 0.037
eval/Float32/evaluation_turbo 0.521 ± 0.028 ms 0.513 ± 0.028 ms 1.02 ± 0.079
eval/Float32/evaluation_turbo_bumper 0.612 ± 0.016 ms 0.608 ± 0.016 ms 1.01 ± 0.037
eval/Float64/derivative 14.8 ± 1.3 ms 14.4 ± 0.92 ms 1.03 ± 0.11
eval/Float64/derivative_turbo 14.5 ± 0.99 ms 14.3 ± 0.87 ms 1.01 ± 0.092
eval/Float64/evaluation 3.17 ± 0.35 ms 3.15 ± 0.33 ms 1.01 ± 0.15
eval/Float64/evaluation_bumper 1.26 ± 0.045 ms 1.25 ± 0.043 ms 1 ± 0.05
eval/Float64/evaluation_turbo 0.998 ± 0.064 ms 0.967 ± 0.065 ms 1.03 ± 0.096
eval/Float64/evaluation_turbo_bumper 1.26 ± 0.044 ms 1.25 ± 0.045 ms 1.01 ± 0.05
utils/combine_operators/break_sharing 0.0413 ± 0.0021 ms 0.0407 ± 0.0021 ms 1.01 ± 0.074
utils/convert/break_sharing 29.7 ± 3.8 μs 29.6 ± 4 μs 1 ± 0.19
utils/convert/preserve_sharing 0.102 ± 0.0072 ms 0.101 ± 0.007 ms 1.01 ± 0.099
utils/copy/break_sharing 28.9 ± 3.5 μs 29.3 ± 3.8 μs 0.986 ± 0.18
utils/copy/preserve_sharing 0.102 ± 0.0066 ms 0.101 ± 0.0058 ms 1.01 ± 0.087
utils/count_constant_nodes/break_sharing 13.1 ± 1.6 μs 13.1 ± 1.5 μs 0.998 ± 0.17
utils/count_constant_nodes/preserve_sharing 0.0859 ± 0.005 ms 0.086 ± 0.0043 ms 1 ± 0.077
utils/count_depth/break_sharing 15.7 ± 2.7 μs 13.8 ± 1.8 μs 1.14 ± 0.24
utils/count_nodes/break_sharing 12.5 ± 1.5 μs 13 ± 1.5 μs 0.959 ± 0.16
utils/count_nodes/preserve_sharing 0.0866 ± 0.0049 ms 0.0872 ± 0.0039 ms 0.994 ± 0.072
utils/get_set_constants!/break_sharing 0.0347 ± 0.0023 ms 0.0332 ± 0.0035 ms 1.04 ± 0.13
utils/get_set_constants!/preserve_sharing 0.178 ± 0.0087 ms 0.18 ± 0.0087 ms 0.994 ± 0.068
utils/get_set_constants_parametric 0.0502 ± 0.0058 ms 0.0496 ± 0.0049 ms 1.01 ± 0.15
utils/has_constants/break_sharing 7.71 ± 0.83 μs 7.34 ± 1.1 μs 1.05 ± 0.19
utils/has_operators/break_sharing 2.56 ± 0.18 μs 2.29 ± 0.2 μs 1.12 ± 0.13
utils/hash/break_sharing 24.1 ± 2.3 μs 24.6 ± 2.6 μs 0.981 ± 0.14
utils/hash/preserve_sharing 0.0978 ± 0.0052 ms 0.1 ± 0.005 ms 0.976 ± 0.071
utils/index_constant_nodes/break_sharing 31.4 ± 3.6 μs 30 ± 3.6 μs 1.05 ± 0.17
utils/index_constant_nodes/preserve_sharing 0.102 ± 0.0064 ms 0.102 ± 0.0056 ms 0.998 ± 0.083
utils/is_constant/break_sharing 8.29 ± 0.86 μs 8.27 ± 0.92 μs 1 ± 0.15
utils/simplify_tree/break_sharing 26.9 ± 2.7 μs 25.9 ± 2.6 μs 1.04 ± 0.15
utils/simplify_tree/preserve_sharing 0.107 ± 0.0053 ms 0.107 ± 0.0043 ms 1 ± 0.064
utils/string_tree/break_sharing 0.47 ± 0.025 ms 0.472 ± 0.026 ms 0.997 ± 0.077
utils/string_tree/preserve_sharing 0.569 ± 0.024 ms 0.563 ± 0.023 ms 1.01 ± 0.059
time_to_load 0.229 ± 0.0048 s 0.231 ± 0.0074 s 0.99 ± 0.038
Memory benchmarks
master eab884e... master / eab884e...
eval/ComplexF32/evaluation 0.972 k allocs: 2.49 MB 0.987 k allocs: 2.53 MB 0.985
eval/ComplexF64/evaluation 0.984 k allocs: 5.01 MB 1.01 k allocs: 5.15 MB 0.973
eval/Float32/derivative 4.59 k allocs: 17.3 MB 4.68 k allocs: 17.6 MB 0.982
eval/Float32/derivative_turbo 4.64 k allocs: 17.5 MB 4.64 k allocs: 17.5 MB 1
eval/Float32/evaluation 0.993 k allocs: 1.29 MB 0.978 k allocs: 1.27 MB 1.02
eval/Float32/evaluation_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float32/evaluation_turbo 0.972 k allocs: 1.27 MB 0.966 k allocs: 1.26 MB 1.01
eval/Float32/evaluation_turbo_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float64/derivative 4.8 k allocs: 0.0351 GB 4.8 k allocs: 0.0351 GB 1
eval/Float64/derivative_turbo 4.8 k allocs: 0.0351 GB 4.78 k allocs: 0.0349 GB 1.01
eval/Float64/evaluation 0.993 k allocs: 2.54 MB 0.987 k allocs: 2.53 MB 1.01
eval/Float64/evaluation_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
eval/Float64/evaluation_turbo 0.981 k allocs: 2.51 MB 0.981 k allocs: 2.51 MB 1
eval/Float64/evaluation_turbo_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
utils/combine_operators/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/convert/break_sharing 2 k allocs: 0.123 MB 2 k allocs: 0.123 MB 1
utils/convert/preserve_sharing 2.4 k allocs: 0.192 MB 2.4 k allocs: 0.192 MB 1
utils/copy/break_sharing 2 k allocs: 0.123 MB 2 k allocs: 0.123 MB 1
utils/copy/preserve_sharing 2.4 k allocs: 0.192 MB 2.4 k allocs: 0.192 MB 1
utils/count_constant_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_constant_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/count_depth/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/get_set_constants!/break_sharing 0.898 k allocs: 25.2 kB 0.898 k allocs: 25.2 kB 1
utils/get_set_constants!/preserve_sharing 1.7 k allocs: 0.138 MB 1.7 k allocs: 0.138 MB 1
utils/get_set_constants_parametric 1.42 k allocs: 0.0663 MB 1.42 k allocs: 0.0663 MB 1
utils/has_constants/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/has_operators/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/hash/break_sharing 0.104 k allocs: 2.52 kB 0.104 k allocs: 2.52 kB 1
utils/hash/preserve_sharing 0.504 k allocs: 0.0711 MB 0.504 k allocs: 0.0711 MB 1
utils/index_constant_nodes/break_sharing 2.1 k allocs: 0.094 MB 2.1 k allocs: 0.094 MB 1
utils/index_constant_nodes/preserve_sharing 2.5 k allocs: 0.163 MB 2.5 k allocs: 0.163 MB 1
utils/is_constant/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/simplify_tree/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/simplify_tree/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/string_tree/break_sharing 11.8 k allocs: 1.04 MB 11.8 k allocs: 1.04 MB 1
utils/string_tree/preserve_sharing 12.2 k allocs: 1.11 MB 12.2 k allocs: 1.11 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@MilesCranmer MilesCranmer merged commit e46ee58 into master Jun 27, 2025
13 of 14 checks passed
@MilesCranmer MilesCranmer deleted the fix-precomp-warning branch June 27, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant