chore: fix newly psalm errors (#167)

Sysix · web-flow · commit 699669729ec4 · 2025-06-22T16:21:31.000+02:00
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM php:8.2-fpm
+FROM php:8.4-fpm
 
 ENV XDEBUG_MODE='coverage' \
     XDEBUG_CONFIG='client_host=host.docker.internal output_dir=/var/www/tmp'
diff --git a/psalm.xml b/psalm.xml
@@ -19,6 +19,12 @@
         <PropertyNotSetInConstructor errorLevel="suppress" />
         <DeprecatedMethod errorLevel="suppress" />
         <RedundantPropertyInitializationCheck errorLevel="suppress" />
+        <MissingOverrideAttribute errorLevel="suppress" />
+        <ClassMustBeFinal>
+            <errorLevel type="suppress">
+                <directory name="src" />
+            </errorLevel>
+        </ClassMustBeFinal>
     </issueHandlers>
     <plugins>
         <pluginClass class="Psalm\PhpUnitPlugin\Plugin" />
diff --git a/tests/ApiTest.php b/tests/ApiTest.php
@@ -27,7 +27,7 @@
 use Sysix\LexOffice\Clients\Voucher;
 use Sysix\LexOffice\Clients\VoucherList;
 
-class ApiTest extends TestClient
+final class ApiTest extends TestClient
 {
     public function createApiMockObject(Response $response)
     {
diff --git a/tests/Clients/ArticleTest.php b/tests/Clients/ArticleTest.php
@@ -8,7 +8,7 @@
 use Sysix\LexOffice\Clients\Article;
 use Sysix\LexOffice\Tests\TestClient;
 
-class ArticleTest extends TestClient
+final class ArticleTest extends TestClient
 {
     public function testGetPage(): void
     {
diff --git a/tests/Clients/ContactTest.php b/tests/Clients/ContactTest.php
@@ -8,7 +8,7 @@
 use Sysix\LexOffice\Clients\Contact;
 use Sysix\LexOffice\Tests\TestClient;
 
-class ContactTest extends TestClient
+final class ContactTest extends TestClient
 {
     public function testGetPage(): void
     {
diff --git a/tests/Clients/CountryTest.php b/tests/Clients/CountryTest.php
@@ -8,7 +8,7 @@
 use Sysix\LexOffice\Clients\Country;
 use Sysix\LexOffice\Tests\TestClient;
 
-class CountryTest extends TestClient
+final class CountryTest extends TestClient
 {
     public function testGetAll(): void
     {
diff --git a/tests/Clients/CreditNoteTest.php b/tests/Clients/CreditNoteTest.php
@@ -10,7 +10,7 @@
 use Sysix\LexOffice\Clients\VoucherList;
 use Sysix\LexOffice\Tests\TestClient;
 
-class CreditNoteTest extends TestClient
+final class CreditNoteTest extends TestClient
 {
     public function testGet(): void
     {
diff --git a/tests/Clients/DeliveryNoteTest.php b/tests/Clients/DeliveryNoteTest.php
@@ -10,7 +10,7 @@
 use Sysix\LexOffice\Clients\VoucherList;
 use Sysix\LexOffice\Tests\TestClient;
 
-class DeliveryNoteTest extends TestClient
+final class DeliveryNoteTest extends TestClient
 {
     public function testGet(): void
     {
diff --git a/tests/Clients/DownPaymentInvoiceTest.php b/tests/Clients/DownPaymentInvoiceTest.php
@@ -10,7 +10,7 @@
 use Sysix\LexOffice\Clients\VoucherList;
 use Sysix\LexOffice\Tests\TestClient;
 
-class DownPaymentInvoiceTest extends TestClient
+final class DownPaymentInvoiceTest extends TestClient
 {
     public function testGet(): void
     {
diff --git a/tests/Clients/DunningTest.php b/tests/Clients/DunningTest.php
@@ -9,7 +9,7 @@
 use Sysix\LexOffice\Clients\Dunning;
 use Sysix\LexOffice\Tests\TestClient;
 
-class DunningTest extends TestClient
+final class DunningTest extends TestClient
 {
     public function testGet(): void
     {
diff --git a/tests/Clients/EventTest.php b/tests/Clients/EventTest.php
@@ -8,7 +8,7 @@
 use Sysix\LexOffice\Clients\Event;
 use Sysix\LexOffice\Tests\TestClient;
 
-class EventTest extends TestClient
+final class EventTest extends TestClient
 {
     public function testCreate(): void
     {
diff --git a/tests/Clients/FileTest.php b/tests/Clients/FileTest.php
@@ -11,7 +11,7 @@
 use Sysix\LexOffice\Exceptions\LexOfficeApiException;
 use Sysix\LexOffice\Tests\TestClient;
 
-class FileTest extends TestClient
+final class FileTest extends TestClient
 {
     public function testGet(): void
     {
diff --git a/tests/Clients/InvoiceTest.php b/tests/Clients/InvoiceTest.php
@@ -10,7 +10,7 @@
 use Sysix\LexOffice\Clients\VoucherList;
 use Sysix\LexOffice\Tests\TestClient;
 
-class InvoiceTest extends TestClient
+final class InvoiceTest extends TestClient
 {
     public function testCreate(): void
     {
diff --git a/tests/Clients/OrderConfirmationTest.php b/tests/Clients/OrderConfirmationTest.php
@@ -10,7 +10,7 @@
 use Sysix\LexOffice\Clients\VoucherList;
 use Sysix\LexOffice\Tests\TestClient;
 
-class OrderConfirmationTest extends TestClient
+final class OrderConfirmationTest extends TestClient
 {
     public function testCreate(): void
     {
diff --git a/tests/Clients/PaymentConditionTest.php b/tests/Clients/PaymentConditionTest.php
@@ -8,7 +8,7 @@
 use Sysix\LexOffice\Clients\PaymentCondition;
 use Sysix\LexOffice\Tests\TestClient;
 
-class PaymentConditionTest extends TestClient
+final class PaymentConditionTest extends TestClient
 {
     public function testGetAll(): void
     {
diff --git a/tests/Clients/PaymentTest.php b/tests/Clients/PaymentTest.php
@@ -8,7 +8,7 @@
 use Sysix\LexOffice\Clients\Payment;
 use Sysix\LexOffice\Tests\TestClient;
 
-class PaymentTest extends TestClient
+final class PaymentTest extends TestClient
 {
     public function testGet(): void
     {
diff --git a/tests/Clients/PostingCategoryTest.php b/tests/Clients/PostingCategoryTest.php
@@ -8,7 +8,7 @@
 use Sysix\LexOffice\Clients\PostingCategory;
 use Sysix\LexOffice\Tests\TestClient;
 
-class PostingCategoryTest extends TestClient
+final class PostingCategoryTest extends TestClient
 {
     public function testGetAll(): void
     {
diff --git a/tests/Clients/PrintLayoutTest.php b/tests/Clients/PrintLayoutTest.php
@@ -8,7 +8,7 @@
 use Sysix\LexOffice\Clients\PrintLayout;
 use Sysix\LexOffice\Tests\TestClient;
 
-class PrintLayoutTest extends TestClient
+final class PrintLayoutTest extends TestClient
 {
     public function testGetAll(): void
     {
diff --git a/tests/Clients/ProfileTest.php b/tests/Clients/ProfileTest.php
@@ -8,7 +8,7 @@
 use Sysix\LexOffice\Clients\Profile;
 use Sysix\LexOffice\Tests\TestClient;
 
-class ProfileTest extends TestClient
+final class ProfileTest extends TestClient
 {
     public function testGet(): void
     {
diff --git a/tests/Clients/QuotationTest.php b/tests/Clients/QuotationTest.php
@@ -10,7 +10,7 @@
 use Sysix\LexOffice\Clients\VoucherList;
 use Sysix\LexOffice\Tests\TestClient;
 
-class QuotationTest extends TestClient
+final class QuotationTest extends TestClient
 {
     public function testCreate(): void
     {
diff --git a/tests/Clients/RecurringTemplateTest.php b/tests/Clients/RecurringTemplateTest.php
@@ -8,7 +8,7 @@
 use Sysix\LexOffice\Clients\RecurringTemplate;
 use Sysix\LexOffice\Tests\TestClient;
 
-class RecurringTemplateTest extends TestClient
+final class RecurringTemplateTest extends TestClient
 {
     public function testGet(): void
     {
diff --git a/tests/Clients/VoucherListTest.php b/tests/Clients/VoucherListTest.php
@@ -9,7 +9,7 @@
 use Sysix\LexOffice\Clients\VoucherList;
 use Sysix\LexOffice\Tests\TestClient;
 
-class VoucherListTest extends TestClient
+final class VoucherListTest extends TestClient
 {
     public function testGetPage(): void
     {
diff --git a/tests/Clients/VoucherTest.php b/tests/Clients/VoucherTest.php
@@ -11,7 +11,7 @@
 use Sysix\LexOffice\Exceptions\LexOfficeApiException;
 use Sysix\LexOffice\Tests\TestClient;
 
-class VoucherTest extends TestClient
+final class VoucherTest extends TestClient
 {
     public function testCreate(): void
     {
diff --git a/tests/PaginationClientTest.php b/tests/PaginationClientTest.php
@@ -9,7 +9,7 @@
 use Sysix\LexOffice\Api;
 use Sysix\LexOffice\PaginationClient;
 
-class PaginationClientTest extends TestClient
+final class PaginationClientTest extends TestClient
 {
     /**
      * @param array<int, Response> $responses
diff --git a/tests/UtilsTest.php b/tests/UtilsTest.php
@@ -9,7 +9,7 @@
 use PHPUnit\Framework\TestCase;
 use Sysix\LexOffice\Utils;
 
-class UtilsTest extends TestCase
+final class UtilsTest extends TestCase
 {
     public function testGetJsonFromResponseWithoutAnHeader(): void
     {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM php:8.2-fpm`
	`1`	`+FROM php:8.4-fpm`
`2`	`2`
`3`	`3`	`ENV XDEBUG_MODE='coverage' \`
`4`	`4`	`XDEBUG_CONFIG='client_host=host.docker.internal output_dir=/var/www/tmp'`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`	`use Sysix\LexOffice\Clients\Voucher;`
`28`	`28`	`use Sysix\LexOffice\Clients\VoucherList;`
`29`	`29`
`30`		`-class ApiTest extends TestClient`
	`30`	`+final class ApiTest extends TestClient`
`31`	`31`	`{`
`32`	`32`	`public function createApiMockObject(Response $response)`
`33`	`33`	`{`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`use Sysix\LexOffice\Clients\Article;`
`9`	`9`	`use Sysix\LexOffice\Tests\TestClient;`
`10`	`10`
`11`		`-class ArticleTest extends TestClient`
	`11`	`+final class ArticleTest extends TestClient`
`12`	`12`	`{`
`13`	`13`	`public function testGetPage(): void`
`14`	`14`	`{`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`use Sysix\LexOffice\Clients\Contact;`
`9`	`9`	`use Sysix\LexOffice\Tests\TestClient;`
`10`	`10`
`11`		`-class ContactTest extends TestClient`
	`11`	`+final class ContactTest extends TestClient`
`12`	`12`	`{`
`13`	`13`	`public function testGetPage(): void`
`14`	`14`	`{`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`use Sysix\LexOffice\Clients\Country;`
`9`	`9`	`use Sysix\LexOffice\Tests\TestClient;`
`10`	`10`
`11`		`-class CountryTest extends TestClient`
	`11`	`+final class CountryTest extends TestClient`
`12`	`12`	`{`
`13`	`13`	`public function testGetAll(): void`
`14`	`14`	`{`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`use Sysix\LexOffice\Clients\VoucherList;`
`11`	`11`	`use Sysix\LexOffice\Tests\TestClient;`
`12`	`12`
`13`		`-class CreditNoteTest extends TestClient`
	`13`	`+final class CreditNoteTest extends TestClient`
`14`	`14`	`{`
`15`	`15`	`public function testGet(): void`
`16`	`16`	`{`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`use Sysix\LexOffice\Clients\Dunning;`
`10`	`10`	`use Sysix\LexOffice\Tests\TestClient;`
`11`	`11`
`12`		`-class DunningTest extends TestClient`
	`12`	`+final class DunningTest extends TestClient`
`13`	`13`	`{`
`14`	`14`	`public function testGet(): void`
`15`	`15`	`{`