Mark IRomAsset.RomPath as [Obsolete] and mute existing warnings

Author: YoshiRulz

src/BizHawk.Emulation.Cores/Arcades/MAME/MAME.cs

@@ -22,7 +22,9 @@ public partial class MAME : IRomInfo
 		[CoreConstructor(VSystemID.Raw.Arcade)]
 		public MAME(CoreLoadParameters<object, MAMESyncSettings> lp)
 		{
+#pragma warning disable CS0618
 			_gameFileName = Path.GetFileName(lp.Roms[0].RomPath.SubstringAfter('|')).ToLowerInvariant();
+#pragma warning restore CS0618
 			_syncSettings = lp.SyncSettings ?? new();
 
 			ServiceProvider = new BasicServiceProvider(this);
@@ -174,8 +176,10 @@ static byte[] MakeRomData(IRomAsset rom)
 			// mame expects chd files in a folder of the game name
 			string MakeFileName(IRomAsset rom)
 				=> rom.Extension.ToLowerInvariant() is ".chd"
+#pragma warning disable CS0618
 					? gameName + '/' + Path.GetFileNameWithoutExtension(rom.RomPath.SubstringAfter('|')).ToLowerInvariant() + rom.Extension.ToLowerInvariant()
 					: Path.GetFileNameWithoutExtension(rom.RomPath.SubstringAfter('|')).ToLowerInvariant() + rom.Extension.ToLowerInvariant();
+#pragma warning restore CS0618
 
 			foreach (var rom in roms)
 			{

src/BizHawk.Emulation.Cores/Computers/Amiga/UAE.cs

@@ -55,7 +55,11 @@ public partial class UAE : WaterboxCore
 		private bool _nextDrivePressed;
 		private int _correctedWidth;
 		private string _chipsetCompatible = "";
-		private string GetFullName(IRomAsset rom) => Path.GetFileName(rom.RomPath.SubstringAfter('|'));
+
+		private string GetFullName(IRomAsset rom)
+#pragma warning disable CS0618
+			=> Path.GetFileName(rom.RomPath.SubstringAfter('|'));
+#pragma warning restore CS0618
 
 		public override int VirtualWidth => _correctedWidth;
 

src/BizHawk.Emulation.Cores/Computers/DOS/DOSBox.cs

@@ -50,7 +50,11 @@ public sealed partial class DOSBox : WaterboxCore
 		private int _currentCDROM = 0;
 		private bool _disposed;
 
-		private string GetFullName(IRomAsset rom) => Path.GetFileName(rom.RomPath.SubstringAfter('|'));
+		private string GetFullName(IRomAsset rom)
+#pragma warning disable CS0618
+			=> Path.GetFileName(rom.RomPath.SubstringAfter('|'));
+#pragma warning restore CS0618
+
 		private string GetFullName(IDiscAsset disk) => Path.GetFileName(disk.DiscData.Name.SubstringAfter('|'));
 
 		// CD Handling logic
@@ -81,7 +85,10 @@ public DOSBox(CoreLoadParameters<object, SyncSettings> lp)
 			// Parsing rom files
 			foreach (var file in _romAssets)
 			{
-				switch (Path.GetExtension(file.RomPath))
+#pragma warning disable CS0618
+				var filePath = file.RomPath;
+#pragma warning restore CS0618
+				switch (Path.GetExtension(filePath))
 				{
 					case ".ima" or ".img" or ".xdf" or ".dmf" or ".fdd" or ".fdi" or ".nfd" or ".d88":
 						_floppyDiskImageFiles.Add(file);
@@ -96,7 +103,7 @@ public DOSBox(CoreLoadParameters<object, SyncSettings> lp)
 						break;
 
 					default:
-						throw new Exception($"Unrecognized input file provided: '{file.RomPath}'");
+						throw new Exception($"Provided file was not recognised: \"{filePath}\"");
 				}
 			}
 
@@ -209,7 +216,9 @@ public DOSBox(CoreLoadParameters<object, SyncSettings> lp)
 			string floppyMountLine = "imgmount a ";
 			foreach (var file in _floppyDiskImageFiles)
 			{
+#pragma warning disable CS0618
 				string floppyNewName = $"{FileNames.FD}{_floppyDiskCount}{Path.GetExtension(file.RomPath)}";
+#pragma warning restore CS0618
 				_exe.AddReadonlyFile(file.FileData, floppyNewName);
 				floppyMountLine += floppyNewName + " ";
 				_floppyDiskCount++;

src/BizHawk.Emulation.Cores/Computers/Doom/DSDA.cs

@@ -42,18 +42,20 @@ public DSDA(CoreLoadParameters<DoomSettings, DoomSyncSettings> lp)
 			foreach (var wadFile in _wadFiles)
 			{
 				bool recognized = false;
-
+#pragma warning disable CS0618
+				var filePath = wadFile.RomPath;
+#pragma warning restore CS0618
 				if (wadFile.RomData is [ (byte) 'I', (byte) 'W', (byte) 'A', (byte) 'D', .. ])
 				{
 					// Check not more than one IWAD is provided
 					if (foundIWAD)
 					{
 						throw new ArgumentException(
-							$"More than one IWAD provided. Trying to load '{wadFile.RomPath}', but IWAD '{_iwadName}' was already provided",
+							$"More than one IWAD provided. Trying to load '{filePath}', but IWAD '{_iwadName}' was already provided",
 							paramName: nameof(lp));
 					}
 
-					_iwadName = wadFile.RomPath;
+					_iwadName = filePath;
 					_iwadData = wadFile.RomData;
 					foundIWAD = true;
 					recognized = true;
@@ -62,7 +64,7 @@ public DSDA(CoreLoadParameters<DoomSettings, DoomSyncSettings> lp)
 				{
 					if (_fakePwads.Contains(GetFullName(wadFile).ToLowerInvariant()))
 					{
-						_iwadName = wadFile.RomPath;
+						_iwadName = filePath;
 						_iwadData = wadFile.RomData;
 						foundIWAD = true;
 					}
@@ -77,7 +79,7 @@ public DSDA(CoreLoadParameters<DoomSettings, DoomSyncSettings> lp)
 				if (!recognized)
 				{
 					throw new ArgumentException(
-						$"Unrecognized WAD provided: '{wadFile.RomPath}' has non-standard header.",
+						$"Unrecognized WAD provided: '{filePath}' has non-standard header.",
 						paramName: nameof(lp));
 				}
 			}
@@ -206,11 +208,14 @@ public DSDA(CoreLoadParameters<DoomSettings, DoomSyncSettings> lp)
 					// Adding PWAD file(s)
 					foreach (var wadFile in _pwadFiles)
 					{
-						_gameMode = _core.dsda_add_wad_file(wadFile.RomPath, wadFile.RomData.Length, _loadCallback);
+#pragma warning disable CS0618
+						var filePath = wadFile.RomPath;
+#pragma warning restore CS0618
+						_gameMode = _core.dsda_add_wad_file(filePath, wadFile.RomData.Length, _loadCallback);
 						if (_gameMode is LibDSDA.GameMode.Fail)
 						{
 							throw new ArgumentException(
-								$"Could not load PWAD file: '{wadFile.RomPath}'",
+								$"Could not load PWAD file: '{filePath}'",
 								paramName: nameof(lp));
 						}
 					}
@@ -332,7 +337,10 @@ private void ConditionalArg(bool condition, string setting)
 			}
 		}
 
-		private string GetFullName(IRomAsset rom) => Path.GetFileName(rom.RomPath.SubstringAfter('|'));
+		private string GetFullName(IRomAsset rom)
+#pragma warning disable CS0618
+			=> Path.GetFileName(rom.RomPath.SubstringAfter('|'));
+#pragma warning restore CS0618
 
 		private static bool PlayerPresent(DoomSyncSettings syncSettings, int port) =>
 			port switch
@@ -435,7 +443,9 @@ private int LoadCallback(string filename, IntPtr buffer, int maxsize)
 
 			foreach (var wadFile in _wadFiles)
 			{
+#pragma warning disable CS0618
 				if (filename == wadFile.RomPath)
+#pragma warning restore CS0618
 				{
 					if (wadFile.FileData == null)
 					{

src/BizHawk.Emulation.Cores/Consoles/Nintendo/3DS/Encore.cs

@@ -60,7 +60,9 @@ private static void ResetEncoreResolver()
 		[CoreConstructor(VSystemID.Raw.N3DS)]
 		public Encore(CoreLoadParameters<EncoreSettings, EncoreSyncSettings> lp)
 		{
+#pragma warning disable CS0618
 			if (lp.Roms.Exists(static r => HawkFile.PathContainsPipe(r.RomPath)))
+#pragma warning restore CS0618
 			{
 				throw new InvalidOperationException("3DS does not support compressed ROMs");
 			}
@@ -134,7 +136,9 @@ public Encore(CoreLoadParameters<EncoreSettings, EncoreSyncSettings> lp)
 
 			_serviceProvider.Register<IVideoProvider>(_encoreVideoProvider);
 
+#pragma warning disable CS0618
 			var romPath = lp.Roms[0].RomPath;
+#pragma warning restore CS0618
 			if (".cia".EqualsIgnoreCase(lp.Roms[0].Extension))
 			{
 				var message = new byte[1024];
@@ -177,7 +181,9 @@ public Encore(CoreLoadParameters<EncoreSettings, EncoreSyncSettings> lp)
 					throw new ArgumentException(paramName: nameof(lp), message: "ROMs after the first ROM should be CIAs");
 				}
 
+#pragma warning disable CS0618
 				_core.Encore_InstallCIA(_context, lp.Roms[i].RomPath, dummyBuffer, dummyBuffer.Length);
+#pragma warning restore CS0618
 			}
 
 			var errorMessage = new byte[1024];

src/BizHawk.Emulation.Cores/Consoles/Nintendo/BSNES/BsnesCore.cs

@@ -25,7 +25,9 @@ public BsnesCore(CoreLoadParameters<SnesSettings, SnesSyncSettings> loadParamete
 			var ser = new BasicServiceProvider(this);
 			ServiceProvider = ser;
 
+#pragma warning disable CS0618
 			this._romPath = Path.ChangeExtension(loadParameters.Roms[0].RomPath.SubstringBefore('|'), null);
+#pragma warning restore CS0618
 			CoreComm = loadParameters.Comm;
 			_syncSettings = loadParameters.SyncSettings ?? new SnesSyncSettings();
 			SystemId = loadParameters.Game.System;

src/BizHawk.Emulation.Cores/Consoles/Nintendo/SNES9X/Snes9x.cs

@@ -30,7 +30,9 @@ public Snes9x(CoreLoadParameters<Settings, SyncSettings> loadParameters)
 				SystemId = VSystemID.Raw.SNES,
 			})
 		{
+#pragma warning disable CS0618
 			this._romPath = Path.ChangeExtension(loadParameters.Roms[0].RomPath.SubstringBefore('|'), null);
+#pragma warning restore CS0618
 			this._currentMsuTrack = new ProxiedFile();
 
 			LibSnes9x.OpenAudio openAudioCb = MsuOpenAudio;

src/BizHawk.Emulation.Cores/CoreLoadParameters.cs

@@ -12,6 +12,7 @@ public interface IRomAsset
 
 		string Extension { get; }
 
+		[Obsolete("you should never have to use this property, Game.Name and Extension should be sufficient")] // not deprecated, do not remove
 		string RomPath { get; }
 
 		/// <summary>

src/BizHawk.Emulation.Cores/Waterbox/NymaCore.cs

@@ -57,7 +57,9 @@ protected T DoInit<T>(
 		{
 			return DoInit<T>(
 				lp.Roms.Select(r => (r.RomData,
+#pragma warning disable CS0618
 					Path.GetFileName(r.RomPath.SubstringAfter('|')).ToLowerInvariant())).ToArray(),
+#pragma warning restore CS0618
 				lp.Discs.Select(d => d.DiscData).ToArray(),
 				wbxFilename,
 				lp.Roms.FirstOrDefault()?.Extension,