Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Editing things from a closed library #767

Open
3 tasks done
SkeleyM opened this issue Feb 1, 2025 · 3 comments · May be fixed by #769
Open
3 tasks done

[Bug]: Editing things from a closed library #767

SkeleyM opened this issue Feb 1, 2025 · 3 comments · May be fixed by #769
Labels
Priority: Medium An issue that shouldn't be be saved for last TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended

Comments

@SkeleyM
Copy link
Contributor

SkeleyM commented Feb 1, 2025

Checklist

  • I have read the documentation.
  • I am using an up-to-date version.
  • I have searched existing issues.

TagStudio Version

Alpha 9.5.0 (Pre-Release 1)

Operating System & Version

Windows 10 22H2

Description

Closing a library doesn't 'fully' close it
you can still edit tags, create new ones, etc from the previously opened library

Expected Behavior

You shouldnt be able to modify the previous library if you close a library

Steps to Reproduce

  1. Open a library
  2. close it: file -> close library
  3. open manage tags

Logs

No response

@SkeleyM SkeleyM added the Type: Bug Something isn't working as intended label Feb 1, 2025
@SkeleyM
Copy link
Contributor Author

SkeleyM commented Feb 1, 2025

the issue seems to be that the engine is not properly cleaned up on closing a library
theres two approaches that I can see and one is
setting engine to None, which causes a whole bunch of errors (all recoverable)
or
explicitly deleting the engine which causes it to be in the same state as when the program starts.
I think the latter is preferable since then there is consistency.
I can submit a pull request for either. I already have tried both so it would be quick for me to do (both one line changes) I'd just like some input on which would be preferable or if theres any other solutions to this that I cant see

@CyanVoxel CyanVoxel added TagStudio: Library Relating to the TagStudio library system Priority: High An important issue requiring attention labels Feb 2, 2025
@CyanVoxel CyanVoxel moved this to 🛠 Ready for Development in TagStudio Development Feb 2, 2025
@CyanVoxel
Copy link
Member

While I'm not able to foresee any potential issues off the top of my head, it seems like your second proposed solution is the better choice 👍

@SkeleyM SkeleyM linked a pull request Feb 2, 2025 that will close this issue
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Feb 2, 2025
@CyanVoxel CyanVoxel added Priority: Low Doesn't require immediate attention and removed Priority: High An important issue requiring attention labels Feb 5, 2025
@CyanVoxel CyanVoxel removed this from the SQL Parity milestone Feb 5, 2025
@CyanVoxel CyanVoxel added Priority: Medium An issue that shouldn't be be saved for last and removed Priority: Low Doesn't require immediate attention labels Feb 5, 2025
@CyanVoxel
Copy link
Member

Lowering the priority of this and #769 now that #787 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended
Projects
Status: 🛠 Ready for Development
Development

Successfully merging a pull request may close this issue.

2 participants