[Bug]: "Open library on start" toggle doesn't acculy make it open library on start

[Thecreatre]

Checklist

• I am using an up-to-date version.
• I have read the documentation.
• I have searched existing issues.

TagStudio Version

9.5.0 prerelease 2

Operating System & Version

Win11

Description

currently the new "open library on start" toggle doenst open whatever library you turned the toggle on for it to auto open when you reopen tag studio (assuming thats how your intended to use it anyway)

Expected Behavior

toggling it on, on any library should make it auto open that library on next boot of tagstudio

Steps to Reproduce

it is on by default in the current version so i suppose just open any library and then close the studio and then reopen it and it doesn't open library again like its supposed to

Logs

No response

[Tishj]

I don't believe this was ever fixed #725 (comment)

[Thecreatre]

weirdly tho it does seem to be setting the flag in where ever it stores the flag, except.. the only thing that's detecting the flag is the older version of tag studio, which is funny

[SkeleyM]

i cant seem to recreate this, the steps im interpreting are:

1. have Open Library On Start toggled
2. open a library
3. close and reopen tag studio

however following those steps results in the previous library being open on startup

[Thecreatre]

huh, maybe the important part for this bug that i converted the library over from json

[CyanVoxel]

I was able to reproduce this when starting from an old preferences file, but as soon as I toggled the setting on and off it just worked from there. For whatever the start_load_last key wasn't pre-existing in my preference files.

[ToxicMushroom]

Can confirm, it didn't work until I toggled it ^^

[Tishj]

I think this can be closed, perhaps this needs a change in the migration code though?

[CyanVoxel]

I wouldn't mind closing the issue - also this setting isn't affected by the sql migration so any effects have been separate from the changes to other parts of the codebase