Skip to content

remove unstable_batchedUpdates #4685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TkDodo opened this issue Dec 23, 2022 · 0 comments · Fixed by #4699
Closed

remove unstable_batchedUpdates #4685

TkDodo opened this issue Dec 23, 2022 · 0 comments · Fixed by #4699
Labels
Milestone

Comments

@TkDodo
Copy link
Collaborator

TkDodo commented Dec 23, 2022

context

we currently use unstable_batchedUpdates as our batchNotifyFn in React and React Native:

notifyManager.setBatchNotifyFunction(unstable_batchedUpdates)

Apparently, this function is a "noop" in React18, as discussed here:

facebook/react#24831 (comment)

proposal

  • remove the default side-effect that sets batchedUpdates
  • keep the option to set a batchUpdatesFn via the notifyManager
  • this would also mean we would be completely side-effect free:

"sideEffects": [
"./src/setBatchUpdatesFn.ts"
],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant