Skip to content

Commit c3c09bd

Browse files
authored
Merge pull request #22 from Team-CrowdZero/feature/#21-total-refactor
[Feature/#21] : 코드 리팩토링
2 parents 58702c4 + ad7c1e7 commit c3c09bd

47 files changed

Lines changed: 128 additions & 883 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

app/src/main/AndroidManifest.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,4 @@
2929
</intent-filter>
3030
</activity>
3131
</application>
32-
3332
</manifest>

app/src/main/java/com/gdg/crowdzero_android/di/DataSourceModule.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
package com.gdg.crowdzero_android.di
22

33
import com.gdg.data.datasource.CrowdZeroDataSource
4-
import com.gdg.data.datasource.ExampleDataSource
54
import com.gdg.data.datasourceimpl.CrowdZeroDataSourceImpl
6-
import com.gdg.data.datasourceimpl.ExampleDataSourceImpl
75
import dagger.Binds
86
import dagger.Module
97
import dagger.hilt.InstallIn
@@ -14,10 +12,6 @@ import javax.inject.Singleton
1412
@InstallIn(SingletonComponent::class)
1513
abstract class DataSourceModule {
1614

17-
@Binds
18-
@Singleton
19-
abstract fun bindExampleDataSource(exampleDataSourceImpl: ExampleDataSourceImpl): ExampleDataSource
20-
2115
@Binds
2216
@Singleton
2317
abstract fun bindCrowdZeroDataSource(crowdZeroDataSourceImpl: CrowdZeroDataSourceImpl): CrowdZeroDataSource

app/src/main/java/com/gdg/crowdzero_android/di/Qualifier.kt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,3 @@ import javax.inject.Qualifier
55
@Qualifier
66
@Retention(AnnotationRetention.BINARY)
77
annotation class CrowdZeroRetrofit
8-
9-
@Qualifier
10-
@Retention(AnnotationRetention.BINARY)
11-
annotation class AccessToken

app/src/main/java/com/gdg/crowdzero_android/di/RepositoryModule.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
package com.gdg.crowdzero_android.di
22

33
import com.gdg.data.repositoryimpl.CrowdZeroRepositoryImpl
4-
import com.gdg.data.repositoryimpl.ExampleRepositoryImpl
54
import com.gdg.domain.repository.CrowdZeroRepository
6-
import com.gdg.domain.repository.ExampleRepository
75
import dagger.Binds
86
import dagger.Module
97
import dagger.hilt.InstallIn
@@ -14,10 +12,6 @@ import javax.inject.Singleton
1412
@InstallIn(SingletonComponent::class)
1513
abstract class RepositoryModule {
1614

17-
@Binds
18-
@Singleton
19-
abstract fun bindExampleRepository(exampleRepositoryImpl: ExampleRepositoryImpl): ExampleRepository
20-
2115
@Binds
2216
@Singleton
2317
abstract fun bindCrowdZeroRepository(crowdZeroRepositoryImpl: CrowdZeroRepositoryImpl): CrowdZeroRepository

app/src/main/java/com/gdg/crowdzero_android/di/ServiceModule.kt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.gdg.crowdzero_android.di
22

33
import com.gdg.data.service.CrowdZeroService
4-
import com.gdg.data.service.ExampleService
54
import dagger.Module
65
import dagger.Provides
76
import dagger.hilt.InstallIn
@@ -13,12 +12,6 @@ import javax.inject.Singleton
1312
@InstallIn(SingletonComponent::class)
1413
object ServiceModule {
1514

16-
@Provides
17-
@Singleton
18-
fun provideExampleService(
19-
@CrowdZeroRetrofit retrofit: Retrofit
20-
): ExampleService = retrofit.create(ExampleService::class.java)
21-
2215
@Provides
2316
@Singleton
2417
fun provideCrowdZeroService(

app/src/main/java/com/gdg/crowdzero_android/main/MainScreen.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,7 @@ fun MainScreen(
152152
startDestination = navigator.startDestination
153153
) {
154154
mapNavGraph(navHostController = navigator.navController)
155-
calendarNavGraph(
156-
paddingValues = paddingValues, navHostController = navigator.navController
157-
)
155+
calendarNavGraph(paddingValues = paddingValues)
158156
detailNavGraph(paddingValues = paddingValues)
159157
}
160158
}

app/src/main/java/com/gdg/crowdzero_android/navigation/CalendarNavigation.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ fun NavController.navigateCalendar(navOptions: NavOptions? = null) {
1717
}
1818

1919
fun NavGraphBuilder.calendarNavGraph(
20-
paddingValues: PaddingValues,
21-
navHostController: NavController
20+
paddingValues: PaddingValues
2221
) {
2322
composable<Calendar> {
2423
CalendarRoute(

app/src/main/java/com/gdg/crowdzero_android/navigation/DetailNavigation.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import com.gdg.feature.detail.DetailRoute
1111
import kotlinx.serialization.Serializable
1212

1313
fun NavController.navigateDetail(
14-
id: Long,
14+
id: Int,
1515
navOptions: NavOptions? = null
1616
) {
1717
navigate(
@@ -34,5 +34,5 @@ fun NavGraphBuilder.detailNavGraph(
3434

3535
@Serializable
3636
data class Detail(
37-
val id: Long
37+
val id: Int
3838
) : Route
-165 KB
Binary file not shown.
-162 KB
Binary file not shown.

0 commit comments

Comments
 (0)