[SoundCloud] Fix failing tests in SoundcloudChannelTabExtractorTest

Use @nested and TestInstance.Lifecycle.PER_CLASS to remove warnings

Author: absurdlylongusername

extractor/src/test/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudChannelTabExtractorTest.java

@@ -1,35 +1,33 @@
 package org.schabi.newpipe.extractor.services.soundcloud;
 
 import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestInstance;
 import org.schabi.newpipe.downloader.DownloaderTestImpl;
 import org.schabi.newpipe.extractor.InfoItem;
 import org.schabi.newpipe.extractor.NewPipe;
 import org.schabi.newpipe.extractor.StreamingService;
 import org.schabi.newpipe.extractor.channel.tabs.ChannelTabExtractor;
 import org.schabi.newpipe.extractor.channel.tabs.ChannelTabs;
 import org.schabi.newpipe.extractor.exceptions.ExtractionException;
-import org.schabi.newpipe.extractor.exceptions.ParsingException;
-import org.schabi.newpipe.extractor.services.BaseListExtractorTest;
 import org.schabi.newpipe.extractor.services.DefaultListExtractorTest;
 import org.schabi.newpipe.extractor.services.soundcloud.extractors.SoundcloudChannelTabExtractor;
 
 import java.io.IOException;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.schabi.newpipe.extractor.ServiceList.PeerTube;
 import static org.schabi.newpipe.extractor.ServiceList.SoundCloud;
 import static org.schabi.newpipe.extractor.services.DefaultTests.defaultTestGetPageInNewExtractor;
-import static org.schabi.newpipe.extractor.services.DefaultTests.defaultTestMoreItems;
-import static org.schabi.newpipe.extractor.services.DefaultTests.defaultTestRelatedItems;
 
 class SoundcloudChannelTabExtractorTest {
 
-    static class Tracks extends DefaultListExtractorTest<ChannelTabExtractor> {
-        private static SoundcloudChannelTabExtractor extractor;
+    @Nested
+    @TestInstance(TestInstance.Lifecycle.PER_CLASS)
+    class Tracks extends DefaultListExtractorTest<ChannelTabExtractor> {
+        private SoundcloudChannelTabExtractor extractor;
 
         @BeforeAll
-        static void setUp() throws IOException, ExtractionException {
+        void setUp() throws IOException, ExtractionException {
             NewPipe.init(DownloaderTestImpl.getInstance());
             extractor = (SoundcloudChannelTabExtractor) SoundCloud
                     .getChannelTabExtractorFromId("10494998", ChannelTabs.TRACKS);
@@ -43,7 +41,6 @@ static void setUp() throws IOException, ExtractionException {
         @Override public String expectedUrlContains() throws Exception { return "https://soundcloud.com/liluzivert/tracks"; }
         @Override public String expectedOriginalUrlContains() throws Exception { return "https://soundcloud.com/liluzivert/tracks"; }
         @Override public InfoItem.InfoType expectedInfoItemType() { return InfoItem.InfoType.STREAM; }
-        @Override public boolean expectedHasMoreItems() { return true; }
 
         @Test
         void testGetPageInNewExtractor() throws Exception {
@@ -53,11 +50,13 @@ void testGetPageInNewExtractor() throws Exception {
         }
     }
 
-    static class Playlists extends DefaultListExtractorTest<ChannelTabExtractor> {
-        private static SoundcloudChannelTabExtractor extractor;
+    @Nested
+    @TestInstance(TestInstance.Lifecycle.PER_CLASS)
+    class Playlists extends DefaultListExtractorTest<ChannelTabExtractor> {
+        private SoundcloudChannelTabExtractor extractor;
 
         @BeforeAll
-        static void setUp() throws IOException, ExtractionException {
+        void setUp() throws IOException, ExtractionException {
             NewPipe.init(DownloaderTestImpl.getInstance());
             extractor = (SoundcloudChannelTabExtractor) SoundCloud
                     .getChannelTabExtractorFromId("323371733", ChannelTabs.PLAYLISTS);
@@ -68,17 +67,18 @@ static void setUp() throws IOException, ExtractionException {
         @Override public StreamingService expectedService() throws Exception { return SoundCloud; }
         @Override public String expectedName() throws Exception { return ChannelTabs.PLAYLISTS; }
         @Override public String expectedId() throws Exception { return "323371733"; }
-        @Override public String expectedUrlContains() throws Exception { return "https://soundcloud.com/trackaholic/sets"; }
-        @Override public String expectedOriginalUrlContains() throws Exception { return "https://soundcloud.com/trackaholic/sets"; }
+        @Override public String expectedUrlContains() throws Exception { return "https://soundcloud.com/prodbypheelix/sets"; }
+        @Override public String expectedOriginalUrlContains() throws Exception { return "https://soundcloud.com/prodbypheelix/sets"; }
         @Override public InfoItem.InfoType expectedInfoItemType() { return InfoItem.InfoType.PLAYLIST; }
-        @Override public boolean expectedHasMoreItems() { return true; }
     }
 
-    static class Albums extends DefaultListExtractorTest<ChannelTabExtractor> {
-        private static SoundcloudChannelTabExtractor extractor;
+    @Nested
+    @TestInstance(TestInstance.Lifecycle.PER_CLASS)
+    class Albums extends DefaultListExtractorTest<ChannelTabExtractor> {
+        private SoundcloudChannelTabExtractor extractor;
 
         @BeforeAll
-        static void setUp() throws IOException, ExtractionException {
+        void setUp() throws IOException, ExtractionException {
             NewPipe.init(DownloaderTestImpl.getInstance());
             extractor = (SoundcloudChannelTabExtractor) SoundCloud
                     .getChannelTabExtractorFromId("4803918", ChannelTabs.ALBUMS);
@@ -92,6 +92,5 @@ static void setUp() throws IOException, ExtractionException {
         @Override public String expectedUrlContains() throws Exception { return "https://soundcloud.com/bigsean-1/albums"; }
         @Override public String expectedOriginalUrlContains() throws Exception { return "https://soundcloud.com/bigsean-1/albums"; }
         @Override public InfoItem.InfoType expectedInfoItemType() { return InfoItem.InfoType.PLAYLIST; }
-        @Override public boolean expectedHasMoreItems() { return true; }
     }
 }