Skip to content

Commit 90a01ce

Browse files
committed
[CI] Set environment var to throw exception when compiling unsafe gencode
This sets an environment variable to let the build fail when compiling with potentially unsafe protobuf code. Generated code prior to protobuf version 3.22 might throw an error now. This is necesarry because the unsafe code was blocked by newer protobuf versions, but is now allowed back to compile with protobuf version 4.33.0. Ref: https://github.com/protocolbuffers/protobuf/releases/tag/v33.0
1 parent 4926499 commit 90a01ce

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ jobs:
5959
./gradlew check \
6060
-Dorg.gradle.welcome=never \
6161
--stacktrace \
62-
-Ddownloader=$downloader_type
62+
-Ddownloader=$downloader_type \
63+
-Dcom.google.protobuf.error_on_unsafe_pre22_gencode
6364
6465
- name: Upload test reports when failure occurs
6566
uses: actions/upload-artifact@v5

0 commit comments

Comments
 (0)