-
Notifications
You must be signed in to change notification settings - Fork 2k
Update .NET version to 10.0 for CSharp/aspnetcore #10241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The following frameworks were updated, pinging maintainers: |
DamianEdwards
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. This shouldn't be merged until release day (11/11) when the container images become available.
|
@sebastienros those 404 for me. What was your point? |
|
The tag:10 images are available, and I copy pasted the urls ... they use some weird routing framework and the url they generate is not accessible directly ;) |
|
@sebastienros I see, so they point at the rc.2 version right now? |
|
I don't really see why the UPDATES test would be suddenly failing due to these changes, unless there's a built-in ORM that got updated with 10.0. |
|
@msmith-techempower I actually ran a fake change in master and the same issues are showing up. We will investigate, the two reasons I can think of is that the verification logic changed, or something happened in a service change of DotNet that the docker tag would have pulled automatically. I checked our implementation, which is not using an advanced orm (no caching or optimizations) and it looks correct. So a mystery so far. |
No description provided.