Move to AnalysisLevel and update standard editorconfigs

Author: jnm2

.editorconfig

@@ -9,7 +9,7 @@ trim_trailing_whitespace = true
 indent_style = space
 indent_size = 4
 
-[*.{sln,*proj}]
+[*.{sln,*proj,dotsettings}]
 charset = utf-8-bom
 
 [*.md]
@@ -27,6 +27,9 @@ dotnet_style_explicit_tuple_names = true:error
 dotnet_style_predefined_type_for_locals_parameters_members = true:error
 dotnet_style_predefined_type_for_member_access = true:error
 dotnet_style_readonly_field = true:error
+csharp_style_var_elsewhere = true:silent
+csharp_style_var_for_built_in_types = true:silent
+csharp_style_var_when_type_is_apparent = true:silent
 
 # Override ReSharper defaults
 csharp_space_after_cast = false
@@ -48,32 +51,115 @@ dotnet_naming_rule.interfaces.style = interfaces
 dotnet_naming_style.pascal_case.capitalization = pascal_case
 
 dotnet_naming_symbols.namespaces_types_and_non_field_members.applicable_kinds = namespace, class, struct, enum, interface, delegate, type_parameter, method, property, event
-dotnet_naming_rule.namespaces_types_and_non_field_members.severity = error
+dotnet_naming_rule.namespaces_types_and_non_field_members.severity = warning
 dotnet_naming_rule.namespaces_types_and_non_field_members.symbols = namespaces_types_and_non_field_members
 dotnet_naming_rule.namespaces_types_and_non_field_members.style = pascal_case
 
 dotnet_naming_symbols.non_private_fields.applicable_kinds = field
 dotnet_naming_symbols.non_private_fields.applicable_accessibilities = public, protected, protected_internal, internal
-dotnet_naming_rule.non_private_fields.severity = error
+dotnet_naming_rule.non_private_fields.severity = warning
 dotnet_naming_rule.non_private_fields.symbols = non_private_fields
 dotnet_naming_rule.non_private_fields.style = pascal_case
 
 dotnet_naming_symbols.static_readonly_fields.applicable_kinds = field
 dotnet_naming_symbols.static_readonly_fields.required_modifiers = static, readonly
-dotnet_naming_rule.static_readonly_fields.severity = error
+dotnet_naming_rule.static_readonly_fields.severity = warning
 dotnet_naming_rule.static_readonly_fields.symbols = static_readonly_fields
 dotnet_naming_rule.static_readonly_fields.style = pascal_case
 
 dotnet_naming_symbols.constant_fields.applicable_kinds = field
 dotnet_naming_symbols.constant_fields.required_modifiers = const
-dotnet_naming_rule.constant_fields.severity = error
+dotnet_naming_rule.constant_fields.severity = warning
 dotnet_naming_rule.constant_fields.symbols = constant_fields
 dotnet_naming_rule.constant_fields.style = pascal_case
 
 
 dotnet_naming_style.camel_case.capitalization = camel_case
 
 dotnet_naming_symbols.other_fields_parameters_and_locals.applicable_kinds = field, parameter, local
-dotnet_naming_rule.other_fields_parameters_and_locals.severity = error
+dotnet_naming_rule.other_fields_parameters_and_locals.severity = warning
 dotnet_naming_rule.other_fields_parameters_and_locals.symbols = other_fields_parameters_and_locals
 dotnet_naming_rule.other_fields_parameters_and_locals.style = camel_case
+
+
+# .NET diagnostic configuration
+
+# CS8509: The switch expression does not handle all possible inputs (it is not exhaustive).
+dotnet_diagnostic.CS8509.severity = silent
+# CS8524: The switch expression does not handle some values of its input type (it is not exhaustive) involving an unnamed enum value.
+dotnet_diagnostic.CS8524.severity = silent
+
+# IDE0005: Using directive is unnecessary.
+dotnet_diagnostic.IDE0005.severity = warning
+
+# CA1304: Specify CultureInfo
+dotnet_diagnostic.CA1304.severity = warning
+
+# CA1305: Specify IFormatProvider
+dotnet_diagnostic.CA1305.severity = warning
+
+# CA1310: Specify StringComparison for correctness
+dotnet_diagnostic.CA1310.severity = warning
+
+# CA1825: Avoid zero-length array allocations
+dotnet_diagnostic.CA1825.severity = warning
+
+# CA2016: Forward the 'CancellationToken' parameter to methods that take one
+dotnet_diagnostic.CA2016.severity = warning
+
+# CA2208: Instantiate argument exceptions correctly
+dotnet_diagnostic.CA2208.severity = warning
+
+# CA2211: Non-constant fields should not be visible
+dotnet_diagnostic.CA2211.severity = warning
+
+# CA2219: Do not raise exceptions in finally clauses
+dotnet_diagnostic.CA2219.severity = warning
+
+# CA2231: Overload operator equals on overriding value type Equals
+dotnet_diagnostic.CA2231.severity = warning
+
+# CA1806: Do not ignore method results
+dotnet_diagnostic.CA1806.severity = silent
+
+# CA1816: Dispose methods should call SuppressFinalize
+dotnet_diagnostic.CA1816.severity = none
+
+# CA1822: Mark members as static
+dotnet_diagnostic.CA1822.severity = silent
+
+# CA1826: Do not use Enumerable methods on indexable collections
+dotnet_diagnostic.CA1826.severity = silent
+
+# CA1834: Consider using 'StringBuilder.Append(char)' when applicable
+dotnet_diagnostic.CA1834.severity = silent
+
+# CA1806: Do not ignore method results
+dotnet_diagnostic.CA1806.severity = silent
+
+# CA2245: Do not assign a property to itself
+dotnet_diagnostic.CA2245.severity = silent
+
+# CA2201: Do not raise reserved exception types
+dotnet_diagnostic.CA2201.severity = warning
+
+# CA1805: Do not initialize unnecessarily
+dotnet_diagnostic.CA1805.severity = warning
+
+# CA1725: Parameter names should match base declaration
+dotnet_diagnostic.CA1725.severity = warning
+
+# IDE0001: Simplify Names
+dotnet_diagnostic.IDE0001.severity = warning
+
+# CA2215: Dispose methods should call base class dispose
+dotnet_diagnostic.CA2215.severity = warning
+
+# IDE0059: Unnecessary assignment of a value
+dotnet_diagnostic.IDE0059.severity = warning
+
+# CA1031: Do not catch general exception types
+dotnet_diagnostic.CA1031.severity = warning
+
+# CA1303: Do not pass literals as localized parameters
+dotnet_diagnostic.CA1303.severity = none

src/AmbientTasks.Tests/.editorconfig

@@ -0,0 +1,7 @@
+[*]
+
+# CA1031: Do not catch general exception types
+dotnet_diagnostic.CA1031.severity = none
+
+# CA2201: Do not raise reserved exception types
+dotnet_diagnostic.CA2201.severity = none

src/AmbientTasks.Tests/GlobalSuppressions.cs

@@ -80,7 +80,6 @@ public static void Add(Task? task)
             }
         }
 
-        [SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "All exceptions are caught and passed to the appropriate handler by design.")]
         private static void OnTaskCompleted(Task completedTask, object? state)
         {
             var (context, addSynchronizationContext, taskWasStarted) = ((AmbientTaskContext, SynchronizationContext, bool))state!;

src/AmbientTasks/AmbientTasks.cs

@@ -3,7 +3,7 @@
   <PropertyGroup>
     <LangVersion>latest</LangVersion>
     <Nullable>enable</Nullable>
-    <Features>strict</Features>
+    <AnalysisLevel>latest</AnalysisLevel>
     <TreatWarningsAsErrors Condition="'$(Configuration)' == 'Release'">true</TreatWarningsAsErrors>
   </PropertyGroup>