review(#135 pass 3): fix stale docstring + add async unbounded test

Per third-pass bot review on PR #135:

- _validate_max_pages docstring: "None (use default cap)" was stale
  after dropping the 1000-page default. Now reads "None (unbounded —
  iterates until the server returns no cursor)".
- TestMaxPagesNoneIsUnbounded: added test_async_iterates_past_1000_pages
  as the async counterpart to test_sync_iterates_past_1000_pages.
  Prevents the cap regression from silently re-appearing in only one
  of the two code paths.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: TexasCoding

kalshi/resources/_base.py

@@ -47,9 +47,10 @@ def _check_request_exclusive(request: Any, **kwargs: Any) -> None:
 def _validate_max_pages(max_pages: int | None) -> None:
     """Reject ``max_pages <= 0`` at the public ``*_all()`` boundary.
 
-    ``None`` (use default cap) and positive integers are valid. Zero or
-    negative would silently produce an empty iterator deep inside
-    ``_list_all``; surfacing the misuse here is friendlier.
+    ``None`` (unbounded — iterates until the server returns no cursor) and
+    positive integers are valid. Zero or negative would silently produce an
+    empty iterator deep inside ``_list_all``; surfacing the misuse here is
+    friendlier.
     """
     if max_pages is not None and max_pages <= 0:
         raise ValueError(

tests/test_base_helpers.py

@@ -438,3 +438,26 @@ def responder(request: httpx.Request) -> httpx.Response:
         resource = SyncResource(SyncTransport(test_auth, test_config))
         items = list(resource._list_all("/things", _Item, "items"))
         assert len(items) == total, f"Expected {total} items, got {len(items)} (cap leaked?)"
+
+    @respx.mock
+    @pytest.mark.asyncio
+    async def test_async_iterates_past_1000_pages(
+        self, test_auth: KalshiAuth, test_config: KalshiConfig,
+    ) -> None:
+        # Async counterpart — same 1010-page proof, prevents the regression
+        # from silently re-appearing in only one of the two code paths.
+        total = 1010
+        call_counter = {"n": 0}
+
+        def responder(request: httpx.Request) -> httpx.Response:
+            call_counter["n"] += 1
+            n = call_counter["n"]
+            cursor = str(n) if n < total else ""
+            return httpx.Response(
+                200, json={"items": [{"id": f"i{n}"}], "cursor": cursor},
+            )
+
+        respx.get("https://test.kalshi.com/trade-api/v2/things").mock(side_effect=responder)
+        resource = AsyncResource(AsyncTransport(test_auth, test_config))
+        items = [item async for item in resource._list_all("/things", _Item, "items")]
+        assert len(items) == total, f"Expected {total} items, got {len(items)} (cap leaked?)"