Skip to content

Commit f244d38

Browse files
committed
Minor bug fix
1 parent 9a07c4e commit f244d38

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

examples/viewer/web-ifc-viewer.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,13 +213,14 @@ async function LoadModel(data: Uint8Array) {
213213
PLANE_REFIT_ITERATIONS: 3,
214214
BOOLEAN_UNION_THRESHOLD: 100,
215215
});
216-
// #1092A -> TOLERANCE_PLANE_INTERSECTION: 5.0E-02
216+
// #1092 -> TOLERANCE_PLANE_INTERSECTION: 5.0E-02
217217
// #1256 -> TOLERANCE_PLANE_INTERSECTION: 1.0E-02, TOLERANCE_PLANE_DEVIATION: 1.0E-01, TOLERANCE_BACK_DEVIATION_DISTANCE: 1.0E-01
218218
// #1023 -> TOLERANCE_PLANE_DEVIATION: 1.0E-01, TOLERANCE_BACK_DEVIATION_DISTANCE: 1.0E-01
219219
// #540 -> TOLERANCE_PLANE_INTERSECTION: 1.0E-03, TOLERANCE_SCALAR_EQUALITY: 1.0E-01, PLANE_REFIT_ITERATIONS: 3
220220
// #1225 -> TOLERANCE_PLANE_DEVIATION: 1.0E-02, TOLERANCE_BACK_DEVIATION_DISTANCE: 1.0E-02, TOLERANCE_INSIDE_OUTSIDE_PERIMETER: 1.0E-02
221221
// #1506 -> TOLERANCE_PLANE_INTERSECTION = 1.0E-02, TOLERANCE_PLANE_DEVIATION = 1.0E-02, TOLERANCE_BACK_DEVIATION_DISTANCE = 1.0E-02;
222-
222+
// #604 -> BOOLEAN_UNION_THRESHOLD: 50
223+
// Ferroflex, samMateo -> CIRCLE_SEGMENTS: 6
223224
const time = ms() - start;
224225
console.log(`Opening model took ${time} ms`);
225226
ifcThree.LoadAllGeometry(scene, modelID);

src/cpp/web-ifc/geometry/operations/boolean-utils/clip-mesh.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -190,14 +190,14 @@ namespace fuzzybools
190190
}
191191

192192
#ifdef CSG_DEBUG_OUTPUT
193-
if (doit)
194-
{
195-
edgesPrinted.push_back({ glm::dvec2(a.z + a.x/2, a.y + a.x/2), glm::dvec2(b.z + b.x/2, b.y+ b.x/2)});
196-
edgesPrinted.push_back({ glm::dvec2(a.z + a.x/2, a.y + a.x/2), glm::dvec2(c.z + c.x/2, c.y+ c.x/2) });
197-
edgesPrinted.push_back({ glm::dvec2(b.z + b.x/2, b.y + b.x/2), glm::dvec2(c.z + c.x/2, c.y+ c.x/2) });
198-
DumpSVGLines(edgesPrinted, L"final_tri.html");
199-
doit = true;
200-
}
193+
// if (doit)
194+
// {
195+
// edgesPrinted.push_back({ glm::dvec2(a.z + a.x/2, a.y + a.x/2), glm::dvec2(b.z + b.x/2, b.y+ b.x/2)});
196+
// edgesPrinted.push_back({ glm::dvec2(a.z + a.x/2, a.y + a.x/2), glm::dvec2(c.z + c.x/2, c.y+ c.x/2) });
197+
// edgesPrinted.push_back({ glm::dvec2(b.z + b.x/2, b.y + b.x/2), glm::dvec2(c.z + c.x/2, c.y+ c.x/2) });
198+
// DumpSVGLines(edgesPrinted, L"final_tri.html");
199+
// doit = true;
200+
// }
201201
#endif
202202
}
203203

src/ts/web-ifc-api.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -313,6 +313,7 @@ export interface ProfileSection {
313313
filletRadius: number,
314314
radius: number,
315315
slope: number,
316+
circleSegments: number,
316317
placement: Array<number>
317318
): void;
318319
}

0 commit comments

Comments
 (0)