Skip to content

Commit 13f0295

Browse files
authored
fix: close file on readAll exception (oakserver#682)
1 parent dcc1aa9 commit 13f0295

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

deps.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export {
2222
} from "jsr:@std/http@^1.0/negotiation";
2323
export { UserAgent } from "jsr:@std/http@^1.0/user-agent";
2424
export { LimitedReader } from "jsr:@std/[email protected]/limited-reader";
25-
export { readAll } from "jsr:@std/[email protected]/read-all";
2625
export { contentType } from "jsr:@std/media-types@^1.0/content-type";
2726
export { typeByExtension } from "jsr:@std/media-types@^1.0/type-by-extension";
2827
export {

send.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import {
2424
ifNoneMatch,
2525
parse,
2626
range,
27-
readAll,
2827
responseRange,
2928
Status,
3029
} from "./deps.ts";
@@ -142,12 +141,11 @@ async function getEntity(
142141
let body: Uint8Array | Deno.FsFile;
143142
let entity: Uint8Array | FileInfo;
144143
const fileInfo = { mtime: new Date(mtime), size: stats.size };
145-
const file = await Deno.open(path, { read: true });
146144
if (stats.size < maxbuffer) {
147-
const buffer = await readAll(file);
148-
file.close();
145+
const buffer = await Deno.readFile(path);
149146
body = entity = buffer;
150147
} else {
148+
const file = await Deno.open(path, { read: true });
151149
response.addResource(file);
152150
body = file;
153151
entity = fileInfo;

0 commit comments

Comments
 (0)