implement non-interactive flow for create_if_needed() (#1230)

ColinFay · pachadotdev · claude · web-flow · commit 4cc1298d2cd7 · 2026-04-13T13:14:10.000+02:00
* implement non-interactive flow for create_if_needed() * Simplify create_if_needed() logic for #1154 - Remove warn_if_exists parameter (not needed for basic behavior) - Simplify overwrite parameter (only for future extensibility) - If file/dir exists and overwrite=FALSE: return TRUE, do nothing - If doesn't exist and interactive: ask user for permission - If doesn't exist and non-interactive: create silently with message() - Update tests to cover all three paths This matches the intended behavior: non-interactive mode creates files instead of failing, but still respects existing files. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * chore: version bump & news update --------- Co-authored-by: Mauricio Vargas Sepulveda <mavargas11@uc.cl> Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: golem
 Title: A Framework for Robust Shiny Applications
-Version: 0.5.2.9000
+Version: 0.5.1.9015
 Authors@R: c(
     person("Colin", "Fay", , "contact@colinfay.me", role = c("cre", "aut"),
            comment = c(ORCID = "0000-0001-7343-1846")),
diff --git a/NEWS.md b/NEWS.md
@@ -31,6 +31,8 @@
 
 - Renamed a function in 02_dev.R (add_any_file => add_empty_file)
 
+- The `create_if_needed()` function has been fixed to work in non interactive mode (#1154, @pachadotdev)
+
 ## Internal changes
 
 - `{golem}` now embarks a `claude.md` file and a series of skills
diff --git a/R/utils.R b/R/utils.R
@@ -17,73 +17,67 @@ create_if_needed <- function(
 		"file",
 		"directory"
 	),
-	content = NULL
+	content = NULL,
+	overwrite = FALSE
 ) {
 	type <- match.arg(
 		type
 	)
 
 	# Check if file or dir already exist
 	if (type == "file") {
-		dont_exist <- Negate(
-			fs_file_exists
-		)(
-			path
-		)
+		already_exists <- fs_file_exists(path)
 	} else if (type == "directory") {
-		dont_exist <- Negate(
-			fs_dir_exists
-		)(
-			path
-		)
+		already_exists <- fs_dir_exists(path)
+	}
+
+	# If it already exists and overwrite is FALSE, do nothing
+	if (already_exists && !overwrite) {
+		return(TRUE)
 	}
-	# If it doesn't exist, ask if we are allowed to create it
-	if (dont_exist) {
+
+	# File doesn't exist (or we're overwriting) - need to create it
+	if (!already_exists) {
 		if (rlang_is_interactive()) {
+			# In interactive mode, ask user for permission
 			ask <- ask_golem_creation_file(
 				path,
 				type
 			)
-			# Return early if the user doesn't allow
 			if (!ask) {
-				return(
-					FALSE
-				)
-			}
-			# Create the file
-			if (type == "file") {
-				fs_file_create(
-					path
-				)
-				write(
-					content,
-					path,
-					append = TRUE
-				)
-			} else if (type == "directory") {
-				fs_dir_create(
-					path,
-					recurse = TRUE
-				)
+				return(FALSE)
 			}
 		} else {
-			# We don't create the file if we are not in
-			# interactive mode
-			stop(
+			# In non-interactive mode, inform user of creation
+			message(
 				sprintf(
-					"The %s %s doesn't exist.",
-					basename(
-						path
-					),
-					type
+					"Creating %s %s",
+					type,
+					path
 				)
 			)
 		}
 	}
+
+	# Create the file or directory
+	if (type == "file") {
+		fs_file_create(path)
+		if (!is.null(content)) {
+			write(
+				content,
+				path,
+				append = !overwrite
+			)
+		}
+	} else if (type == "directory") {
+		fs_dir_create(
+			path,
+			recurse = TRUE
+		)
+	}
+
 	# TRUE means that file exists (either created or already there)
-	return(
-		TRUE
-	)
+	return(TRUE)
 }
 
 ask_golem_creation_file <- function(
diff --git a/README.md b/README.md
@@ -5,14 +5,14 @@
 [![Lifecycle:
 stable](https://img.shields.io/badge/lifecycle-stable-brightgreen.svg)](https://lifecycle.r-lib.org/articles/stages.html)[![R-CMD-check](https://github.com/ThinkR-open/golem/workflows/R-CMD-check/badge.svg)](https://github.com/ThinkR-open/golem/actions)
 [![Coverage
-status](https://codecov.io/gh/ThinkR-open/golem/branch/master/graph/badge.svg)](https://app.codecov.io/github/ThinkR-open/golem/tree/master)[![CRAN
+status](https://codecov.io/gh/ThinkR-open/golem/branch/fix/create-if-needed/graph/badge.svg)](https://app.codecov.io/github/ThinkR-open/golem/tree/fix/create-if-needed)[![CRAN
 status](https://www.r-pkg.org/badges/version/golem)](https://cran.r-project.org/package=golem)
 
 <!-- badges: end -->
 
 # {golem} <img src="https://raw.githubusercontent.com/ThinkR-open/golem/master/inst/rstudio/templates/project/golem.png" align="right" width="120"/>
 
-> You’re reading the doc about version: 0.5.1.9011. Note that `{golem}`
+> You’re reading the doc about version: 0.5.1.9015. Note that `{golem}`
 > follows the [semantic versioning](https://semver.org/) scheme.
 
 Production-grade `{shiny}` applications, from creation to deployment.
@@ -82,16 +82,16 @@ This `README` has been compiled on the
 
 ``` r
 Sys.time()
-#> [1] "2025-05-30 15:24:30 CEST"
+#> [1] "2026-04-13 10:36:56 CEST"
 ```
 
 Here are the test & coverage results:
 
 ``` r
 devtools::check(quiet = TRUE)
 #> ℹ Loading golem
-#> ── R CMD check results ─────────────────────────────────── golem 0.5.1.9011 ────
-#> Duration: 52.7s
+#> ── R CMD check results ─────────────────────────────────── golem 0.5.1.9015 ────
+#> Duration: 45.2s
 #> 
 #> ❯ checking for future file timestamps ... NOTE
 #>   unable to verify current time
@@ -102,47 +102,47 @@ devtools::check(quiet = TRUE)
 ``` r
 Sys.setenv("NOT_CRAN" = TRUE)
 covr::package_coverage()
-#> golem Coverage: 88.56%
+#> golem Coverage: 87.99%
 #> R/boostrap_base.R: 0.00%
 #> R/bootstrap_attachment.R: 0.00%
 #> R/bootstrap_pkgload.R: 0.00%
 #> R/bootstrap_roxygen2.R: 0.00%
 #> R/bootstrap_rstudio_api.R: 0.00%
 #> R/bootstrap_testthat.R: 0.00%
 #> R/bootstrap_dockerfiler.R: 23.33%
-#> R/test_helpers.R: 47.37%
-#> R/bootstrap_desc.R: 55.56%
-#> R/cli_msg.R: 75.64%
-#> R/modules_fn.R: 76.44%
-#> R/install_dev_deps.R: 78.26%
-#> R/addins.R: 78.65%
-#> R/add_r_files.R: 78.79%
-#> R/config.R: 80.29%
-#> R/add_rstudio_files.R: 80.82%
+#> R/test_helpers.R: 45.06%
+#> R/bootstrap_desc.R: 50.00%
+#> R/addins.R: 76.00%
+#> R/add_r_files.R: 78.81%
+#> R/cli_msg.R: 80.36%
+#> R/modules_fn.R: 80.62%
+#> R/install_dev_deps.R: 80.70%
+#> R/add_rstudio_files.R: 81.36%
+#> R/add_dockerfiles_renv.R: 81.40%
+#> R/reload.R: 82.83%
 #> R/bootstrap_usethis.R: 85.45%
-#> R/disable_autoload.R: 88.00%
-#> R/reload.R: 88.64%
-#> R/sanity_check.R: 88.64%
-#> R/add_dockerfiles.R: 89.61%
-#> R/add_dockerfiles_renv.R: 89.68%
-#> R/make_dev.R: 90.00%
-#> R/use_favicon.R: 90.82%
-#> R/js.R: 93.75%
-#> R/use_files_internal.R: 93.75%
-#> R/use_recommended.R: 94.34%
-#> R/add_files.R: 95.15%
-#> R/create_golem.R: 95.86%
-#> R/boostrap_cli.R: 96.43%
-#> R/run_dev.R: 96.77%
-#> R/desc.R: 96.84%
-#> R/use_utils.R: 98.04%
-#> R/utils.R: 99.32%
+#> R/js.R: 86.21%
+#> R/add_dockerfiles.R: 86.73%
+#> R/sanity_check.R: 91.86%
+#> R/disable_autoload.R: 91.89%
+#> R/create_golem.R: 92.67%
+#> R/boostrap_cli.R: 92.68%
+#> R/add_files.R: 93.75%
+#> R/use_favicon.R: 93.84%
+#> R/use_files_internal.R: 95.83%
+#> R/make_dev.R: 96.43%
+#> R/utils.R: 96.93%
+#> R/use_recommended.R: 96.94%
+#> R/desc.R: 97.71%
+#> R/run_dev.R: 98.18%
+#> R/use_utils.R: 98.87%
 #> R/add_resource_path.R: 100.00%
 #> R/boostrap_crayon.R: 100.00%
 #> R/boostrap_fs.R: 100.00%
 #> R/browser_button.R: 100.00%
 #> R/bundle_resources.R: 100.00%
 #> R/cats.R: 100.00%
+#> R/config.R: 100.00%
 #> R/enable_roxygenize.R: 100.00%
 #> R/get_sysreqs.R: 100.00%
 #> R/globals.R: 100.00%
diff --git a/tests/testthat/test-utils.R b/tests/testthat/test-utils.R
@@ -15,81 +15,90 @@ test_that("rlang_is_interactive() works", {
 })
 
 test_that("create_if_needed creates a file if required", {
-	expect_error(
+	# Test: non-interactive mode creates file silently
+	temp_file <- tempfile()
+	expect_true(
 		testthat::with_mocked_bindings(
 			rlang_is_interactive = function() {
-				return(
-					FALSE
-				)
+				return(FALSE)
 			},
 			code = {
-				create_if_needed(
-					tempfile()
-				)
+				create_if_needed(temp_file)
 			}
 		)
 	)
+	expect_true(file.exists(temp_file))
+	unlink(temp_file)
+
+	# Test: interactive mode, user says no
 	expect_false(
 		testthat::with_mocked_bindings(
 			rlang_is_interactive = function() {
-				return(
-					TRUE
-				)
+				return(TRUE)
 			},
-			ask_golem_creation_file = function(
-				path,
-				type
-			) {
-				return(
-					FALSE
-				)
+			ask_golem_creation_file = function(path, type) {
+				return(FALSE)
 			},
 			code = {
-				create_if_needed(
-					tempfile()
-				)
+				create_if_needed(tempfile())
 			}
 		)
 	)
+
+	# Test: interactive mode, user says yes to file
+	temp_file <- tempfile()
 	expect_true(
 		testthat::with_mocked_bindings(
 			rlang_is_interactive = function() {
-				return(
-					TRUE
-				)
+				return(TRUE)
 			},
 			ask_golem_creation_file = function(path, type) {
-				return(
-					TRUE
-				)
+				return(TRUE)
 			},
 			code = {
-				create_if_needed(
-					tempfile()
-				)
+				create_if_needed(temp_file)
 			}
 		)
 	)
+	expect_true(file.exists(temp_file))
+	unlink(temp_file)
+
+	# Test: interactive mode, user says yes to directory
+	temp_dir <- tempfile()
 	expect_true(
 		testthat::with_mocked_bindings(
 			rlang_is_interactive = function() {
-				return(
-					TRUE
-				)
+				return(TRUE)
 			},
 			ask_golem_creation_file = function(path, type) {
-				return(
-					TRUE
-				)
+				return(TRUE)
 			},
 			code = {
-				create_if_needed(
-					tempfile(),
-					type = "dir"
-				)
+				create_if_needed(temp_dir, type = "directory")
+			}
+		)
+	)
+	expect_true(dir.exists(temp_dir))
+	unlink(temp_dir, recursive = TRUE)
+
+	# Test: file already exists, should return TRUE without asking
+	temp_file <- tempfile()
+	file.create(temp_file)
+	expect_true(
+		testthat::with_mocked_bindings(
+			rlang_is_interactive = function() {
+				return(TRUE)
+			},
+			ask_golem_creation_file = function(path, type) {
+				# This should NOT be called when file exists
+				stop("ask_golem_creation_file should not be called")
+			},
+			code = {
+				create_if_needed(temp_file)
 			}
 		)
 	)
+	unlink(temp_file)
 })
 
 test_that("ask_golem_creation_file works", {
