CA1816 Change Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it.

raman-m · raman-m · commit 41dc650412dc · 2024-04-19T20:15:44.000+03:00
diff --git a/test/Ocelot.AcceptanceTests/CustomMiddlewareTests.cs b/test/Ocelot.AcceptanceTests/CustomMiddlewareTests.cs
@@ -496,8 +496,9 @@ private void GivenThereIsAServiceRunningOn(string url, int statusCode, string ba
 
         public void Dispose()
         {
-            _serviceHandler?.Dispose();
-            _steps.Dispose();
+            _serviceHandler.Dispose();
+            _steps.Dispose();
+            GC.SuppressFinalize(this);
         }
 
         public class FakeMiddleware

Original file line number	Diff line number	Diff line change
`@@ -496,8 +496,9 @@ private void GivenThereIsAServiceRunningOn(string url, int statusCode, string ba`
`496`	`496`
`497`	`497`	`public void Dispose()`
`498`	`498`	`{`
`499`		`- _serviceHandler?.Dispose();`
`500`		`- _steps.Dispose();`
	`499`	`+ _serviceHandler.Dispose();`
	`500`	`+ _steps.Dispose();`
	`501`	`+ GC.SuppressFinalize(this);`
`501`	`502`	`}`
`502`	`503`
`503`	`504`	`public class FakeMiddleware`