CA1816 Change Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it.

raman-m · raman-m · commit 81d796cc85cf · 2023-08-25T17:44:12.000+03:00
diff --git a/test/Ocelot.AcceptanceTests/CustomMiddlewareTests.cs b/test/Ocelot.AcceptanceTests/CustomMiddlewareTests.cs
@@ -465,8 +465,9 @@ private void GivenThereIsAServiceRunningOn(string url, int statusCode, string ba
 
         public void Dispose()
         {
-            _serviceHandler?.Dispose();
-            _steps.Dispose();
+            _serviceHandler.Dispose();
+            _steps.Dispose();
+            GC.SuppressFinalize(this);
         }
 
         public class FakeMiddleware

Original file line number	Diff line number	Diff line change
`@@ -465,8 +465,9 @@ private void GivenThereIsAServiceRunningOn(string url, int statusCode, string ba`
`465`	`465`
`466`	`466`	`public void Dispose()`
`467`	`467`	`{`
`468`		`- _serviceHandler?.Dispose();`
`469`		`- _steps.Dispose();`
	`468`	`+ _serviceHandler.Dispose();`
	`469`	`+ _steps.Dispose();`
	`470`	`+ GC.SuppressFinalize(this);`
`470`	`471`	`}`
`471`	`472`
`472`	`473`	`public class FakeMiddleware`