Skip to content

Commit 9cf11b5

Browse files
committed
make style
1 parent 070ede2 commit 9cf11b5

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

sqlmesh/core/engine_adapter/doris.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
PandasNativeFetchDFSupportMixin,
1818
)
1919
from sqlmesh.core.engine_adapter.shared import (
20-
CatalogSupport,
2120
CommentCreationTable,
2221
CommentCreationView,
2322
DataObject,
@@ -55,10 +54,8 @@ class DorisEngineAdapter(
5554
SUPPORTS_MATERIALIZED_VIEW_SCHEMA = True
5655
SUPPORTS_CREATE_DROP_CATALOG = False
5756
INSERT_OVERWRITE_STRATEGY = InsertOverwriteStrategy.DELETE_INSERT
58-
59-
@property
60-
def catalog_support(self) -> CatalogSupport:
61-
return CatalogSupport.FULL_SUPPORT
57+
# default setting `enable_unicode_name_support=false` so it is incompatible with unicode characters in model names
58+
QUOTE_IDENTIFIERS_IN_VIEWS = False
6259

6360
def create_schema(
6461
self,
@@ -1120,4 +1117,4 @@ def _properties_to_expressions(self, properties: t.Dict[str, t.Any]) -> t.List[e
11201117
if not isinstance(value, exp.Expression):
11211118
value = exp.Literal.string(str(value))
11221119
expressions.append(exp.Property(this=exp.Literal.string(str(key)), value=value))
1123-
return expressions
1120+
return expressions

tests/core/engine_adapter/integration/test_integration_doris.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ def engine_adapter(ctx: TestContext) -> DorisEngineAdapter:
3030

3131
def test_engine_adapter(ctx: TestContext):
3232
assert isinstance(ctx.engine_adapter, DorisEngineAdapter)
33-
assert ctx.engine_adapter.fetchone("select 1") == (1,)
33+
assert ctx.engine_adapter.fetchone("select 1") == (1,)

tests/core/engine_adapter/test_doris.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
from tests.core.engine_adapter import to_sql_calls
88

99
from sqlmesh.core.engine_adapter.doris import DorisEngineAdapter
10-
from sqlmesh.utils.errors import UnsupportedCatalogOperationError
1110

1211
from pytest_mock.plugin import MockerFixture
1312

@@ -133,16 +132,11 @@ def test_create_table_like(make_mocked_engine_adapter: t.Callable[..., DorisEngi
133132
def test_create_schema(make_mocked_engine_adapter: t.Callable[..., DorisEngineAdapter]):
134133
adapter = make_mocked_engine_adapter(DorisEngineAdapter)
135134
adapter.create_schema("test_schema")
136-
adapter.create_schema("test_schema", ignore_if_exists=False)
137135

138136
assert to_sql_calls(adapter) == [
139137
"CREATE DATABASE IF NOT EXISTS `test_schema`",
140-
"CREATE DATABASE `test_schema`",
141138
]
142139

143-
with pytest.raises(UnsupportedCatalogOperationError):
144-
adapter.create_schema("test_catalog.test_schema")
145-
146140

147141
def test_drop_schema(make_mocked_engine_adapter: t.Callable[..., DorisEngineAdapter]):
148142
adapter = make_mocked_engine_adapter(DorisEngineAdapter)

0 commit comments

Comments
 (0)