Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.kubernetes.io/name already defined #45

Open
SorsOps opened this issue Jan 13, 2025 · 0 comments
Open

app.kubernetes.io/name already defined #45

SorsOps opened this issue Jan 13, 2025 · 0 comments

Comments

@SorsOps
Copy link
Contributor

SorsOps commented Jan 13, 2025

There are cases where explicit labels are being passed that are expected to overwrite default labels. This breaks some templating systems that consider this to be an error. Instead it would be better if the default labels omit the duplicated values

Eg here https://github.com/ToolJet/helm-charts/blob/302efbf7125b6547375276e4cd1a6fe3dfd387ea/charts/tooljet/templates/service-pgrst.yml#L9C23-L9C27

where app.kubernetes.io/name: tooljet-postgrest is expected to overwrite {{- include "tooljet.labels" . | nindent 4 }}

0sHelm install failed for release tooljet/tooljet with chart [email protected]: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors: line 13: mapping key "app.kubernetes.io/name" already defined at line 8 line 12: mapping key "app.kubernetes.io/instance" already defined at line 9 line 22: mapping key "app.kubernetes.io/name" already defined at line 18 line 21: mapping key "app.kubernetes.io/instance" already defined at line 19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant