Investigate WorldEdit Dependency Requirements

[Wild1145]

@Telesphoreo has flagged that on their builds of TFM they only need WorldEdit - Bukkit and not WorldEdit - Core as well.

I think WorldEdit - Core is where the custom changes were made, but we need to do some looking into this to make sure we're only importing as a dependency what TFM actually requires.

[Telesphoreo]

            <groupId>com.github.Telesphoreo</groupId>
            <artifactId>TF-WorldEdit</artifactId>
            <version>76e3b56e92</version>
            <scope>provided</scope>
        </dependency>

Mine compiles just fine without having a .bukkit or .core

[Wild1145]

So you import in the entire WorldEdit project, including Core, Bukkit and Sponge there. So it probably does make more sense for us to just import Bukkit and core then as we don't need the sponge code.

[Telesphoreo]

Actually no, I deleted the sponge and forge project folders completely so it doesn't build those at all

[Wild1145]

That would explain it then. If we keep those within TF-WorldEdit we will need to continue using sub-projects but if we wipe them out we can just use the main repo without sub-projects.

[tylerhyperHD]

After implementing the code, I was eventually able to compile it due to bukkit-classloader-check being removed from the sk89q repo. The version of bukkit that must be implemented with it is 1.8 as well as adding the new classloader check: com.sk89q.spigot:bukkit-classloader-check:1.8-R0.1-SNAPSHOT.

As far as the new changes to WorldEdit, they added a new licensing plugin which needs to be removed to add the custom implementations. Also, repo.bukkit.org doesn't exist, so this can be removed.

[Telesphoreo]

@tylerhyperHD you don't need to remove the licensing plugin, you just have to add the header. The new worldedit still compiles fine with 1.12 or 1.13 but is not compatible in game. I had issues with that class also, but the problem solved itself

[tylerhyperHD]

@Telesphoreo Weird - Once I added TF modifications for the 7.0.0 snapshot the licensing plugin spat out errors and since I didn't wanna deal with it I just removed it. Seems to work on my test server even if I removed it though.

[Telesphoreo]

One of the things you can do to get the other version of WorldEdit to compile is to use the CodeMC repo. They have all of the NMS (for 1.12/1.13 that works properly) and has the old version of CB (1.6.4) on it. After adding that as a repo and replacing it with the spigot nexus one, it worked for me 100% of the time