Merge pull request #433 from TransactionProcessing/task/#402_return_line_fail_reason

StuartFerguson · web-flow · commit cfb4198ec282 · 2024-12-18T16:32:21.000Z
return failure reasons
diff --git a/FileProcessor.FileAggregate/FileAggregate.cs b/FileProcessor.FileAggregate/FileAggregate.cs
@@ -87,6 +87,7 @@ public static void PlayEvent(this FileAggregate aggregate, FileLineProcessingSuc
         
         public static void PlayEvent(this FileAggregate aggregate, FileLineProcessingFailedEvent domainEvent)
         {
+            
             FileLine fileLine = aggregate.FileLines.Single(f => f.LineNumber == domainEvent.LineNumber);
             fileLine.TransactionId = domainEvent.TransactionId;
             fileLine.ProcessingResult = ProcessingResult.Failed;
diff --git a/FileProcessor/Common/ModelFactory.cs b/FileProcessor/Common/ModelFactory.cs
@@ -86,7 +86,8 @@ public FileDetailsResponse ConvertFrom(Models.FileDetails fileDetails)
                                                       LineData = fileDetailsFileLine.LineData,
                                                       LineNumber = fileDetailsFileLine.LineNumber,
                                                       ProcessingResult = this.TranslateProcessingResult(fileDetailsFileLine.ProcessingResult),
-                                                      TransactionId = fileDetailsFileLine.TransactionId
+                                                      TransactionId = fileDetailsFileLine.TransactionId,
+                                                      RejectionReason = fileDetailsFileLine.RejectedReason
                                                   });
             }
 
diff --git a/FileProcessor/Controllers/FileController.cs b/FileProcessor/Controllers/FileController.cs
@@ -125,7 +125,7 @@ public async Task<IActionResult> GetFile([FromRoute] Guid fileId,
             if (result.IsFailed)
                 return ResultHelpers.CreateFailure(result).ToActionResultX();
 
-            var response = this.ModelFactory.ConvertFrom(result.Data);
+            DataTransferObjects.Responses.FileDetails response = this.ModelFactory.ConvertFrom(result.Data);
 
             return Result.Success(response).ToActionResultX();
 

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,7 @@ public static void PlayEvent(this FileAggregate aggregate, FileLineProcessingSuc`
`87`	`87`
`88`	`88`	`public static void PlayEvent(this FileAggregate aggregate, FileLineProcessingFailedEvent domainEvent)`
`89`	`89`	`{`
	`90`	`+`
`90`	`91`	`FileLine fileLine = aggregate.FileLines.Single(f => f.LineNumber == domainEvent.LineNumber);`
`91`	`92`	`fileLine.TransactionId = domainEvent.TransactionId;`
`92`	`93`	`fileLine.ProcessingResult = ProcessingResult.Failed;`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,8 @@ public FileDetailsResponse ConvertFrom(Models.FileDetails fileDetails)`
`86`	`86`	`LineData = fileDetailsFileLine.LineData,`
`87`	`87`	`LineNumber = fileDetailsFileLine.LineNumber,`
`88`	`88`	`ProcessingResult = this.TranslateProcessingResult(fileDetailsFileLine.ProcessingResult),`
`89`		`- TransactionId = fileDetailsFileLine.TransactionId`
	`89`	`+ TransactionId = fileDetailsFileLine.TransactionId,`
	`90`	`+ RejectionReason = fileDetailsFileLine.RejectedReason`
`90`	`91`	`});`
`91`	`92`	`}`
`92`	`93`