remove retry :|

StuartFerguson · StuartFerguson · commit 7952369aa2ca · 2025-04-30T06:15:18.000+01:00
diff --git a/TransactionProcessor.BusinessLogic/Services/SettlementDomainService.cs b/TransactionProcessor.BusinessLogic/Services/SettlementDomainService.cs
@@ -100,9 +100,6 @@ private async Task<Result> ApplyTransactionUpdates(Func<TransactionAggregate, Ta
 
         public async Task<Result<Guid>> ProcessSettlement(SettlementCommands.ProcessSettlementCommand command,
                                                           CancellationToken cancellationToken) {
-            IAsyncPolicy<Result<Guid>> retryPolicy = PolicyFactory.CreatePolicy<Guid>(policyTag: "SettlementDomainService - ProcessSettlement");
-
-            return await PolicyFactory.ExecuteWithPolicyAsync<Guid>(async () => {
                 Guid settlementAggregateId = Helpers.CalculateSettlementAggregateId(command.SettlementDate, command.MerchantId, command.EstateId);
                 List<(Guid transactionId, Guid merchantId, CalculatedFee calculatedFee)> feesToBeSettled = new();
 
@@ -164,7 +161,6 @@ public async Task<Result<Guid>> ProcessSettlement(SettlementCommands.ProcessSett
                 }
 
                 return Result.Success(settlementAggregateId);
-            }, retryPolicy, "SettlementDomainService - ProcessSettlement");
         }
 
         public async Task<Result> AddMerchantFeePendingSettlement(SettlementCommands.AddMerchantFeePendingSettlementCommand command,

Original file line number	Diff line number	Diff line change
`@@ -100,9 +100,6 @@ private async Task<Result> ApplyTransactionUpdates(Func<TransactionAggregate, Ta`
`100`	`100`
`101`	`101`	`public async Task<Result<Guid>> ProcessSettlement(SettlementCommands.ProcessSettlementCommand command,`
`102`	`102`	`CancellationToken cancellationToken) {`
`103`		`- IAsyncPolicy<Result<Guid>> retryPolicy = PolicyFactory.CreatePolicy<Guid>(policyTag: "SettlementDomainService - ProcessSettlement");`
`104`		`-`
`105`		`- return await PolicyFactory.ExecuteWithPolicyAsync<Guid>(async () => {`
`106`	`103`	`Guid settlementAggregateId = Helpers.CalculateSettlementAggregateId(command.SettlementDate, command.MerchantId, command.EstateId);`
`107`	`104`	`List<(Guid transactionId, Guid merchantId, CalculatedFee calculatedFee)> feesToBeSettled = new();`
`108`	`105`
`@@ -164,7 +161,6 @@ public async Task<Result<Guid>> ProcessSettlement(SettlementCommands.ProcessSett`
`164`	`161`	`}`
`165`	`162`
`166`	`163`	`return Result.Success(settlementAggregateId);`
`167`		`- }, retryPolicy, "SettlementDomainService - ProcessSettlement");`
`168`	`164`	`}`
`169`	`165`
`170`	`166`	`public async Task<Result> AddMerchantFeePendingSettlement(SettlementCommands.AddMerchantFeePendingSettlementCommand command,`