Merge pull request #714 from TransactionProcessing/bug/#713_handle_voucher_issue_failure

Add logging and error handling for voucher issuance

Author: StuartFerguson

TransactionProcessor.BusinessLogic.Tests/OperatorInterfaces/VoucherManagementProxyTests.cs

@@ -1,4 +1,5 @@
-using SimpleResults;
+using Shared.Logger;
+using SimpleResults;
 
 namespace TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces
 {
@@ -17,6 +18,10 @@ namespace TransactionProcessor.BusinessLogic.Tests.OperatorInterfaces
 
     public class VoucherManagementProxyTests
     {
+        public VoucherManagementProxyTests() {
+            Logger.Initialise(new NullLogger());
+        }
+
         [Fact]
         public async Task VoucherManagementProxy_ProcessLogonMessage_NullReturned() {
             Mock<IMediator> mediator = new Mock<IMediator>();
@@ -50,7 +55,25 @@ public async Task VoucherManagementProxy_ProcessSaleMessage_VoucherIssueSuccessf
             operatorResponse.AdditionalTransactionResponseMetadata.ShouldContainKey("VoucherCode");
             operatorResponse.AdditionalTransactionResponseMetadata.ShouldContainKey("VoucherExpiryDate");
         }
-        
+
+        [Fact]
+        public async Task VoucherManagementProxy_ProcessSaleMessage_VoucherIssueFailed_FailedResultReturned()
+        {
+            Mock<IMediator> mediator = new Mock<IMediator>();
+            mediator.Setup(m => m.Send(It.IsAny<VoucherCommands.IssueVoucherCommand>(), It.IsAny<CancellationToken>())).ReturnsAsync(Result.Failure("Some grim error"));
+            IOperatorProxy voucherManagementProxy = new VoucherManagementProxy(mediator.Object);
+
+            var result = await voucherManagementProxy.ProcessSaleMessage(TestData.TransactionId,
+                TestData.OperatorId,
+                TestData.Merchant,
+                TestData.TransactionDateTime,
+                TestData.TransactionReference,
+                TestData.AdditionalTransactionMetaDataForVoucher(),
+                CancellationToken.None);
+            
+            result.IsFailed.ShouldBeTrue();
+        }
+
         [Theory]
         [InlineData("")]
         [InlineData(null)]

TransactionProcessor.BusinessLogic/OperatorInterfaces/VoucherManagement/VoucherManagementProxy.cs

@@ -1,5 +1,7 @@
 using System;
 using System.Collections.Generic;
+using Shared.Logger;
+using Shared.Results;
 using SimpleResults;
 
 namespace TransactionProcessor.BusinessLogic.OperatorInterfaces.VoucherManagement
@@ -62,28 +64,30 @@ public async Task<Result<OperatorResponse>> ProcessSaleMessage(Guid transactionI
                                                                      recipientMobile);
 
             Result<IssueVoucherResponse> result= await this.Mediator.Send(command, cancellationToken);
-            
-            if (result.IsSuccess) {
-                // Build the response metadata
-                Dictionary<String, String> additionalTransactionResponseMetadata = new Dictionary<String, String>();
-                additionalTransactionResponseMetadata.Add("VoucherCode", result.Data.VoucherCode);
-                additionalTransactionResponseMetadata.Add("VoucherMessage", result.Data.Message);
-                additionalTransactionResponseMetadata.Add("VoucherExpiryDate", result.Data.ExpiryDate.ToString("yyyy-MM-dd"));
 
-                return Result.Success(new OperatorResponse
-                {
-                    TransactionId = transactionId.ToString("N"),
-                    ResponseCode = "0000",
-                    ResponseMessage = "SUCCESS",
-                    // This may contain the voucher details to be logged with the transaction, and for possible receipt email/print
-                    AdditionalTransactionResponseMetadata = additionalTransactionResponseMetadata,
-                    AuthorisationCode = "ABCD1234",
-                    IsSuccessful = true
-                });
+            if (result.IsFailed) {
+                Logger.LogWarning($"Error issuing voucher {result.Message}");
+                return ResultHelpers.CreateFailure(result);
             }
 
-            // TODO: handle a failed issue case
-            return null;
+            // Build the response metadata
+            Dictionary<String, String> additionalTransactionResponseMetadata = new Dictionary<String, String>();
+            additionalTransactionResponseMetadata.Add("VoucherCode", result.Data.VoucherCode);
+            additionalTransactionResponseMetadata.Add("VoucherMessage", result.Data.Message);
+            additionalTransactionResponseMetadata.Add("VoucherExpiryDate", result.Data.ExpiryDate.ToString("yyyy-MM-dd"));
+
+            return Result.Success(new OperatorResponse
+            {
+                TransactionId = transactionId.ToString("N"),
+                ResponseCode = "0000",
+                ResponseMessage = "SUCCESS",
+                // This may contain the voucher details to be logged with the transaction, and for possible receipt email/print
+                AdditionalTransactionResponseMetadata = additionalTransactionResponseMetadata,
+                AuthorisationCode = "ABCD1234",
+                IsSuccessful = true
+            });
+            
+            
         }
     }
 }