Fix inconsistent inclusion of padding files in tdef

Author: qstokkink

src/tribler/core/libtorrent/torrentdef.py

@@ -638,8 +638,12 @@ def _get_all_files_as_unicode_with_length(self) -> Generator[tuple[Path, int], N
             metainfo_v1 = cast(InfoDict, self.metainfo[b"info"])
             # Multi-file v1 torrent
             files = cast(FileDict, metainfo_v1[b"files"])
+            storage = self.torrent_info.files()
 
-            for file_dict in files:
+            for index, file_dict in enumerate(files):
+                # Ignore padding files, to align with v2 metainfo
+                if storage.file_flags(index) != 0:
+                    continue
                 if b"path.utf-8" in file_dict:
                     # This file has an utf-8 encoded list of elements.
                     # We assume that it is correctly encoded and use it normally.

src/tribler/test_unit/core/libtorrent/test_torrentdef.py

@@ -432,6 +432,22 @@ def test_get_files_with_length_illegal_path_utf8(self) -> None:
 
         self.assertEqual([(Path("file.txt"), 456)], tdef.get_files_with_length())
 
+    def test_get_files_with_length_ignore_padding(self) -> None:
+        """
+        Test if get_files_with_length ignores padding files.
+        """
+        tdef = TorrentDef(metainfo={
+            b"info": {
+                b"name": b"torrent name",
+                b"files": [{b"path": [b".pad"], b"length": 123, b"attr": b"p"},
+                           {b"path": [b"file.txt"], b"length": 456}],
+                b"piece length": 128,
+                b"pieces": b"\x00" * 100  # 100 = ceil((123+456)/128) * 20
+            }
+        })
+
+        self.assertEqual([(Path('file.txt'), 456)], tdef.get_files_with_length())
+
     def test_load_torrent_info(self) -> None:
         """
         Test if load_torrent_info() loads the torrent info.