Popular torrents list items disappearing

[qstokkink]

With the latest main branch, items are disappearing from the popular torrents list.

We observed two instances:

• Disappearing items with a list update.
• An item disappears after checking its health. After the next refresh, the download reappears. Popular torrents list items disappearing #8510 (comment)

[qstokkink]

The first half of this issue (the small list) stems from the fact that for the 50 popular torrents received from the core, with a unique title, only 16~17 have a unique infohash. These are filtered down.

[qstokkink]

Part of the second half of this issue is that after checking the health, the torrent turns out to have less seeders/leechers than previously known/reported. This causes it to disappear from the list after checking. The other part: why it reappears later in some cases, I do not know.

[qstokkink]

I'm starting to be convinced that the second half of this issue is not really a "bug": we simply present a lot of out-of-date data that is not so popular after rechecking it.

I think what is happening in OP is that when other downloads are rechecked: they get demoted, which in turn makes other demoted content relatively popular again.

[qstokkink]

I'll reschedule this for 8.2.0: this behavior is not due to a recent 8.1 change. It is also not fundamentally broken, or crashing, just not ideal.