Bug: Note share with password protection doesn't work #1290

MarcS1975 · 2025-02-08T01:36:44Z

MarcS1975
Feb 8, 2025

Description

As reported on Trillium Github, the protected share note function with #shareCredentials="user:password" does not work. Sharing the note without password works fine.
Could have to do with the fact that my server is behind a reverse proxy?

TriliumNext Version

0.91.6

What operating system are you using?

Windows

What is your setup?

Local + server sync

Operating System Version

Windows - Server on Docker

Error logs

Error in browser:

This site can’t be reached
The webpage at https://trillium.myDom.org/share/G93KnAaiO7kv might be temporarily down or it may have moved permanently to a new web address.
ERR_HTTP2_PROTOCOL_ERROR

Trillium Log output:

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at ServerResponse.header (/usr/src/app/node_modules/express/lib/response.js:794:10)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:174:12)
    at ServerResponse.json (/usr/src/app/node_modules/express/lib/response.js:278:15)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:162:21)
    at file:///usr/src/app/src/routes/error_handlers.js:27:13
    at Layer.handle_error (/usr/src/app/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:326:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:346:12)
200 GET /api/health-check with 15 bytes took 0ms

FliegendeWurst · 2025-02-10T16:44:42Z

FliegendeWurst
Feb 10, 2025

I have the same issue on a different HTTP endpoint (/api/login/sync)

200 POST /api/login/sync with 54 bytes took 1ms
[Error: ENOENT: no such file or directory, open '/tmp/nix-shell-55589-0/tmp.s1aA0MptsK/trilium-data/sessions/xeQugGdFNZBZXpnZwLA8OC2-UApaQH47.json.2250031454'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/tmp/nix-shell-55589-0/tmp.s1aA0MptsK/trilium-data/sessions/xeQugGdFNZBZXpnZwLA8OC2-UApaQH47.json.2250031454'
}
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:659:11)
    at ServerResponse.header (/nix/store/qnyxm50ym8pzyq02zgf97zi109b3m21f-trilium-next-server-0.91.5/share/trilium-server/node_modules/express/lib/response.js:794:10)
    at ServerResponse.send (/nix/store/qnyxm50ym8pzyq02zgf97zi109b3m21f-trilium-next-server-0.91.5/share/trilium-server/node_modules/express/lib/response.js:174:12)
    at ServerResponse.json (/nix/store/qnyxm50ym8pzyq02zgf97zi109b3m21f-trilium-next-server-0.91.5/share/trilium-server/node_modules/express/lib/response.js:278:15)
    at ServerResponse.send (/nix/store/qnyxm50ym8pzyq02zgf97zi109b3m21f-trilium-next-server-0.91.5/share/trilium-server/node_modules/express/lib/response.js:162:21)
    at file:///nix/store/qnyxm50ym8pzyq02zgf97zi109b3m21f-trilium-next-server-0.91.5/share/trilium-server/src/routes/error_handlers.js:27:13
    at Layer.handle_error (/nix/store/qnyxm50ym8pzyq02zgf97zi109b3m21f-trilium-next-server-0.91.5/share/trilium-server/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (/nix/store/qnyxm50ym8pzyq02zgf97zi109b3m21f-trilium-next-server-0.91.5/share/trilium-server/node_modules/express/lib/router/index.js:326:13)
    at /nix/store/qnyxm50ym8pzyq02zgf97zi109b3m21f-trilium-next-server-0.91.5/share/trilium-server/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/nix/store/qnyxm50ym8pzyq02zgf97zi109b3m21f-trilium-next-server-0.91.5/share/trilium-server/node_modules/express/lib/router/index.js:346:12)

0 replies

MarcS1975 · 2025-02-25T05:27:51Z

MarcS1975
Feb 25, 2025
Author

Just checking - has anyone else found this issue? Sharing notes?
Is anyone of the tech wizzes able to look a this?
Would Very much appreciated.... (Sharing is a go/no-go feature for me)

0 replies

eliandoran · 2025-02-25T12:47:06Z

eliandoran
Feb 25, 2025
Maintainer

Will have a look.

0 replies

eliandoran · 2025-02-25T12:48:54Z

eliandoran
Feb 25, 2025
Maintainer

@FliegendeWurst , the issue you are having, is it related to sharing notes with password or something else?

If it seems unrelated, a complete set of logs would be quite useful.

0 replies

FliegendeWurst · 2025-02-25T13:06:23Z

FliegendeWurst
Feb 25, 2025

I hit the issue with my Android client, when logging in (maybe the previous session cookie was still set?). It seems like a general issue with the way HTTP responses are modified.

0 replies

eliandoran · 2025-02-25T13:59:26Z

eliandoran
Feb 25, 2025
Maintainer

@MarcS1975 , I've just checked and it seems that the issue is not reproducible.

I have tested behind a reverse proxy as well, so it might be related your proxy configuration.
Could you please provide the full server logs so that I can have a better look at the error reported by Trilium?

Are you able to get the password prompt or do you get the error as soon as you try to access it?

0 replies

FliegendeWurst · 2025-02-25T14:08:46Z

FliegendeWurst
Feb 25, 2025

Going by the code at https://github.com/TriliumNext/Notes/blob/v0.91.5/src/routes/error_handlers.ts#L33-L35 (only Trilium code in the stacktrace) the problem seems to be that the error handler is called after the response has already been sent.
There are several uses of sendStatus that could cause the headers to be sent too early, though I can't say with certainty whether that is the root cause.

0 replies

eliandoran · 2025-02-25T14:15:56Z

eliandoran
Feb 25, 2025
Maintainer

@FliegendeWurst , the only case I know that causes this kind of issue is if there is some kind of exception thrown by another middleware layer.

I did notice it when hosting the server on Windows (non-Docker), due to the session handler. But that's why I would need a full log to see if there is something above the error.

0 replies

MarcS1975 · 2025-02-26T09:32:36Z

MarcS1975
Feb 26, 2025
Author

Hi. So when I add the attributes to the note #shareCredentials="user:password". Then I am asked for credentials but get
the following error message:

Below is the log output

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at requestCredentials (file:///usr/src/app/src/share/routes.js:35:9)
    at renderNote (file:///usr/src/app/src/share/routes.js:106:13)
    at file:///usr/src/app/src/share/routes.js:171:9
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:149:13)
    at Route.dispatch (/usr/src/app/node_modules/express/lib/router/route.js:119:3)
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at /usr/src/app/node_modules/express/lib/router/index.js:284:15
    at param (/usr/src/app/node_modules/express/lib/router/index.js:365:14) {
  code: 'ERR_HTTP_HEADERS_SENT'
}
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at ServerResponse.header (/usr/src/app/node_modules/express/lib/response.js:794:10)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:174:12)
    at ServerResponse.json (/usr/src/app/node_modules/express/lib/response.js:278:15)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:162:21)
    at file:///usr/src/app/src/routes/error_handlers.js:27:13
    at Layer.handle_error (/usr/src/app/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:326:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:346:12)
200 GET /api/health-check with 15 bytes took 0ms

0 replies

MarcS1975 · 2025-02-26T09:46:38Z

MarcS1975
Feb 26, 2025
Author

furthermore, when I unprotect the note but share it with user:password label, I get the following error:

and the following error log output:

200 GET /api/health-check with 15 bytes took 0ms
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at requestCredentials (file:///usr/src/app/src/share/routes.js:35:9)
    at renderNote (file:///usr/src/app/src/share/routes.js:106:13)
    at file:///usr/src/app/src/share/routes.js:171:9
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:149:13)
    at Route.dispatch (/usr/src/app/node_modules/express/lib/router/route.js:119:3)
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at /usr/src/app/node_modules/express/lib/router/index.js:284:15
    at param (/usr/src/app/node_modules/express/lib/router/index.js:365:14) {
  code: 'ERR_HTTP_HEADERS_SENT'
}
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at ServerResponse.header (/usr/src/app/node_modules/express/lib/response.js:794:10)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:174:12)
    at ServerResponse.json (/usr/src/app/node_modules/express/lib/response.js:278:15)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:162:21)
    at file:///usr/src/app/src/routes/error_handlers.js:27:13
    at Layer.handle_error (/usr/src/app/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:326:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:346:12)
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at requestCredentials (file:///usr/src/app/src/share/routes.js:35:9)
    at renderNote (file:///usr/src/app/src/share/routes.js:106:13)
    at file:///usr/src/app/src/share/routes.js:171:9
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:149:13)
    at Route.dispatch (/usr/src/app/node_modules/express/lib/router/route.js:119:3)
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at /usr/src/app/node_modules/express/lib/router/index.js:284:15
    at param (/usr/src/app/node_modules/express/lib/router/index.js:365:14) {
  code: 'ERR_HTTP_HEADERS_SENT'
}
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at ServerResponse.header (/usr/src/app/node_modules/express/lib/response.js:794:10)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:174:12)
    at ServerResponse.json (/usr/src/app/node_modules/express/lib/response.js:278:15)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:162:21)
    at file:///usr/src/app/src/routes/error_handlers.js:27:13
    at Layer.handle_error (/usr/src/app/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:326:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:346:12)
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at requestCredentials (file:///usr/src/app/src/share/routes.js:35:9)
    at renderNote (file:///usr/src/app/src/share/routes.js:106:13)
    at file:///usr/src/app/src/share/routes.js:171:9
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:149:13)
    at Route.dispatch (/usr/src/app/node_modules/express/lib/router/route.js:119:3)
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at /usr/src/app/node_modules/express/lib/router/index.js:284:15
    at param (/usr/src/app/node_modules/express/lib/router/index.js:365:14) {
  code: 'ERR_HTTP_HEADERS_SENT'
}
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at ServerResponse.header (/usr/src/app/node_modules/express/lib/response.js:794:10)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:174:12)
    at ServerResponse.json (/usr/src/app/node_modules/express/lib/response.js:278:15)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:162:21)
    at file:///usr/src/app/src/routes/error_handlers.js:27:13
    at Layer.handle_error (/usr/src/app/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:326:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:346:12)
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at requestCredentials (file:///usr/src/app/src/share/routes.js:35:9)
    at renderNote (file:///usr/src/app/src/share/routes.js:106:13)
    at file:///usr/src/app/src/share/routes.js:171:9
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:149:13)
    at Route.dispatch (/usr/src/app/node_modules/express/lib/router/route.js:119:3)
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at /usr/src/app/node_modules/express/lib/router/index.js:284:15
    at param (/usr/src/app/node_modules/express/lib/router/index.js:365:14) {
  code: 'ERR_HTTP_HEADERS_SENT'
}
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at ServerResponse.header (/usr/src/app/node_modules/express/lib/response.js:794:10)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:174:12)
    at ServerResponse.json (/usr/src/app/node_modules/express/lib/response.js:278:15)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:162:21)
    at file:///usr/src/app/src/routes/error_handlers.js:27:13
    at Layer.handle_error (/usr/src/app/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:326:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:346:12)
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at requestCredentials (file:///usr/src/app/src/share/routes.js:35:9)
    at renderNote (file:///usr/src/app/src/share/routes.js:106:13)
    at file:///usr/src/app/src/share/routes.js:171:9
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:149:13)
    at Route.dispatch (/usr/src/app/node_modules/express/lib/router/route.js:119:3)
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at /usr/src/app/node_modules/express/lib/router/index.js:284:15
    at param (/usr/src/app/node_modules/express/lib/router/index.js:365:14) {
  code: 'ERR_HTTP_HEADERS_SENT'
}
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at ServerResponse.header (/usr/src/app/node_modules/express/lib/response.js:794:10)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:174:12)
    at ServerResponse.json (/usr/src/app/node_modules/express/lib/response.js:278:15)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:162:21)
    at file:///usr/src/app/src/routes/error_handlers.js:27:13
    at Layer.handle_error (/usr/src/app/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:326:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:346:12)
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at requestCredentials (file:///usr/src/app/src/share/routes.js:35:9)
    at renderNote (file:///usr/src/app/src/share/routes.js:106:13)
    at file:///usr/src/app/src/share/routes.js:171:9
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at next (/usr/src/app/node_modules/express/lib/router/route.js:149:13)
    at Route.dispatch (/usr/src/app/node_modules/express/lib/router/route.js:119:3)
    at Layer.handle [as handle_request] (/usr/src/app/node_modules/express/lib/router/layer.js:95:5)
    at /usr/src/app/node_modules/express/lib/router/index.js:284:15
    at param (/usr/src/app/node_modules/express/lib/router/index.js:365:14) {
  code: 'ERR_HTTP_HEADERS_SENT'
}
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)
    at ServerResponse.header (/usr/src/app/node_modules/express/lib/response.js:794:10)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:174:12)
    at ServerResponse.json (/usr/src/app/node_modules/express/lib/response.js:278:15)
    at ServerResponse.send (/usr/src/app/node_modules/express/lib/response.js:162:21)
    at file:///usr/src/app/src/routes/error_handlers.js:27:13
    at Layer.handle_error (/usr/src/app/node_modules/express/lib/router/layer.js:71:5)
    at trim_prefix (/usr/src/app/node_modules/express/lib/router/index.js:326:13)
    at /usr/src/app/node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/usr/src/app/node_modules/express/lib/router/index.js:346:12)

0 replies

eliandoran · 2025-02-26T10:17:35Z

eliandoran
Feb 26, 2025
Maintainer

@MarcS1975 , would it be possible for you to restart the server and provide the full logs?
I believe there might be something hidden in the logs that we are not seeing in this excerpt.

0 replies

eliandoran · 2025-02-26T10:24:15Z

eliandoran
Feb 26, 2025
Maintainer

@MarcS1975 , I can reproduce the issue you are having.
The exception you are seeing in the logs is a red herring, that is, it distracts us from the real problem.

What hasn't been mentioned initially is the fact that the note you are sharing is protected:

If you try to access a protected note, regardless of whether there is a share password, it will result in the note not being displayed:

The reasoning for that is that protected notes are encrypted with your login password. Sharing is available to everyone. As such, protected notes cannot be displayed in shares.

The only solution here is to unprotect the note and keep #shareCredentials.

I will fix the error that you are having in the logs (which is a bug on our side), but the end result will be the same: you still need to unprotect the note in order to be able to view it in share.

3 replies

MarcS1975 Feb 27, 2025
Author

@MarcS1975 , I can reproduce the issue you are having. The exception you are seeing in the logs is a red herring, that is, it distracts us from the real problem.

What hasn't been mentioned initially is the fact that the note you are sharing is protected:

Many Thanks for looking at this! Yes I know about the protected note. In the follow-up post (link here) I unprotected the note and got a different error "Site cant be reached!"

I use Caddy as a Reverse Proxy and am adding the Caddy log below. Thats the entry when I call the unprotected Trillium note that is shared with a label user:password. I think this is only a warning, not an error but the message gets logged 9x when I call the Note, so it seems that the server is re-trying and failing.
Can anyone help?

level=
warn
ts=
1740622219.405767
logger=
http.handlers.reverse_proxy
msg=
aborting with incomplete response
upstream=
MY_INTERNAL_IP:PORT
duration=
0.002929167
request.client_ip=
193.114.152.50
request.headers.Accept=
["text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7"]
request.headers.Accept-Encoding=
["gzip, deflate, br, zstd"]
request.headers.Accept-Language=
["en-US,en;q=0.9,de;q=0.8"]
request.headers.Cookie=
["REDACTED"]
request.headers.Dnt=
["1"]
request.headers.If-None-Match=
["W/\"3ea-ipsLeMHA7pRsE6ydq3ukNRxSd34\""]
request.headers.Priority=
["u=0, i"]
request.headers.Sec-Ch-Ua=
["\"Not(A:Brand\";v=\"99\", \"Google Chrome\";v=\"133\", \"Chromium\";v=\"133\""]
request.headers.Sec-Ch-Ua-Mobile=
["?0"]
request.headers.Sec-Ch-Ua-Platform=
["\"Linux\""]
request.headers.Sec-Fetch-Dest=
["document"]
request.headers.Sec-Fetch-Mode=
["navigate"]
request.headers.Sec-Fetch-Site=
["same-origin"]
request.headers.Sec-Fetch-User=
["?1"]
request.headers.Upgrade-Insecure-Requests=
["1"]
request.headers.User-Agent=
["Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36"]
request.headers.X-Forwarded-For=
["193.114.152.50"]
request.headers.X-Forwarded-Host=
["trillium.MY_DOMAIN"]
request.headers.X-Forwarded-Proto=
["https"]
request.host=
trillium.MY_DOMAIN
request.method=
GET
request.proto=
HTTP/3.0
request.remote_ip=
193.114.152.50
request.remote_port=
52116
request.tls.cipher_suite=
4865
request.tls.proto=
h3
request.tls.resumed=
false
request.tls.server_name=
trillium.vintes24.xyz
request.tls.version=
772
request.uri=
/share/23uQXTmDsRp1
error=
reading: unexpected EOF

perfectra1n Feb 27, 2025
Maintainer

Can you share your full Caddy configuration @MarcS1975? Also a quick ASCII diagram of how the HTTP connection flows from your computer to Trilium would be great as well. Does it work as expected when skipping Caddy (and accessing Trilium directly)?

perfectra1n Feb 27, 2025
Maintainer

Your Caddyfile should look something like:

trilium.example.net {
    reverse_proxy 127.0.0.1:8080 {
        header_up Host {host}
        header_up X-Real-IP {remote}
        header_up X-Forwarded-For {remote}
        header_up X-Forwarded-Proto {scheme}
        header_up Upgrade {http.request.header.Upgrade}
        header_up Connection {http.request.header.Connection}
    }

    tls /etc/ssl/note/example.crt /etc/ssl/note/example.net.key
}

# Redirect HTTP to HTTPS
http://trilium.example.net {
    redir https://{host}{uri} permanent
}

eliandoran · 2025-02-26T15:20:34Z

eliandoran
Feb 26, 2025
Maintainer

@MarcS1975 , regarding the HTTP2_PROTOCOL_ERROR, this one comes from your reverse proxy.

I recommend:

Trying to access the server instance directly, without a reverse proxy and see if you can get the correct behaviour.
Check your reverse proxy logs for some hints on why it throws HTTP2_PROTOCOL_ERROR.
Perhaps share your reverse proxy config and people like @perfectra1n might be able to help you.

Moving to discussions since it's only tangentially related to the TriliumNext app.

0 replies

eliandoran · 2025-02-26T15:21:07Z

eliandoran
Feb 26, 2025
Maintainer

@FliegendeWurst , please don't forget to open a separate issue should you encounter the log with "Cannot set headers".

0 replies

perfectra1n · 2025-02-26T20:44:27Z

perfectra1n
Feb 26, 2025
Maintainer

Yes, “ERR_HTTP2_PROTOCOL_ERROR” is an error in Webserver configuration. Can you share your Apache and/or Nginx configuration blocks?

1 reply

perfectra1n Feb 26, 2025
Maintainer

This conversation within our Matrix room might help as well:
https://matrix.to/#/!GkmqViQnKUHXWyQFig:matrix.org/$RQEmIvbNxIN56MeT5aBlqc2i9zAhbLx6LIktZXDuOe4?via=matrix.org&via=perfectra1n.com&via=kde.org

MarcS1975 · 2025-03-05T01:33:54Z

MarcS1975
Mar 5, 2025
Author

@perfectra1n Hello - I am using Caddy as reverse proxy and this is my config:

#
# ––––––––––––––––––––––––––––––––––––––––––––
#  Caddyfile 05-03-24 
# ––––––––––––––––––––––––––––––––––––––––––––
#
{
        email <[email protected]>
}
#
#
https://MYDOMAIN:443 {
        reverse_proxy myhost_ip:port
}

I also tried this version:

https://MY_DOMAIN:443 {
        reverse_proxy MY_HOST:PORT {
        header_up Host {host}
        header_up X-Real-IP {remote}
        header_up X-Forwarded-For {remote}
        header_up X-Forwarded-Proto {scheme}
        header_up Upgrade {http.request.header.Upgrade}
        header_up Connection {http.request.header.Connection}
    }

 #not using this line because I use letsencrypt
#   tls /etc/ssl/note/example.crt /etc/ssl/note/example.net.key
}

Trillium works fine but the shared notes still throw the same error.
Log file as follows:

level=
warn
ts=
1741138098.0234685
logger=
http.handlers.reverse_proxy
msg=
aborting with incomplete response
upstream=
MY_HOST_IP:PORT
duration=
0.002811454
request.client_ip=
_REQUEST_IP
request.headers.Accept=
["text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7"]
request.headers.Accept-Encoding=
["gzip, deflate, br, zstd"]
request.headers.Accept-Language=
["en-US,en;q=0.9,de;q=0.8"]
request.headers.Cache-Control=
["max-age=0"]
request.headers.Connection=
[""]
request.headers.Cookie=
["REDACTED"]
request.headers.Dnt=
["1"]
request.headers.If-None-Match=
["W/\"5fa-JtZb41vsn0gID8fAjZIgPnLFbOw\""]
request.headers.Priority=
["u=0, i"]
request.headers.Sec-Ch-Ua=
["\"Chromium\";v=\"134\", \"Not:A-Brand\";v=\"24\", \"Google Chrome\";v=\"134\""]
request.headers.Sec-Ch-Ua-Mobile=
["?0"]
request.headers.Sec-Ch-Ua-Platform=
["\"Linux\""]
request.headers.Sec-Fetch-Dest=
["document"]
request.headers.Sec-Fetch-Mode=
["navigate"]
request.headers.Sec-Fetch-Site=
["same-origin"]
request.headers.Upgrade=
[""]
request.headers.Upgrade-Insecure-Requests=
["1"]
request.headers.User-Agent=
["Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/134.0.0.0 Safari/537.36"]
request.headers.X-Forwarded-For=
["193.114.152.50:37088"]
request.headers.X-Forwarded-Host=
["MY_DOMAIN.com"]
request.headers.X-Forwarded-Proto=
["https"]
request.headers.X-Real-Ip=
["REQUEST_IP:P"]
request.host=
MY_DOMAIN
request.method=
GET
request.proto=
HTTP/2.0
request.remote_ip=
REQ_IP
request.remote_port=
37088
request.tls.cipher_suite=
4865
request.tls.proto=
h2
request.tls.resumed=
true
request.tls.server_name=
MY_DOMAIN
request.tls.version=
772
request.uri=
/share/zXMneCtWU5JD
error=
reading: unexpected EOF

1 reply

perfectra1n Mar 6, 2025
Maintainer

Does it work when bypassing the reverse proxy, when accessing Trilium directly?
How are you deploying your container? What does your Docker/Portainer configuration look like?

That error looks like some SSL / TLS / Network gore. Almost like the WebSocket “upgrade” isn’t being listened to, or Caddy is sending traffic to a port that is already encrypted (so SSL is being applied 2x, once at Caddy and once at Trilium somehow)

I’ve deployed Trilium in hundreds of different configurations and haven’t seen that before…

perfectra1n · 2025-03-08T22:27:23Z

perfectra1n
Mar 8, 2025
Maintainer

Hmm, there might be something more here. I just created a very similar bug when developing the LLM functionality. It was because of how Express is handling the response. My function was using return res.send() and return res.status().send() which caused conflicts with the route handler in routes.ts...

1 reply

FliegendeWurst Mar 8, 2025

Yes, the error message (ERR_HTTP_HEADERS_SENT) indicates that the server sent the headers too early. It is not really specific to this bug ...

See https://github.com/orgs/TriliumNext/discussions/1290#discussioncomment-12327383

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trilium Next

Bug: Note share with password protection doesn't work #1290

{{title}}

Replies: 17 comments 6 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Trilium Next

Bug: Note share with password protection doesn't work #1290

MarcS1975 Feb 8, 2025

Description

TriliumNext Version

What operating system are you using?

What is your setup?

Operating System Version

Error logs

Replies: 17 comments · 6 replies

FliegendeWurst Feb 10, 2025

MarcS1975 Feb 25, 2025 Author

eliandoran Feb 25, 2025 Maintainer

eliandoran Feb 25, 2025 Maintainer

FliegendeWurst Feb 25, 2025

eliandoran Feb 25, 2025 Maintainer

FliegendeWurst Feb 25, 2025

eliandoran Feb 25, 2025 Maintainer

MarcS1975 Feb 26, 2025 Author

MarcS1975 Feb 26, 2025 Author

eliandoran Feb 26, 2025 Maintainer

eliandoran Feb 26, 2025 Maintainer

MarcS1975 Feb 27, 2025 Author

perfectra1n Feb 27, 2025 Maintainer

perfectra1n Feb 27, 2025 Maintainer

eliandoran Feb 26, 2025 Maintainer

eliandoran Feb 26, 2025 Maintainer

perfectra1n Feb 26, 2025 Maintainer

perfectra1n Feb 26, 2025 Maintainer

MarcS1975 Mar 5, 2025 Author

perfectra1n Mar 6, 2025 Maintainer

perfectra1n Mar 8, 2025 Maintainer

FliegendeWurst Mar 8, 2025

MarcS1975
Feb 8, 2025

Replies: 17 comments 6 replies

FliegendeWurst
Feb 10, 2025

MarcS1975
Feb 25, 2025
Author

eliandoran
Feb 25, 2025
Maintainer

eliandoran
Feb 25, 2025
Maintainer

FliegendeWurst
Feb 25, 2025

eliandoran
Feb 25, 2025
Maintainer

FliegendeWurst
Feb 25, 2025

eliandoran
Feb 25, 2025
Maintainer

MarcS1975
Feb 26, 2025
Author

MarcS1975
Feb 26, 2025
Author

eliandoran
Feb 26, 2025
Maintainer

eliandoran
Feb 26, 2025
Maintainer

MarcS1975 Feb 27, 2025
Author

perfectra1n Feb 27, 2025
Maintainer

perfectra1n Feb 27, 2025
Maintainer

eliandoran
Feb 26, 2025
Maintainer

eliandoran
Feb 26, 2025
Maintainer

perfectra1n
Feb 26, 2025
Maintainer

perfectra1n Feb 26, 2025
Maintainer

MarcS1975
Mar 5, 2025
Author

perfectra1n Mar 6, 2025
Maintainer

perfectra1n
Mar 8, 2025
Maintainer